From 036ad841bf59f5f49cf334bd5f97573c43e5bb4d Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Wed, 26 Jan 2022 21:57:26 +0100 Subject: [PATCH] Remove `using namespace Gtk;` from headers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This causes issues if the header is included early on in particular a conflict with gdkx.h The reference to ‘Window’ is ambiguous `Gtk::Window` vs [X11]Window. --- libs/gtkmm2ext/gtkmm2ext/cell_renderer_color_selector.h | 2 -- libs/gtkmm2ext/gtkmm2ext/cell_renderer_pixbuf_multi.h | 2 -- libs/gtkmm2ext/gtkmm2ext/cell_renderer_pixbuf_toggle.h | 2 -- 3 files changed, 6 deletions(-) diff --git a/libs/gtkmm2ext/gtkmm2ext/cell_renderer_color_selector.h b/libs/gtkmm2ext/gtkmm2ext/cell_renderer_color_selector.h index 2a24347528..0958010492 100644 --- a/libs/gtkmm2ext/gtkmm2ext/cell_renderer_color_selector.h +++ b/libs/gtkmm2ext/gtkmm2ext/cell_renderer_color_selector.h @@ -26,8 +26,6 @@ #include "gtkmm2ext/visibility.h" -using namespace Gtk; - namespace Gtk { class ColorSelectionDialog; } diff --git a/libs/gtkmm2ext/gtkmm2ext/cell_renderer_pixbuf_multi.h b/libs/gtkmm2ext/gtkmm2ext/cell_renderer_pixbuf_multi.h index 2922f329b3..57fdfdd3e8 100644 --- a/libs/gtkmm2ext/gtkmm2ext/cell_renderer_pixbuf_multi.h +++ b/libs/gtkmm2ext/gtkmm2ext/cell_renderer_pixbuf_multi.h @@ -30,8 +30,6 @@ #include "gtkmm2ext/visibility.h" -using namespace Gtk; - namespace Gtkmm2ext { class LIBGTKMM2EXT_API CellRendererPixbufMulti : public Gtk::CellRenderer diff --git a/libs/gtkmm2ext/gtkmm2ext/cell_renderer_pixbuf_toggle.h b/libs/gtkmm2ext/gtkmm2ext/cell_renderer_pixbuf_toggle.h index 0608f5c053..1af13bd84b 100644 --- a/libs/gtkmm2ext/gtkmm2ext/cell_renderer_pixbuf_toggle.h +++ b/libs/gtkmm2ext/gtkmm2ext/cell_renderer_pixbuf_toggle.h @@ -27,8 +27,6 @@ #include "gtkmm2ext/visibility.h" -using namespace Gtk; - namespace Gtkmm2ext { class LIBGTKMM2EXT_API CellRendererPixbufToggle : public Gtk::CellRenderer