From 2b008400c7b9fa1515e4c8d735bea2309c2ee484 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Wed, 9 Jul 2025 10:21:00 -0600 Subject: [PATCH] do not double-transform event coords for piano roll headers the canvas PRH alreadys transforms event coordinates before deliverying the event to a handler; the non-canvas version always gets item-centric coordinates from the GUI toolkit --- gtk2_ardour/prh_base.cc | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/gtk2_ardour/prh_base.cc b/gtk2_ardour/prh_base.cc index 618200efcb..32350d728e 100644 --- a/gtk2_ardour/prh_base.cc +++ b/gtk2_ardour/prh_base.cc @@ -132,8 +132,6 @@ bool PianoRollHeaderBase::scroll_handler (GdkEventScroll* ev) { double evy = ev->y; - double ignore; - event_transform (ignore, evy); int note_range = _adj.get_page_size (); int note_lower = _adj.get_value (); @@ -524,8 +522,6 @@ PianoRollHeaderBase::motion_handler (GdkEventMotion* ev) /* event coordinates are in canvas/window space */ double evy = ev->y; - double ignore; - event_transform (ignore, evy); if (!_scroomer_drag && ev->x < _scroomer_size){ @@ -673,8 +669,6 @@ bool PianoRollHeaderBase::button_press_handler (GdkEventButton* ev) { double evy = ev->y; - double ignore; - event_transform (ignore, evy); /* Convert canvas-coordinates to item coordinates */ @@ -747,8 +741,6 @@ bool PianoRollHeaderBase::button_release_handler (GdkEventButton* ev) { double evy = ev->y; - double ignore; - event_transform (ignore, evy); end_scroomer_drag (); @@ -789,8 +781,6 @@ bool PianoRollHeaderBase::enter_handler (GdkEventCrossing* ev) { double evy = ev->y; - double ignore; - event_transform (ignore, evy); set_note_highlight (_midi_context.y_to_note (evy)); set_cursor (_midi_context.editing_context().cursors()->selector);