From 34c4f7b8eec3a319be1e8a07ebd7ddc217ade704 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Tue, 14 Jan 2020 00:43:34 +0100 Subject: [PATCH] Fix Ardour VAMP plugins (FFT) Bug was introduced in 8ed33f1bc714c1 symbol visibility setting in CFLAGS, CXXFLAGS was overridden. This resulted in publicly exposed and bound kiss_fft symbols in libqm-dsp. At runtime those symbols were resolved using previously bound symbols in libcodec (see below) that uses a mismatching implementation (ardour/qm-dsp uses -Dkiss_fft_scalar=double) #0 0x00007fffea793d40 in kiss_fftr () at /usr/lib/x86_64-linux-gnu/libcodec2.so.0.8.1 #1 0x00007fffcf4516ab in FFTReal::D::forward(double const*, double*, double*) (this=0x5555571d73a0, ri=0x55555a734810, ro=0x55555a7262b0, io=0x55555a728590) at ../libs/qm-dsp/dsp/transforms/FFT.cpp:121 #2 0x00007fffcf4510fd in FFTReal::forward(double const*, double*, double*) (this=0x555559868190, ri=0x55555a734810, ro=0x55555a7262b0, io=0x55555a728590) at ../libs/qm-dsp/dsp/transforms/FFT.cpp:186 --- libs/qm-dsp/wscript | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/qm-dsp/wscript b/libs/qm-dsp/wscript index 728d1fa94e..e9573aeb97 100644 --- a/libs/qm-dsp/wscript +++ b/libs/qm-dsp/wscript @@ -79,8 +79,8 @@ def build(bld): obj.vnum = QM_DSP_VERSION obj.install_path = bld.env['LIBDIR'] if bld.env['build_target'] != 'mingw': - obj.cxxflags = [ bld.env['compiler_flags_dict']['pic'] ] - obj.cflags = [ bld.env['compiler_flags_dict']['pic'] ] + obj.cxxflags += [ bld.env['compiler_flags_dict']['pic'] ] + obj.cflags += [ bld.env['compiler_flags_dict']['pic'] ] def shutdown():