allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

Consistent use of abort() /* NOTREACHED */

Browse Source 
This fixes some static analysis warnings:
PBD::fatal transmitter needs to be connected to a function
that aborts. This is usually the case with GUI
This commit is contained in:
Robin Gareus
2019-09-18 05:57:26 +02:00
parent 60bce78c7e
commit 52021bc3ca
7 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/surfaces/mackie/gui.cc
View File

@@ -371,7 +371,7 @@ MackieControlProtocolGUI::device_dependent_widget ()
if (!surface) {
PBD::fatal << string_compose (_("programming error: %1\n"), string_compose ("n=%1 surface not found!", n)) << endmsg;
/*NOTREACHED*/
abort (); /*NOTREACHED*/
}
Gtk::ComboBox* input_combo = manage (new Gtk::ComboBox);

2
libs/surfaces/us2400/gui.cc
View File

@@ -275,7 +275,7 @@ US2400ProtocolGUI::device_dependent_widget ()
if (!surface) {
PBD::fatal << string_compose (_("programming error: %1\n"), string_compose ("n=%1 surface not found!", n)) << endmsg;
/*NOTREACHED*/
abort (); /*NOTREACHED*/
}
Gtk::ComboBox* input_combo = manage (new Gtk::ComboBox);