allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

Add AutomationControl::set_value_unchecked() and AutomationControl::writable() and use them.

Browse Source 
Classes derived from AutomationControl now check ::writable() in their ::set_value() methods to ensure that they
do not attempt to overwrite data sent to them while automation playback is underway.
This commit is contained in:
Paul Davis
2015-10-21 22:31:30 -04:00
parent 6ca3a1593e
commit 8d3a8ca913
14 changed files with 107 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
libs/ardour/plugin_insert.cc
View File

@@ -405,7 +405,16 @@ PluginInsert::connect_and_run (BufferSet& bufs, pframes_t nframes, framecnt_t of
const float val = c->list()->rt_safe_eval (now, valid);
if (valid) {
c->set_value(val);
/* This is the ONLY place where we are
* allowed to call
* AutomationControl::set_value_unchecked(). We
* know that the control is in
* automation playback mode, so no
* check on writable() is required
* (which must be done in AutomationControl::set_value()
*
*/
c->set_value_unchecked(val);
}
}
@@ -1294,6 +1303,14 @@ PluginInsert::PluginControl::PluginControl (PluginInsert* p,
/** @param val `user' value */
void
PluginInsert::PluginControl::set_value (double user_val)
{
if (writable()) {
set_value_unchecked (user_val);
}
}
void
PluginInsert::PluginControl::set_value_unchecked (double user_val)
{
/* FIXME: probably should be taking out some lock here.. */
@@ -1359,6 +1376,14 @@ PluginInsert::PluginPropertyControl::PluginPropertyControl (PluginInsert*
void
PluginInsert::PluginPropertyControl::set_value (double user_val)
{
if (writable()) {
set_value_unchecked (user_val);
}
}
void
PluginInsert::PluginPropertyControl::set_value_unchecked (double user_val)
{
/* Old numeric set_value(), coerce to appropriate datatype if possible.
This is lossy, but better than nothing until Ardour's automation system