From a7e557ad65fc297b3219015bc646f78b508cc5db Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Wed, 12 Nov 2025 14:56:28 +0100 Subject: [PATCH] Hide colorpicker eyedropper on platforms where it does not work --- libs/tk/ytk/gtkcolorsel.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libs/tk/ytk/gtkcolorsel.c b/libs/tk/ytk/gtkcolorsel.c index 866e552351..1f0050a323 100644 --- a/libs/tk/ytk/gtkcolorsel.c +++ b/libs/tk/ytk/gtkcolorsel.c @@ -366,7 +366,18 @@ gtk_color_selection_init (GtkColorSelection *colorsel) color_sample_new (colorsel); gtk_container_add (GTK_CONTAINER (frame), priv->sample_area); gtk_box_pack_start (GTK_BOX (hbox), frame, TRUE, TRUE, 0); - + +#if !(defined(_WIN32)|| defined(__APPLE__)) + /* hide eyedropper button -- which does not work on OSX: + * " the problem is worse than just `not getting the color' though. + * The action doesn't actually complete, and window focus is in a + * `weird state' until you click inside the color-picker dialog twice; + * then it all seems back to normal (but no color got picked)" + * + * On Windows 7 it works only in Ardour's own Window, but mouse cursor + * is offset, and it's virtually impossible to pick the correct color. + */ + button = gtk_button_new (); gtk_widget_set_events (button, GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK); @@ -380,6 +391,7 @@ gtk_color_selection_init (GtkColorSelection *colorsel) gtk_widget_set_tooltip_text (button, _("Click the eyedropper, then click a color anywhere on your screen to select that color.")); +#endif top_right_vbox = gtk_vbox_new (FALSE, 6); gtk_box_pack_start (GTK_BOX (top_hbox), top_right_vbox, FALSE, FALSE, 0);