From b54c8f973e78bdd909dc14f888d9fe3fa3cb5aa6 Mon Sep 17 00:00:00 2001
From: Robin Gareus <robin@gareus.org>
Date: Thu, 20 Nov 2025 21:38:00 +0100
Subject: [PATCH] Set Transient Parents for edit-context dialogs

---
 gtk2_ardour/edit_note_dialog.cc | 4 ++--
 gtk2_ardour/edit_note_dialog.h  | 2 +-
 gtk2_ardour/editing_context.cc  | 6 +++---
 gtk2_ardour/transform_dialog.cc | 4 ++--
 gtk2_ardour/transform_dialog.h  | 2 +-
 gtk2_ardour/transpose_dialog.cc | 4 ++--
 gtk2_ardour/transpose_dialog.h  | 2 +-
 7 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/gtk2_ardour/edit_note_dialog.cc b/gtk2_ardour/edit_note_dialog.cc
index 6514f7315f..cb9056e512 100644
--- a/gtk2_ardour/edit_note_dialog.cc
+++ b/gtk2_ardour/edit_note_dialog.cc
@@ -43,8 +43,8 @@ using namespace Gtkmm2ext;
  *    @param n Notes to edit.
  */
 
-EditNoteDialog::EditNoteDialog (MidiView* rv, set<NoteBase*> n)
-	: ArdourDialog (_("Note"))
+EditNoteDialog::EditNoteDialog (Gtk::Window& parent, MidiView* rv, set<NoteBase*> n)
+	: ArdourDialog (parent, _("Note"))
 	, _region_view (rv)
 	, _events (n)
 	, _channel_all (_("Set selected notes to this channel"))
diff --git a/gtk2_ardour/edit_note_dialog.h b/gtk2_ardour/edit_note_dialog.h
index c550f3a296..d3f93f74e2 100644
--- a/gtk2_ardour/edit_note_dialog.h
+++ b/gtk2_ardour/edit_note_dialog.h
@@ -28,7 +28,7 @@ class NoteBase;
 class EditNoteDialog : public ArdourDialog
 {
 public:
-	EditNoteDialog (MidiView* rv, std::set<NoteBase*> n);
+	EditNoteDialog (Gtk::Window&, MidiView* rv, std::set<NoteBase*> n);
 
 	void done (int);
 
diff --git a/gtk2_ardour/editing_context.cc b/gtk2_ardour/editing_context.cc
index 4238350c6b..be9ef3de92 100644
--- a/gtk2_ardour/editing_context.cc
+++ b/gtk2_ardour/editing_context.cc
@@ -2104,7 +2104,7 @@ EditingContext::transform_regions (const MidiViews& rs)
 		return;
 	}
 
-	TransformDialog td;
+	TransformDialog td (*transient_parent ());
 
 	td.present();
 	const int r = td.run();
@@ -2135,7 +2135,7 @@ EditingContext::transpose_regions (const MidiViews& rs)
 		return;
 	}
 
-	TransposeDialog d;
+	TransposeDialog d (*transient_parent ());
 	int const r = d.run ();
 
 	if (r == RESPONSE_ACCEPT) {
@@ -2168,7 +2168,7 @@ EditingContext::edit_notes (MidiView* mrv)
 		return;
 	}
 
-	EditNoteDialog* d = new EditNoteDialog (mrv, s);
+	EditNoteDialog* d = new EditNoteDialog (*transient_parent (), mrv, s);
 	d->show_all ();
 
 	d->signal_response().connect (sigc::bind (sigc::mem_fun (*this, &EditingContext::note_edit_done), d));
diff --git a/gtk2_ardour/transform_dialog.cc b/gtk2_ardour/transform_dialog.cc
index 8c5b61992b..4edfb34301 100644
--- a/gtk2_ardour/transform_dialog.cc
+++ b/gtk2_ardour/transform_dialog.cc
@@ -76,8 +76,8 @@ TransformDialog::Model::Model()
 	}
 }
 
-TransformDialog::TransformDialog()
-	: ArdourDialog(_("Transform"), false, false)
+TransformDialog::TransformDialog(Gtk::Window& parent)
+	: ArdourDialog(parent, _("Transform"), false, false)
 {
 	_property_combo.set_model(_model.property_list);
 	_property_combo.pack_start(_model.property_cols.label);
diff --git a/gtk2_ardour/transform_dialog.h b/gtk2_ardour/transform_dialog.h
index 3c20388674..eba00ea377 100644
--- a/gtk2_ardour/transform_dialog.h
+++ b/gtk2_ardour/transform_dialog.h
@@ -49,7 +49,7 @@
 class TransformDialog : public ArdourDialog
 {
 public:
-	TransformDialog();
+	TransformDialog(Gtk::Window&);
 
 	ARDOUR::Transform::Program get();
 
diff --git a/gtk2_ardour/transpose_dialog.cc b/gtk2_ardour/transpose_dialog.cc
index 90a0c3a592..bdfc161fdf 100644
--- a/gtk2_ardour/transpose_dialog.cc
+++ b/gtk2_ardour/transpose_dialog.cc
@@ -26,8 +26,8 @@
 
 using namespace Gtk;
 
-TransposeDialog::TransposeDialog ()
-	: ArdourDialog (_("Transpose MIDI"))
+TransposeDialog::TransposeDialog (Gtk::Window& parent)
+	: ArdourDialog (parent, _("Transpose MIDI"))
 	, _octaves_adjustment (0.0, -4.0, 4.0, 1, 2.0)
 	, _semitones_adjustment (0.0, -12.0, 12.0, 1.0, 4.0)
 	, _octaves_spinner (_octaves_adjustment)
diff --git a/gtk2_ardour/transpose_dialog.h b/gtk2_ardour/transpose_dialog.h
index 7de1306b11..3726409514 100644
--- a/gtk2_ardour/transpose_dialog.h
+++ b/gtk2_ardour/transpose_dialog.h
@@ -30,7 +30,7 @@
 class TransposeDialog : public ArdourDialog
 {
 public:
-	TransposeDialog ();
+	TransposeDialog (Gtk::Window&);
 
 	int semitones () const;