From c0425ba70f5ee60b4e583f566612bbf1ef050ba1 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Tue, 27 Jul 2021 13:15:33 -0600 Subject: [PATCH] canvas: items should not add child bboxes in their ::compute_bounding_box() method, Item::bounding_box() does that --- libs/canvas/step_button.cc | 2 +- libs/surfaces/maschine2/ui_knob.cc | 2 +- libs/surfaces/push2/knob.cc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libs/canvas/step_button.cc b/libs/canvas/step_button.cc index 289da2b43a..3692d95b3f 100644 --- a/libs/canvas/step_button.cc +++ b/libs/canvas/step_button.cc @@ -67,7 +67,7 @@ StepButton::compute_bounding_box () const { _bounding_box = Rect (0, 0, width, height); - add_child_bounding_boxes (); + /* Item::bounding_box() will add children */ bb_clean (); } diff --git a/libs/surfaces/maschine2/ui_knob.cc b/libs/surfaces/maschine2/ui_knob.cc index cbcabb1bfe..9cff3aeb53 100644 --- a/libs/surfaces/maschine2/ui_knob.cc +++ b/libs/surfaces/maschine2/ui_knob.cc @@ -158,7 +158,7 @@ Maschine2Knob::compute_bounding_box () const _bounding_box_dirty = false; } - add_child_bounding_boxes (); + /* Item::bounding_box() will add children */ } void diff --git a/libs/surfaces/push2/knob.cc b/libs/surfaces/push2/knob.cc index 05e830dfd0..1f40da5e43 100644 --- a/libs/surfaces/push2/knob.cc +++ b/libs/surfaces/push2/knob.cc @@ -251,7 +251,7 @@ Push2Knob::compute_bounding_box () const _bounding_box_dirty = false; } - add_child_bounding_boxes (); + /* Item::bounding_box() will add children */ } void