allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

Revert "avoid double-free of MIDI sys ex and patch change canvas items"

Browse Source 
This reverts commit 0ddc050555.

It is not clear what this commit was really trying to do - when canvas items
are deleted they are removed from their parent, so just *not* deleting them
should not by itself fix an issue.

It turns out that not deleting the canvas item means that it remains in the
canvas scene graph to deliver events to, at which time it references its
now-deleted owner object, leading to a crash.

We need to keep an eye open for crashes resembling the double-free that this
reverted commit claimed to fix.
This commit is contained in:
Paul Davis
2025-12-11 11:36:52 -07:00
parent 856aad62da
commit e664fa5e63
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gtk2_ardour/patch_change.cc
View File

@@ -75,7 +75,7 @@ PatchChange::PatchChange (MidiView& region,
PatchChange::~PatchChange () PatchChange::~PatchChange ()
{ {
/* _flag is deleted by the canvas container/parent it is placed in */ delete _flag;
} }
void void

2
gtk2_ardour/sys_ex.cc
View File

@@ -55,7 +55,7 @@ SysEx::SysEx (
SysEx::~SysEx() SysEx::~SysEx()
{ {
/* _flag is deleted by the canvas container/parent it is placed in */ delete _flag;
} }
bool bool