Fix potential vulnerable cloned functions: Save stack space while handling errors
This commit is contained in:
@@ -490,8 +490,10 @@ void luaV_concat (lua_State *L, int total) {
|
||||
/* collect total length and number of strings */
|
||||
for (n = 1; n < total && tostring(L, top - n - 1); n++) {
|
||||
size_t l = vslen(top - n - 1);
|
||||
if (l >= (MAX_SIZE/sizeof(char)) - tl)
|
||||
if (l >= (MAX_SIZE/sizeof(char)) - tl) {
|
||||
L->top = top - total; /* pop strings to avoid wasting stack */
|
||||
luaG_runerror(L, "string length overflow");
|
||||
}
|
||||
tl += l;
|
||||
}
|
||||
if (tl <= LUAI_MAXSHORTLEN) { /* is result a short string? */
|
||||
@@ -506,7 +508,7 @@ void luaV_concat (lua_State *L, int total) {
|
||||
setsvalue2s(L, top - n, ts); /* create result */
|
||||
}
|
||||
total -= n-1; /* got 'n' strings to create 1 new */
|
||||
L->top -= n-1; /* popped 'n' strings and pushed one */
|
||||
L->top = top - (n - 1); /* popped 'n' strings and pushed one */
|
||||
} while (total > 1); /* repeat until only 1 result left */
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user