allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

surfaces & event loops: i really mean no more request buffer factories

Browse Source
This commit is contained in:
Paul Davis
2023-04-21 13:55:58 -06:00
parent b0586763ba
commit f718279949
41 changed files with 1 additions and 262 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
libs/ctrl-interface/control_protocol/control_protocol/control_protocol.h
View File

@@ -180,15 +180,6 @@ public:
bool (*probe) (ControlProtocolDescriptor*);
ControlProtocol* (*initialize) (ControlProtocolDescriptor*, Session*);
void (*destroy) (ControlProtocolDescriptor*, ControlProtocol*);
/* this is required if the control protocol connects to signals
* from libardour. they all do. It should allocate a
* type-specific request buffer for the calling thread, and
* store it in a thread-local location that will be used to
* find it when sending the event loop a message
* (e.g. call_slot()). It should also return the allocated
* buffer as a void*.
*/
void* (*request_buffer_factory) (uint32_t);
};
}
}

11
libs/ctrl-interface/midi_surface/midi_surface.cc
View File

@@ -437,14 +437,3 @@ MIDISurface::bundles ()
return b;
}
void*
MIDISurface::request_factory (uint32_t num_requests)
{
/* AbstractUI<T>::request_buffer_factory() is a template method only
instantiated in this source module. To provide something visible for
use in the interface/descriptor, we have this static method that is
template-free.
*/
return request_buffer_factory (num_requests);
}

2
libs/ctrl-interface/midi_surface/midi_surface/midi_surface.h
View File

@@ -48,8 +48,6 @@ class MIDISurface : public ARDOUR::ControlProtocol
MIDISurface (ARDOUR::Session&, std::string const & name, std::string const & port_name_prefix, bool use_pad_filter);
~MIDISurface ();
static void* request_factory (uint32_t num_requests);
std::shared_ptr<ARDOUR::Port> input_port();
std::shared_ptr<ARDOUR::Port> output_port();