Commit Graph

16719 Commits

Author SHA1 Message Date
Robin Gareus
c0287cb0de Fix thinko in e81b2353cc, selection may not start at a marker
This fixes a crash when selecting a section, and then changing
the time-selection. Previously it was assumed that the section
context menu can only be shown for sections. But it applies to
any time[line]-selection.
2023-09-09 21:27:11 +02:00
Asahi Lina
d1cc71150f Adjust interpretation of swing amount
Previously,

0 -> no swing (1:1, 50%)
50 -> triplet swing (2:1, 66%)
75 -> hard swing (3:1, 75%)
100 -> sextuplet swing (5:1, 83%) (default!)
150 -> absolute maximum (inf:1, 100%)

This is rather confusing...

One common interpretation uses percentages of the beat, where triplet
swing is 66%. However, that causes precision issues since it's really
66.666...

Since we already default to 100 and take "no swing" as zero, let's make
that reference point triplet swing. Then the scale becomes:

0 -> no swing (1:1)
100 -> triplet swing (2:1)
150 -> hard swing (3:1)
200 -> sextuplet swing (5:1)
300 -> absolute maximum (inf:1)

300 doesn't make any sense, so let's change the range to -250 .. 250
which covers all useful values.

Also remove the division through 100 and back, to avoid rounding issues.

Signed-off-by: Asahi Lina <lina@asahilina.net>
2023-09-09 20:06:37 +09:00
Asahi Lina
ca25b5c841 Fix quantize threshold setting
Signed-off-by: Asahi Lina <lina@asahilina.net>
2023-09-09 20:06:37 +09:00
Asahi Lina
577918dc07 Fix quantize beat divisions
Signed-off-by: Asahi Lina <lina@asahilina.net>
2023-09-09 20:06:37 +09:00
Paul Davis
aca5d7d988 place lollipops in correct location on timeline
It is not immediately clear to me why the + radius expression is reqired
2023-09-08 16:16:15 -06:00
Ben Loftis
503e6249f4 remove GridTypePlayhead 2023-09-08 15:27:04 -05:00
Robin Gareus
d57676b9c7 Maybe clear time-selection when switching to draw tool 2023-09-08 14:50:43 +02:00
Ben Loftis
e81b2353cc Indicate arrangement section selection on canvas 2023-09-08 03:26:00 +02:00
Robin Gareus
b243b93072 Allow to reuse range context menu w/o track/region selection 2023-09-08 03:25:59 +02:00
Robin Gareus
019a3a1976 Allow to select Arrangement sections
This also adds interaction with sections in the
Arrangement Ruler.

Note that selecting a range switches to the Range tool.
This is enforced because time-range selection is only meaningful
with tools that perform edit operations on the whole timeline.
2023-09-08 03:25:59 +02:00
Ben Loftis
b6e9f37007 Arrangement Sidebar: follow-edits locates to selected section 2023-09-08 03:25:59 +02:00
Robin Gareus
d2b083f385 Arrangement Sidebar: allow name edit by double-click 2023-09-08 03:25:59 +02:00
Robin Gareus
78db634321 Unconditionally show time-selection in info box with object tool
Arrangement Section can be selected with the object tool,
and should be indicated even when not using Smart mode.
2023-09-08 03:25:59 +02:00
Robin Gareus
20b646e962 Handle MouseGrid cursor (fix -Wswitch, amend 784d2ecc) 2023-09-08 03:25:59 +02:00
Paul Davis
250174b16e don't bother locating at end of no-motion marker drag if using external sync 2023-09-07 14:23:08 -06:00
Paul Davis
f9a121ce9c click (no drag) on markers locates there, unless using marker as edit point 2023-09-07 14:23:08 -06:00
Ben Loftis
3f14b27ee3 remove (unimplemnted) Stretch MIDI checkbox 2023-09-07 15:18:36 -05:00
Robin Gareus
cc47b5fe3c Only allow grid-tool with musical grid 2023-09-06 23:56:10 +02:00
Paul Davis
966dce5516 remove now-invalid tempo edit menu items 2023-09-06 15:29:55 -06:00
Ben Loftis
da4d2a645f remove tempo-mapping bar, tempo_meta group. this reverts 8fbf2c and related 2023-09-06 19:31:00 +02:00
Ben Loftis
784d2ecce4 Add the tool for Grid, and accompanying buttons and event-handling 2023-09-06 19:30:56 +02:00
Ben Loftis
268d1d33c7 Add invisible Rectangle to initiates Tempo(grid) drags 2023-09-06 19:14:14 +02:00
Robin Gareus
80a813ff1c Fix use-after-free when undoing marker creation
Create a marker by ctrl-click, hover over it and then ctrl+z
undo. This used to crash in Editor::get_preferred_edit_position()
gtk2_ardour/editor.cc:5179, checking for entered_marker->position()
2023-09-06 17:37:11 +02:00
Robin Gareus
3851a93e39 Update selection-markers on track and time selection 2023-09-06 00:02:36 +02:00
Robin Gareus
10ff5ad599 Use section delete for Editor::Delete operation 2023-09-06 00:02:31 +02:00
Ben Loftis
6e87a46ba4 convention for selection (as used on track headers) is red border, red tint 2023-09-05 23:08:30 +02:00
Robin Gareus
29430ac550 NO-OP: clang-format 2023-09-05 23:08:30 +02:00
Robin Gareus
68ccbc8ac3 Arrangement: locate on double-click 2023-09-05 23:08:30 +02:00
Ben Loftis
e5e40c751f if user moves selection markers, convert selection to a timeline section 2023-09-05 23:08:30 +02:00
Ben Loftis
4217a68852 Arranger: implement bi-directional selection 2023-09-05 23:08:30 +02:00
Ben Loftis
5ceb66c902 Arranger: allow renaming by context-menu 2023-09-05 23:08:29 +02:00
Robin Gareus
cf9f9db48b Set length of new percussive hits to 1 tick
This prevents overlap of successive hits.

Ardour 7 added a new duration select drop-down menu,
which defaults to "Auto" (musical grid) and removed
the special case when drawing percussive notes.
It was possible to accidentally create overlapping notes,
without the user being aware of doing so.
2023-09-04 23:26:54 +02:00
Ben Loftis
7d95334c0d fix thinko in e53a7 which resulted in unmatched tempo-map UNDO transactions 2023-09-04 08:48:49 -05:00
Robin Gareus
774adfb33c Fix rounding of arrangement markers 2023-09-01 21:53:26 +02:00
Ben Loftis
a6844279ad arranger-treeview 'search' function was stealing keybd events 2023-09-01 07:18:22 -05:00
Paul Davis
0d89bc5789 fix height of tempo ruler curve elements
These were being drawn in a way that failed to really convey relative
tempos very well. This is now better, though perhaps there are other
improvements possible
2023-08-31 18:25:18 -06:00
Paul Davis
da9140a390 polish the way we print tempo numerics in tempo ruler 2023-08-31 10:34:48 -06:00
Paul Davis
43d6d4187c display tempo with only 1 digit of decimals 2023-08-31 10:34:48 -06:00
Robin Gareus
b5b4be96e3 Use "Arrangement" in GUI instead of Section (amend 2f6a0abf) 2023-08-31 16:12:50 +02:00
Robin Gareus
1bc795509b Use "Arrangement" in GUI instead of Section (amend 2f6a0abf) 2023-08-31 05:29:29 +02:00
Robin Gareus
b162ffbca8 Clear Arrangement rects when closing a session 2023-08-31 00:58:51 +02:00
Paul Davis
8209cb0ab5 launchpad pro: remove color map; implement note/x,y mapping 2023-08-30 16:06:13 -06:00
Paul Davis
9d153af72d image for launchpad pro "gui" 2023-08-30 16:06:13 -06:00
Paul Davis
3fa15d9162 skeleton for launchpad pro support 2023-08-30 16:06:13 -06:00
Robin Gareus
7997c83b01 Allow to edit arrangement label in sidebar 2023-08-30 23:04:39 +02:00
Paul Davis
44e1de4261 no warning dialog about tempo map cut/copy/paste
Left in place since it may come back in a different form
2023-08-30 14:16:21 -06:00
Paul Davis
076320430a assert() that the tempo & Meter markers associated with a BBT marker exist 2023-08-30 14:16:21 -06:00
Robin Gareus
797c362500 Fix segfault when undoing marker deletion
find_location_markers() may return NULL.
This also consolidates code from acc55083e5
2023-08-30 20:46:20 +02:00
Robin Gareus
aaff022fd2 Fix typo in dbda07f6b7 2023-08-30 19:40:19 +02:00
Robin Gareus
affea2b83b NO-OP: remove reducant code 2023-08-30 18:31:13 +02:00