Commit Graph

18371 Commits

Author SHA1 Message Date
Paul Davis
20ebcc408d fix type from b489d466cf that resensitized the ghost note, causing crashes
Oddly, much, much easier to make happen on macOS and/or mixbus
2025-08-19 23:29:58 -06:00
Paul Davis
1e2a2d5506 remove infinitely recursive, never-called method from MidiView 2025-08-19 23:29:58 -06:00
Paul Davis
b0eafc7a7c update preferences metadata (source text and C++ code) 2025-08-19 13:40:13 -06:00
Paul Davis
20701362c3 also scale drag move threshold by UI scale
If UI scale is > 1, pixels are likely small, so it seems appropriate to scale
2025-08-19 12:09:12 -06:00
Paul Davis
86da6740cb expose drag sensitivity in preferences 2025-08-19 12:09:12 -06:00
Paul Davis
d316a4b1c3 scale move threshold by UIConfiguration parameter 2025-08-19 12:09:12 -06:00
Paul Davis
99585debbe change use of MoveThreshold.first to reflect pixel units 2025-08-19 12:09:12 -06:00
Paul Davis
fc08397ad8 use both relevant UIConfiguration parameters in ::move_threshold() 2025-08-19 12:09:12 -06:00
Paul Davis
059497ea3d add move threshold sensitivity parameter for UI 2025-08-19 12:09:12 -06:00
Paul Davis
1efd0c06bd move threshold for drags goes back to pair<int,int>
And for now, there's only a single implementation, though other types of
drags could implement it if needed. There really seems to be no need.

Note that the x-axis threshold is 3x in the case of a copy-drag.
2025-08-19 12:09:12 -06:00
Paul Davis
f34e314d93 move _copy member of some types of drags into Drag base class
this allows us to use it when computing move thresholds
2025-08-19 12:09:12 -06:00
Paul Davis
ee6356d9df remove crashing assert() when rendering scroomer
Too hard to get a floating point assert correct, but I think this is still a little
incorrect because we do not scale the kbd size when rendering it.
2025-08-19 10:53:06 -06:00
Paul Davis
66dde32a1b no more BBT_Time round/round_up methods (GUI edition) 2025-08-19 10:53:06 -06:00
Robin Gareus
d2512c814a Use short labels for grid and beat-div dropdown 2025-08-19 18:24:22 +02:00
Robin Gareus
e74dbf6ef7 Pianoroll: the return of the draw box (amend 8ffd45c3c) 2025-08-19 15:36:44 +02:00
Robin Gareus
8ffd45c3c0 Don't expand GUI as much on first load
The editor-toolbar still needs a major cleanup, it's
very busy
2025-08-19 15:25:24 +02:00
Robin Gareus
44ceb91e52 Use new YTKMM API instead of ytk+ 2025-08-19 14:40:49 +02:00
Robin Gareus
07dc5c0fc0 Remove cruft 2025-08-19 14:04:13 +02:00
Robin Gareus
936f8734b4 Tweak editor bottom pane packing, never unpack the property box 2025-08-19 14:03:19 +02:00
Robin Gareus
f9cdaf698c Never unpack the selection-property-box
This is used to for all selection: route, plugins,
time and region and slot selection.

Only re-pack it with different expand option when
the pianoroll is also visible
2025-08-19 13:28:51 +02:00
Robin Gareus
014d231d13 Fix preference enum - see 4826a90796 2025-08-19 04:48:45 +02:00
Robin Gareus
32f162ec9a Fix invalid markup (scene name) 2025-08-19 03:24:20 +02:00
Paul Davis
4826a90796 prefs editing widgets for region-edit-disposition 2025-08-18 19:04:05 -06:00
Paul Davis
368189c4f6 an initial guess at using the new region-edit-disposition parameter
No editing of the parameter yet
2025-08-18 18:26:10 -06:00
Paul Davis
1817aa5c2d add a new UI prefs variable/type for region edit disposition
i.e. where to edit a selected or specifically chosen region
2025-08-18 17:08:23 -06:00
Robin Gareus
017ad176ad Expand route properties on cue page when strip is selected
This is currently only for Mixbus' benefit, showing
the channelstrip and plugin(s); but may become relevant
for Ardour sometime.
2025-08-18 23:27:03 +02:00
Robin Gareus
8dfd116b58 Properly hide cue editors (unmap macOS GLCanvas views) 2025-08-18 23:25:44 +02:00
Robin Gareus
06a2b174dd Fix crash at session close
see also 6672db97. in theory re-assigning a sigc::connection
should disconnect the previous connection, but for yet
unknown reasons this does no happen here.
2025-08-18 23:25:43 +02:00
Paul Davis
bd34f1744d add window geometry to region UI settings, and save after changes
Changes are detected in Pianoroll::canvas_allocate(), which is a proxy for window
geometry. Since Pianoroll doesn't own a window, this is not necessarily ideal, but it
works.
2025-08-18 12:47:25 -06:00
Edgar Aichinger
66599dac36 update german (gtk2_ardour only for now) translation 2025-08-17 17:47:35 +02:00
Robin Gareus
6672db9794 Fix crash at session close - fix use-after-free
Pianoroll::maybe_update() was able to use _session
after session was already unset.
2025-08-17 06:34:31 +02:00
Robin Gareus
a91aa6ee9d Except pianoroll CC metabuttons (w/submenu) from scrolling 2025-08-17 06:30:35 +02:00
Robin Gareus
6b79d4ab98 Add option to hide rendered UI instructions #9975 2025-08-17 00:34:53 +02:00
Robin Gareus
a270ae2aa3 Fix VST3 spec link 2025-08-16 23:11:19 +02:00
Robin Gareus
d35faf052e Add popup dialog when MMCSS threads are exhausted 2025-08-16 23:11:19 +02:00
Paul Davis
cf14fe75f2 add some debugging info to help diagnose a crash 2025-08-16 12:01:20 -06:00
Robin Gareus
648e8f9f00 Fix use-after free, and double-packing of proc-box (amend 844d45896) 2025-08-15 18:53:19 +02:00
Paul Davis
192c7a2f9a fix for a subtle bug that led to track headers not expanding as intended
now that we use action-as-state, there was no way to look up the old
mouse mode when changing into or out of internal editing. this
prevented us from queuing the redisplay of trackviews that allows the track
headers to expand when appropriate.
2025-08-14 18:48:04 -06:00
Paul Davis
e467ee77f8 just rename a variable for more clarity when reading code 2025-08-14 14:55:37 -06:00
Paul Davis
63db3d3736 fix interference between timer-based update in CueEditors and scroll-drag 2025-08-14 14:55:37 -06:00
Robin Gareus
844d458969 Add optional ProcessorBox to Route-Properties (bottom attachment) 2025-08-14 00:11:47 +02:00
Todd Naugle
fbc4156eac Spelling Fix 2025-08-13 17:05:35 -05:00
Paul Davis
5bdb6137ef the other half of the half note half-fix 2025-08-13 11:16:20 -06:00
Paul Davis
dc85f65efa it might be a minim to you, but it's a half note to me 2025-08-13 11:15:39 -06:00
Paul Davis
5c2afa74e1 restore missing 1/8th note option from grid type selector 2025-08-13 11:05:05 -06:00
Paul Davis
5dbba0b154 when adding automation points from the kbd, use guard points
It's just better when you edit later.
2025-08-12 23:29:54 -06:00
Paul Davis
aa68198487 when adding automation points from kbd, don't translate y coordinate
since we have no screen position, we've already call ControlList::eval() and
that's the number we should be using for the new point.
2025-08-12 23:29:03 -06:00
Paul Davis
289264b29d add new contributor name to credits 2025-08-12 21:49:55 -06:00
Paul Davis
fa97071872 mamy improvements to kbd-driven automation editing
Really needs a short video to demo/explain
2025-08-12 21:44:50 -06:00
Paul Davis
a7621896c2 NO-OP no double semi-colons 2025-08-12 21:44:50 -06:00