Commit Graph

16074 Commits

Author SHA1 Message Date
Paul Davis
5e9e21911c corrections for methods that move playhead to region boundaries
1. "not found" is now indicated by a timepos_t::max() value, not a negative one.
2. if the direction to search is negative we should decrement (when possible)
before searching, to avoid finding the current position.
2022-12-10 18:13:48 -07:00
Robin Gareus
d62cba8ba5 Add tooltip for mixer-strip color/number label 2022-12-10 22:22:31 +01:00
Paul Davis
dc74decdf7 remove luminance changes from ARDOUR_UI_UTILS::unique_palette_color() 2022-12-10 13:45:07 -07:00
Paul Davis
6ed1402812 use ItemChangeBlocker to improve performance of RegionView::remove_silent_frames() 2022-12-10 13:40:06 -07:00
Paul Davis
8237a8115c cleanup unused variables in Editor ruler display code 2022-12-10 10:48:59 -07:00
Paul Davis
303f838a53 define new actions for stopping triggers/slots 2022-12-10 10:33:39 -07:00
Paul Davis
4fdd8646b4 fix positioning of regions during multiduplicate or fill track operations 2022-12-10 09:43:43 -07:00
Paul Davis
425f84493b fix display of selection end point and duration (again!) 2022-12-10 09:43:43 -07:00
Robin Gareus
cb2f08f50c Consistent ruler area colors
This fixes a special case of the loop/punch ruler, which
only had effect on session-reload due to a copy/edit bug
(canvas_transport_marker_bar_event used "range marker bar")
2022-12-10 15:14:39 +01:00
Robin Gareus
eb42318d3e Consolidate ruler prelight events
This fixes various copy/edit bugs (e.g. transport ruler uses
"range marker bar" colors, but only after a enter/leave event).
2022-12-10 15:14:29 +01:00
Robin Gareus
3875468935 Remove unused "opaque region base" from themes 2022-12-10 02:37:05 +01:00
Robin Gareus
516bf1fa17 Set "opaque region base" alpha to 1.0 2022-12-10 02:37:05 +01:00
Robin Gareus
a0d36a03b4 Tweak ARV waveform colors to match new transparency model 2022-12-10 02:37:05 +01:00
Robin Gareus
fc53754055 Remove "midi frame base" from themes 2022-12-10 02:37:05 +01:00
Robin Gareus
3442500002 Remove "midi frame base", consistent TAV color (1/2) 2022-12-10 02:37:05 +01:00
Robin Gareus
0bb81a9a18 Do not shade transparent regions in Layered mode
There already is a shaded coverage frame indicating
if a layer is audible. This leads to a more consistent view.

In addition changing layered mode now has to update the
colors (set_frame_color).
2022-12-10 02:37:05 +01:00
Robin Gareus
6c524b3f3b Use a dedicated Canvas Group for ARV 2022-12-10 02:37:05 +01:00
Robin Gareus
f003bee985 Use a dedicated Canvas Group for MRV
This fixes rendering of opaque MIDI regions (previously
MIDI regions were always transparent). This change provides a
way to "flatten" layered MIDI regions, while still allowing
to show the note-line and grid behind the regions.
2022-12-10 02:37:05 +01:00
Robin Gareus
1efa5e9a55 Prepare themes for region/grid transparency 2022-12-10 02:37:05 +01:00
Robin Gareus
dcf981fe07 Remove remnants from AudioMidi Tracks
This fixes meter faceplace background color when adding
a MIDI port to an audio track.
2022-12-10 02:36:46 +01:00
Robin Gareus
b2fddeb43d Add named ranges to quick export dialog 2022-12-09 19:22:59 +01:00
Paul Davis
74f95ff0dd when use stripable palette colors, use them sequentially
Also break this code out into a separate method
2022-12-08 10:52:57 -07:00
Paul Davis
cd4b6e85a8 pick route colors from the color palette (with random variation) #9115 2022-12-07 21:27:51 -07:00
Robin Gareus
ea50799ce2 Remove duplicate implementation
`bool cocoa_open_url (const char*)` is implemented in 
libs/pbd/cocoa_open_uri.mm
2022-12-08 01:32:41 +01:00
Paul Davis
b9f9531fa1 duration clocks: fix display when mode is changed 2022-12-07 12:11:31 -07:00
Paul Davis
ad9757e73c fix nudge/duration clocks when scrolling in BBT mode 2022-12-07 11:13:49 -07:00
Paul Davis
9f85a0aaba fix behavior of duration clocks when scrolling in all modes except BBT 2022-12-07 11:13:49 -07:00
Robin Gareus
313f7ad344 Use new API to compare export format/spec 2022-12-07 17:57:56 +01:00
Robin Gareus
0abbe651ea Remove debug output 2022-12-07 00:28:21 +01:00
Paul Davis
f37687a985 various fixes for AudioClock duration/!duration confusion 2022-12-06 11:11:08 -07:00
Paul Davis
7850628f6f fix manual drawing of MIDI automation (avoid offset) #9142
Change assumption that the "pos" argument to AutomationRegionView::add_automation_event is region-relative, by
making it global.

This did not affect non-MIDI automation because that used
AutomationTimeAxisView::add_automation_view() instead.
2022-12-06 11:11:08 -07:00
Robin Gareus
32b6db092c NO-OP: whitespace and comment 2022-12-06 17:30:59 +01:00
Robin Gareus
e7b0df0231 Export Format Dialog: constrain sample-rates 2022-12-06 06:35:47 +01:00
Robin Gareus
4acc458a78 GUI support for OPUS encoding 2022-12-05 23:43:50 +01:00
Robin Gareus
8a7684bd2f Use 1|1|0 for new BBT markers, always use dialog for new markers
Amend b972301a3b
2022-12-05 19:18:26 +01:00
Robin Gareus
2bca6395cc Attempted fix for idle_drop_window random crashes (1/2) 2022-12-03 19:27:45 +01:00
Robin Gareus
b972301a3b Add action to noninteractively add BBT marker at playhead 2022-12-02 21:31:56 +01:00
Robin Gareus
d808315e2a Offer dedicated alternatives for Delete/Backspace
This follows Processor Box:
 <Binding key="Delete" action="ProcessorMenu/delete"/>
 <Binding key="BackSpace" action="ProcessorMenu/backspace"/>
2022-12-02 19:50:39 +01:00
Robin Gareus
899cacdf86 Delete/BackSpc clears selected trigger-clos 2022-12-02 19:19:20 +01:00
Robin Gareus
5d42509a21 Report error to user in startupFSM
StartupFSM does not catch SessionException from Session::load_state,
but bails out early, after checking `get_info_from_path` instead.
So we have to explicitly report errors.
2022-11-29 20:03:44 +01:00
Paul Davis
c312d570f4 move twist-tempo drag from tempo ruler to BBT ruler
Behavior remains unchanged, just the location/ruler for the start of the drag.
2022-11-29 10:09:39 -07:00
Paul Davis
cd86521c65 rulers: improve labelling of non-quarter note beats in tempo ruler 2022-11-29 10:09:39 -07:00
Paul Davis
8b06eb9878 editor rulers: do not try to generate "fill" ticks/lines for the grid
We now generate a grid from the TempoMap of appropriate "density". Doing this
in the editor just gets things wrong (and partially duplicates the (complex)
logic already present in the TempoMap).
2022-11-29 10:09:39 -07:00
Paul Davis
148dfdd23c editor tempodisplay: use new TempoMap::get_grid() argument to get a finer grid 2022-11-29 10:09:39 -07:00
Paul Davis
f2a725b311 NO-OP: add some explanatory comments to Editor::snap_to_bbt() 2022-11-29 10:09:39 -07:00
Paul Davis
21c6c723c4 differentiate between StartupFSM::{Exit,Quit}Program
QuitProgram is a user choice, ExitProgram is an error condition
2022-11-29 10:09:39 -07:00
Paul Davis
c19f3f07b0 on macOS, try to fix weird language preference handling
If the user has en_XX, consider that as untranslated english EXCEPT for en_GB
2022-11-29 10:09:39 -07:00
Robin Gareus
abf92e42c0 Do not explicitly copy [whole-file] Region
Playlist::add_region copies regions as needed (see 8d045e15dc),
without forking the Source.

This fixes an issue when importing MIDI files. When
midi-copy-is-fork is enabled (enabled by default), the
RegionFactory::create call used during import forked the
region. This resulted in two Sources being created for each
imported MIDI file.
2022-11-27 13:09:52 +01:00
Gon Solo
b7aa98ee0c /float*/std::vector/ in fft_result. 2022-11-26 12:29:23 +01:00
Paul Davis
f98a14ed13 more debug output regarding macOS language preferences and translation 2022-11-23 08:08:00 -07:00