Commit Graph

16055 Commits

Author SHA1 Message Date
Robin Gareus
dcf981fe07 Remove remnants from AudioMidi Tracks
This fixes meter faceplace background color when adding
a MIDI port to an audio track.
2022-12-10 02:36:46 +01:00
Robin Gareus
b2fddeb43d Add named ranges to quick export dialog 2022-12-09 19:22:59 +01:00
Paul Davis
74f95ff0dd when use stripable palette colors, use them sequentially
Also break this code out into a separate method
2022-12-08 10:52:57 -07:00
Paul Davis
cd4b6e85a8 pick route colors from the color palette (with random variation) #9115 2022-12-07 21:27:51 -07:00
Robin Gareus
ea50799ce2 Remove duplicate implementation
`bool cocoa_open_url (const char*)` is implemented in 
libs/pbd/cocoa_open_uri.mm
2022-12-08 01:32:41 +01:00
Paul Davis
b9f9531fa1 duration clocks: fix display when mode is changed 2022-12-07 12:11:31 -07:00
Paul Davis
ad9757e73c fix nudge/duration clocks when scrolling in BBT mode 2022-12-07 11:13:49 -07:00
Paul Davis
9f85a0aaba fix behavior of duration clocks when scrolling in all modes except BBT 2022-12-07 11:13:49 -07:00
Robin Gareus
313f7ad344 Use new API to compare export format/spec 2022-12-07 17:57:56 +01:00
Robin Gareus
0abbe651ea Remove debug output 2022-12-07 00:28:21 +01:00
Paul Davis
f37687a985 various fixes for AudioClock duration/!duration confusion 2022-12-06 11:11:08 -07:00
Paul Davis
7850628f6f fix manual drawing of MIDI automation (avoid offset) #9142
Change assumption that the "pos" argument to AutomationRegionView::add_automation_event is region-relative, by
making it global.

This did not affect non-MIDI automation because that used
AutomationTimeAxisView::add_automation_view() instead.
2022-12-06 11:11:08 -07:00
Robin Gareus
32b6db092c NO-OP: whitespace and comment 2022-12-06 17:30:59 +01:00
Robin Gareus
e7b0df0231 Export Format Dialog: constrain sample-rates 2022-12-06 06:35:47 +01:00
Robin Gareus
4acc458a78 GUI support for OPUS encoding 2022-12-05 23:43:50 +01:00
Robin Gareus
8a7684bd2f Use 1|1|0 for new BBT markers, always use dialog for new markers
Amend b972301a3b
2022-12-05 19:18:26 +01:00
Robin Gareus
2bca6395cc Attempted fix for idle_drop_window random crashes (1/2) 2022-12-03 19:27:45 +01:00
Robin Gareus
b972301a3b Add action to noninteractively add BBT marker at playhead 2022-12-02 21:31:56 +01:00
Robin Gareus
d808315e2a Offer dedicated alternatives for Delete/Backspace
This follows Processor Box:
 <Binding key="Delete" action="ProcessorMenu/delete"/>
 <Binding key="BackSpace" action="ProcessorMenu/backspace"/>
2022-12-02 19:50:39 +01:00
Robin Gareus
899cacdf86 Delete/BackSpc clears selected trigger-clos 2022-12-02 19:19:20 +01:00
Robin Gareus
5d42509a21 Report error to user in startupFSM
StartupFSM does not catch SessionException from Session::load_state,
but bails out early, after checking `get_info_from_path` instead.
So we have to explicitly report errors.
2022-11-29 20:03:44 +01:00
Paul Davis
c312d570f4 move twist-tempo drag from tempo ruler to BBT ruler
Behavior remains unchanged, just the location/ruler for the start of the drag.
2022-11-29 10:09:39 -07:00
Paul Davis
cd86521c65 rulers: improve labelling of non-quarter note beats in tempo ruler 2022-11-29 10:09:39 -07:00
Paul Davis
8b06eb9878 editor rulers: do not try to generate "fill" ticks/lines for the grid
We now generate a grid from the TempoMap of appropriate "density". Doing this
in the editor just gets things wrong (and partially duplicates the (complex)
logic already present in the TempoMap).
2022-11-29 10:09:39 -07:00
Paul Davis
148dfdd23c editor tempodisplay: use new TempoMap::get_grid() argument to get a finer grid 2022-11-29 10:09:39 -07:00
Paul Davis
f2a725b311 NO-OP: add some explanatory comments to Editor::snap_to_bbt() 2022-11-29 10:09:39 -07:00
Paul Davis
21c6c723c4 differentiate between StartupFSM::{Exit,Quit}Program
QuitProgram is a user choice, ExitProgram is an error condition
2022-11-29 10:09:39 -07:00
Paul Davis
c19f3f07b0 on macOS, try to fix weird language preference handling
If the user has en_XX, consider that as untranslated english EXCEPT for en_GB
2022-11-29 10:09:39 -07:00
Robin Gareus
abf92e42c0 Do not explicitly copy [whole-file] Region
Playlist::add_region copies regions as needed (see 8d045e15dc),
without forking the Source.

This fixes an issue when importing MIDI files. When
midi-copy-is-fork is enabled (enabled by default), the
RegionFactory::create call used during import forked the
region. This resulted in two Sources being created for each
imported MIDI file.
2022-11-27 13:09:52 +01:00
Gon Solo
b7aa98ee0c /float*/std::vector/ in fft_result. 2022-11-26 12:29:23 +01:00
Paul Davis
f98a14ed13 more debug output regarding macOS language preferences and translation 2022-11-23 08:08:00 -07:00
Paul Davis
264140c191 do not label ticks generated to fill space between ::get_grid() results 2022-11-22 18:09:46 -07:00
Robin Gareus
6af9dffa7c Remove UI code to import markers as locations (3/4) 2022-11-22 01:46:22 +01:00
Robin Gareus
4e77bbdd96 dd import_markers option (2/4) 2022-11-22 01:45:42 +01:00
Paul Davis
8468607a37 be (more) professional 2022-11-19 22:25:03 -07:00
Paul Davis
d757fd5506 print XML errors to stderr not just the error stream 2022-11-19 21:30:27 -07:00
Paul Davis
fd78ea90b8 if the startupFSM detects a fatal error during startup, at least tell the user 2022-11-19 21:30:27 -07:00
Mads Kiilerich
88d4145b02 AudioClock: drop other unused stuff 2022-11-20 02:31:24 +01:00
Mads Kiilerich
6ae1f44c17 AudioClock: drop unused _edit_by_click_field 2022-11-20 02:31:24 +01:00
Mads Kiilerich
e16dd3866c AudioClock: drop unused set_mode noemit parameter 2022-11-20 02:31:24 +01:00
Mads Kiilerich
1e77814c62 MainClock: drop 'primary' parameter
The main clock no longer use direct access to the config system, and
is no longer restricted to know whether it is primary clock or not.
2022-11-20 02:31:22 +01:00
Mads Kiilerich
c805ff5fdf MainClock: introduce change_display_delta_mode signal
Avoid MainClock directly telling the config system which of the
MainClock instances was requested changed through the menu.
2022-11-20 02:29:33 +01:00
Mads Kiilerich
38d7d28b25 MainClock: introduce actual set_display_delta_mode
Make MainClock more self-contained and generic by moving logic from the
Config system and to the class itself, while making the class less aware
of how it is used in the config system.

It is slightly dirty to store the initial AudioClock widget name in
MainClock, but less dirty than having to pass the whole name correctly
every time the delta mode changes.

Also avoid confusing use of 'mode', which in AudioClock is used for the
units/formatting of the clock.
2022-11-20 02:12:40 +01:00
Mads Kiilerich
75f6b8fb66 MainClock: rename fake setter to change_display_delta_mode
We would like to introduce an actual setter, but the most appropriate
name for it was used by something else: the high level callback invoked
when selecting the menu item.
2022-11-20 02:12:40 +01:00
Mads Kiilerich
8f5b7aff3a MainClock: drop absolute_time as an alias for last_when 2022-11-20 02:12:40 +01:00
Robin Gareus
1314987f8b Towards theme-able, scale-able step-entry
* use UTF-8 music symbols for both
  - note length
  - dynamics (velocity)
This allows for both color theming as well as scaling. Previously
fixed size, black icons were used.

* directly rely on ActionManager actions for radio actions
This simplifies code and removes ambiguities.

* hide Bank/Patch buttons. Those actions are not implemented
2022-11-20 02:01:12 +01:00
Robin Gareus
05b8df6da9 Item::grab_focus was a NO-OP (see 34e7c2ffc5) 2022-11-19 22:02:21 +01:00
Paul Davis
f71996a985 fix spelling error 2022-11-19 10:22:16 -07:00
crshrprt
a23f536baf Update alert:cyan and widget:ruddy to Teal #9 2022-11-19 10:22:16 -07:00
Robin Gareus
2a9835d475 Remove cruft from diehard theme 2022-11-19 18:14:14 +01:00