Commit Graph

16764 Commits

Author SHA1 Message Date
Hector Martin
55c2c9db7e Add sanity assert in MidiBuffer::insert_event to check for overflow 2020-11-10 21:03:42 +09:00
Hector Martin
a568b3c7c2 Complain when MidiBuffer::merge_from fails due to buffer full
We were previously dropping MIDI data silently
2020-11-10 21:03:42 +09:00
Hector Martin
0979097cae Check for MIDI buffer overflow when merging into an empty buffer
This can happen if the buffers have different sizes.
This fixes crashes that bisected to 7c37a18b7, but it is not the root
cause; it just happened to make things worse.
2020-11-10 21:03:42 +09:00
Robin Gareus
f2d04dfb1f Fix VST2 default and initial control parameter values 2020-11-10 00:08:03 +01:00
Hector Martin
0e509fa09f Correctly sort concurrent MIDI events
This fixes an bug introduced in 7c37a18b7
2020-11-09 20:40:59 +01:00
Robin Gareus
bb468ee4de Update jackd.exe registry key
This ensures compatibility with upcoming jack > 1.9.16,
current jack 1.9.16, as well as older versions.
2020-11-09 20:06:49 +01:00
John Emmas
5f082e2c9d Add an extra option when querying Windows registry keys
(this option will be needed when 32-bit Ardour is running in 64-bit Windows)
2020-11-09 11:35:35 +00:00
Paul Davis
f95439a502 add spinlock to RCU manager to protect concurrent reader() and update() calls 2020-11-08 11:28:10 -07:00
Robin Gareus
01f9332458 Fix RCU Unit-test on macOS/X
Apple's pthread does not implement barriers
2020-11-07 10:37:52 +01:00
Robin Gareus
88fc0ed392 Add RCU unit test 2020-11-05 02:24:54 +01:00
Robin Gareus
62e47fb57c Add Lua binding for unit-tests to sync with process-cb 2020-11-04 19:08:59 +01:00
Robin Gareus
c87ef15e82 ALSA: configure capture settings before playback
This fixes an issue with some soundcards e.g. "AxeFx III".
Device configuration fails unless set_hwpar() is performed
for the capture device before configuring the playack
device (half duplex is fine, too).
2020-11-04 14:46:49 +01:00
Robin Gareus
b8b232cfab VST3: query latency when plugin is activated regardless of Vst::kLatencyChanged 2020-11-02 01:58:05 +01:00
Robin Gareus
8ab62937ca VST3: verbose scan option 2020-11-02 01:57:03 +01:00
Robin Gareus
35414fcef0 VST3: yet another attempt at state-retore #8460 2020-11-02 01:46:08 +01:00
Robin Gareus
66c19647df NO-OP: fix typos 2020-11-01 12:25:22 +01:00
Robin Gareus
cf0904f752 Handle vfork/exec failure
Don't call atexit, exit without cleanup.
2020-10-31 22:33:10 +01:00
Robin Gareus
a9bd7b2848 Remove unused compile-time option to not use vfork 2020-10-31 22:30:45 +01:00
Robin Gareus
edc70200c4 VST3: add generic uname -m fallback 2020-10-31 20:26:34 +01:00
Robin Gareus
7896c30508 Fix cmdline parameter escape 2020-10-31 13:42:14 +01:00
John Emmas
40ed19767a In a Windows build, support launching both older and newer versions of Jack (Stephane's + Filipe's) 2020-10-31 08:01:55 +00:00
John Emmas
5c06fdf1de In an MSVC build, modify our VC project to use weak Jack
(needed to support Jack v1.9.16)
2020-10-31 07:59:09 +00:00
Robin Gareus
f509a7e003 Extend convenience API to query windows registry 2020-10-30 13:15:06 +01:00
Robin Gareus
1219271321 Cont'd work on implicit solo restore
This is an update to b90f057e6e, allowing processors
to configure when ports change. Fixes loading old sessions with
variable i/o polarity invert.
2020-10-29 19:55:27 +01:00
Robin Gareus
b90f057e6e Fix restoring implicit solo on session load
When a route's output is connected to multiple busses, re-establishing
port-connections on session-load calls Route::output_change_handler
multiple times.

Implicit solo counts are saved and restored by the route's SoloControl,
however the output_change_handler invalidated it on session load.

Since connections are restored iteratively, counting soloed downstream
routes will yield an incorrect result until all connections are
established.

This fixes the issue that implicit solo is lost on session-reload
in case a route has multiple connections with different up/downstream
solo states.
2020-10-28 22:31:26 +01:00
Robin Gareus
7826a1a2a2 Increase plugin-scan progress display frequency 2020-10-27 22:21:49 +01:00
Robin Gareus
722294075d VST3: fix UTF-16 host message 2020-10-26 18:33:10 +01:00
Robin Gareus
b119758161 fix debug messages in prev commit 2020-10-25 20:31:50 +01:00
Robin Gareus
da1782d56e VST3: Keep preset in sync with plugin GUI
When a user loads a preset using the plugin's own GUI, update
Ardour's preset dropdown.
2020-10-25 19:50:22 +01:00
Robin Gareus
6c14e568f0 Streamline copying plugin state
Do only load (dlopen) plugin module when instantiating plugin.
Previously new instances were loaded, not used, and unloaded.
2020-10-25 13:14:02 +01:00
Len Ovens
ddcf3eb684 Generic Midi encoders fixed 2020-10-24 16:06:04 -07:00
Robin Gareus
421c52ba7d Fix bounce and freeze
* Include main-out channel-count when bouncing the output
* Do not de-activate disk-reader and mains-out when freezing a track
* Ignore meter when counting channels
2020-10-24 05:44:29 +02:00
Robin Gareus
54829492ca Fix glib/glibmm includes 2020-10-24 04:14:38 +02:00
Robin Gareus
f7cc5e1f38 Search for JACK on windows using the registry 2020-10-24 04:01:54 +02:00
Robin Gareus
32d2ea6c41 Replace static registry lookup with library method 1/2 2020-10-24 03:57:16 +02:00
Robin Gareus
8852069ead Consolidate code: add library method to query Windows registry 2020-10-24 03:56:47 +02:00
Robin Gareus
76c86ee96d VST3 path customization
Allow to add custom VST3 search to default. the VST3_PATH environment
variable is use to pre-seed this path at first start.
2020-10-24 03:36:41 +02:00
Robin Gareus
c6222caea6 VST3: Implement verbose scan option 2020-10-24 03:21:25 +02:00
Robin Gareus
2e98c57fb8 Finalize experiment: always propagate solo via sends
See also caf057f06d
2020-10-23 00:24:06 +02:00
Robin Gareus
8b6e1d78f9 Fix external/sidechain send solo propagation
Since caf057f06d sends propagate solo, however so far
only internal-sends properly cleaned up after disconnect or
removal.
2020-10-22 23:52:01 +02:00
Robin Gareus
32a0c6a3ff Drop TMM ports when closing session, or backend goes away
TMM ports cannot exist without a backend.
This fixes crashes where the PortEngine is re-initialized
(backend change):

Previously, TMM ports were only dropped (and recreated)
in TMM::restart() called from ARDOUR::init_post_engine().
When starting a new backend the old one is already destroyed,
but TM still held reference to Ports owned by that backend.
Calling the port's d'tor caused a memory corruption trying to
acquire the backend's port_callback_mutex:

e.g. When creating new session with a different backend
from a running instance, or unit-test after call to
AudioEngine::destroy(): https://pastebin.com/4D6pLA5s
2020-10-22 07:38:00 +02:00
Robin Gareus
8bc3e86066 Clean up TMM at exit 2020-10-22 07:38:00 +02:00
Robin Gareus
f3fbb96d6a Fix VST3 PSL channel-index order
While Ardour uses separate indices when naming tracks and busses
("track 1", "track 2", "bus 1", "bus 2"), the indices are contiguous
(0: "track 1", 1: "track 2", 2: "bus 1", 3: "bus 2").
2020-10-22 01:37:40 +02:00
Robin Gareus
a266a2d5b9 Use session API to set solo
This is required so that ::update_route_solo_state() is called
to propagate solo/mute state
2020-10-18 15:28:10 +02:00
Robin Gareus
72736289c8 NO-OP: rename API rename
CP selection API is now implemented as functions, not signals.
2020-10-18 14:47:05 +02:00
Robin Gareus
84bf97aa49 Update ControlProtocol API, use CoreSelection
* replace signal-emission with direct calls to CoreSelecton
  using BaseUI's session pointer
* remove unused leftmost strip API
* use CoreSelection for first-selected strip
* Accessing CoreSelection does not modify the session
  (allow access from const callbacks)
* replace static calls in P2 surface

This removes indirection and dependency on the GUI for
managing strip selection.
2020-10-18 14:44:38 +02:00
Robin Gareus
9b382fe1c5 VST3: use CoreSelection API
This implements bc78629788 properly, without relying
on libardour_cp static methods.
2020-10-18 14:36:09 +02:00
Robin Gareus
26a1d55f7a Implement _first_selected_stripable as part of CoreSelection 2020-10-18 14:29:12 +02:00
Robin Gareus
e6fe0e8cca Prepare for static CP API removal 2/2
This partially reverts bc78629788
2020-10-18 14:28:45 +02:00
Edgar Aichinger
1f7e4ee76a update german translation 2020-10-17 18:21:30 +02:00