Commit Graph

31223 Commits

Author SHA1 Message Date
Robin Gareus
78f749ef65 Don't show DSP stats of inserts that don't collect them. 2018-12-03 22:43:13 +01:00
Robin Gareus
d1cf21634f Special case Mixbus Chanstrip for load calculation
These processors don't have a UI, so their load stats are not easily
visible. The stats can still be queried via Lua API or DSP-load
overview window, so we retain this for debug builds.
2018-12-03 22:43:02 +01:00
Robin Gareus
b285559767 Consistent AU factory Preset IDs
Use AU's preset->presetNumber as identifier since std::map are sorted
this also indirectly sorts presets by preset-number. (user presets
start with a '/' and are listed first, sorted by name).

Since Presets are now identified by URI on session load (53a0199a0)
and AU user-presets can added/be removed (since ae4604a24b), simple
sequential numbering is no longer an option.
2018-12-03 20:45:06 +01:00
Robin Gareus
6877ac820b Don't invalidate AU preset on load
This works around async parameter-changed signal emission when loading
an AU preset. A simple timeout is used to delay making the preset
as modified.
2018-12-02 02:04:21 +01:00
Robin Gareus
c8d08338df GUI Updates for plugin save/delete operations 2018-12-02 01:38:14 +01:00
Robin Gareus
ae4604a24b Implement AU plugin-preset removal 2018-12-02 01:37:33 +01:00
Robin Gareus
53a0199a06 Restore actual plugin-preset on session-load
This checks if the preset is actually available on the given system
and also sets the user-flag correctly.
2018-12-02 01:36:32 +01:00
Robin Gareus
3c7dea43af Towards fixing AU preset invalidation
This is a step in the right direction: first load the preset and
only if preset-loading was successful mark it as loaded.

This still does not properly unset "parameter_changed_since_last_preset".
AU signals "kAudioUnitEvent_ParameterValueChange" later in the event-loop.
2018-12-02 00:26:57 +01:00
Robin Gareus
d53af10c92 AU: mark preset dirty when parameter changes 2018-12-01 05:36:33 +01:00
Robin Gareus
b66726fdc1 Fix AU preset handling
load_property_list() takes a file-path (not URI). Actually it's not
clear why we've ever used a `file:///` URI internally.
2018-12-01 05:33:26 +01:00
Robin Gareus
0ce0c47697 Night of the typos III (amend prev 2 commits) 2018-12-01 03:22:04 +01:00
Robin Gareus
c921a67123 Also use xjadeo 64bit windows version 2018-12-01 03:13:59 +01:00
Robin Gareus
6e0487fc1f Harvid and xjadeo now feature 32/64bit window version(s) 2018-12-01 00:56:20 +01:00
Robin Gareus
3a0a2902b5 Freeze harvid/xjadeo PPC version 2018-11-30 18:10:35 +01:00
Paul Davis
7801888810 fix incorrect accumulation of export video options each time the dialog is used 2018-11-29 17:43:17 -05:00
Robin Gareus
f443626daa Fix a tiny memory leak, add_instant_xml() copies the node 2018-11-29 14:25:52 +01:00
Robin Gareus
e42699600b Delete temporary Window Proxy for dialogs
There are two cases:
 (A) Proxy is created first, dialog is created later on demand
 (B) Dialog is created and directly registers its window as proxy

In (B) the dialog is usually on the stack and destroyed when the
ArdourDialog instances leaves scope. In that case ~ArdourDialog()
is called and the proxy remained.

Destroying the proxy does destroy the registered window in ~WindowProxy()
If ArdourDialog's d'tor itself deletes the proxy it would recurse into
itself. Existing APIs e.g. drop_window() likewise delete the window and
cannot be safely called from ~ArdourDialog.
2018-11-29 14:25:22 +01:00
Robin Gareus
fc24b9f0b7 Fix uninitialized variable 2018-11-29 02:10:08 +01:00
Robin Gareus
a22a501537 NO-OP: whitespace 2018-11-29 02:07:29 +01:00
Robin Gareus
1759d1c9c9 Fix a tiny memory-leak when calling vfork 2018-11-29 02:06:42 +01:00
Robin Gareus
6fc2804414 Disk I/O: only allocate midi-buffer if needed
This fixes a memory-leak (_midi_buf was allocated in DiskIOProc
but only delete in DiskReader). Also skip midi-refill early on
2018-11-29 02:05:26 +01:00
Robin Gareus
dfbda9e0f6 Fix a potential memory-corruption
Disk-writer run() can concurrently use the ringbuffer after it was
free()ed by the butler thread.
2018-11-28 21:41:30 +01:00
Robin Gareus
076e9fddd4 Remove ambiguous API implementation
* PortEngine::available() implementation
* AudioEngine::connected() wrapper

Eventually we may re-introduce PortEngine::available along
with a libardour internal port-engine.
2018-11-28 15:32:40 +01:00
Robin Gareus
81857a947c Consolidate ambiguous engine API calls
available(), connected(), running() were ill-defined and
used interchangeably.
2018-11-28 15:24:47 +01:00
Robin Gareus
df28a71252 Consolidate API, prefer ->running() 2018-11-28 15:19:39 +01:00
Robin Gareus
0805b6b925 Consolidate two more engine-checks 2018-11-28 15:17:57 +01:00
Robin Gareus
245d48dbd0 NO-OP: Clarify function name 2018-11-28 15:16:25 +01:00
Robin Gareus
76f9764a44 Use central method to check for engine for processor operations 2018-11-28 00:02:57 +01:00
Robin Gareus
f150f6c074 Use central method to check for engine where required
These are generally places where tracks/busses are created or port
connections change.
2018-11-28 00:01:50 +01:00
Robin Gareus
415721fa5b Prepare central engine check and user notification 2018-11-27 23:57:53 +01:00
Robin Gareus
1d8dc009f7 Catch potential exceptions when adding tracks/busses 2018-11-27 13:19:34 +01:00
Robin Gareus
57d7b5de65 GUI limitation: Require engine to add/remove tracks/busses 2018-11-27 13:18:39 +01:00
Robin Gareus
5531a440c9 Fix stuck connection block when template load fails.
Session::new_route_from_template() unconditionally calls
IO::disable_connecting(), and needs to be reverted likewise
(no RAII here).
2018-11-26 21:45:06 +01:00
Robin Gareus
dce81aecc5 Prevent deadlock when removing routes w/o engine 2018-11-26 03:31:02 +01:00
Robin Gareus
ae2a6175cc Don't allow to add/remove monitor-section w/o engine
Adding/removing the Monitor section changes port-connections,
a port-engine is needed to establish connections.

Ideally we'd allow this and queue for connection changes. This
will however require deep changes.

Also toggling the monitor-section on/off/on w/o engine can later
result in failure to register ports. Due to lack of engine-signals
not all shared_ptr<> port references are dropped.
2018-11-26 03:15:14 +01:00
Robin Gareus
13c984c216 Fix various issues when the engine disconnects:
Previously Port::PortDrop was never handled.
The signal was disconnected directly when the connection
is re-used by Port::PortSignalDrop.

Ports::drop() was not called when the engine was stopped
or disconnected, and port-handles were not invalidated.

This lead to crashes whenever a port-related operation was performed
while the engine was stopped. e.g. adding/removing tracks or plugins
(latency recompute, notify port-engine) and various other operations.
2018-11-26 02:39:55 +01:00
Robin Gareus
4bbfb6ce50 Fix a double-free, introduced in b06713bd8e
~OptionEditor() already frees all components on every page.
2018-11-26 00:32:29 +01:00
Robin Gareus
cf98a75558 Do not allocate MIDI buffers for signal analysis
At this point in time MIDI buffers are vastly over-sized.
They include VST and LV2 event structure. This added about a MB per
plugin for no benefit.
2018-11-25 17:43:15 +01:00
Robin Gareus
5273c636ab Fix Linux/PPC64 runtime
This fixes an error while loading shared libraries: libardour.so

  R_PPC64_ADDR32 reloc at 0x... for symbol `' out of range

Treating a local as an immediate value in asm code makes the library
non-relocatable.
2018-11-25 16:57:51 +01:00
Robin Gareus
3fd8dad9d6 Allow compilation with winpthreads -- closes #7691 2018-11-25 16:51:24 +01:00
Robin Gareus
bdc82f68e6 Bundle x42-limiter with binaries 2018-11-25 16:40:28 +01:00
Robin Gareus
01e0472481 Auditioner: check if removing synth succeeds
remove_processor() also calls drop_references, when successful.
2018-11-24 02:01:16 +01:00
Robin Gareus
948c5d0706 Handle some midnam edge-cases
Whitespace between XML nodes can result in "text" children.
Those need to be skipped in the patch-name list.
2018-11-23 22:43:26 +01:00
Robin Gareus
771ddcc86f NO-OP: whitespace and re-organization 2018-11-23 22:09:13 +01:00
Robin Gareus
2e3e183204 Load audition synth on demand
This saves some memory (gmsynth loads a 30MB soundfont), and also
re-initializes the synth every time to gm defaults in case some
.mid changes patches or parameters.
2018-11-23 22:00:04 +01:00
Robin Gareus
8c4c97d1e2 Update Fluidsynth to v2.0.2 2018-11-23 16:05:19 +01:00
John Emmas
f28b03c305 Add/remove source(s) in our MSVC project (gtk2_ardour) 2018-11-23 07:28:17 +00:00
John Emmas
afee22d5fa Add/remove source(s) in our MSVC project (audiographer) 2018-11-23 07:27:32 +00:00
John Emmas
b7317eb1b3 Add/remove source(s) in our MSVC project (libardour) 2018-11-23 07:25:54 +00:00
Robin Gareus
04fe6d6fb4 Amend prev. commit, actually remove (1.0 - x) as was documented 2018-11-22 21:05:03 +01:00