Commit Graph

38788 Commits

Author SHA1 Message Date
Ben Loftis
3f14b27ee3 remove (unimplemnted) Stretch MIDI checkbox 2023-09-07 15:18:36 -05:00
Robin Gareus
e88a121ff8 Fix canvas rectangle bounding box
When drawing the outline of a rectangle, the bounding
box must cover the whole pixel of the line. Otherwise
the line would be left behind when the rectangle shrinks.
2023-09-07 02:45:26 +02:00
Robin Gareus
cc47b5fe3c Only allow grid-tool with musical grid 2023-09-06 23:56:10 +02:00
Paul Davis
966dce5516 remove now-invalid tempo edit menu items 2023-09-06 15:29:55 -06:00
Paul Davis
aaadc3906c triggerbox: fix crashing bug while processing clips in rubberband
The read_index is adjusted in the loop, which means that the calculation of how much
data can be delivered to the stretcher must also be inside the loop
2023-09-06 14:46:24 -06:00
Paul Davis
58b667c6c0 temporal: fix crash caused by unsafe use of tempo map iterators 2023-09-06 14:46:24 -06:00
Paul Davis
3675f8f444 launchpad pro: remove debug output 2023-09-06 14:46:24 -06:00
Paul Davis
6d9c47c920 launchpad pro: only light Sends button if the selected stripable has 1+ sends 2023-09-06 14:46:24 -06:00
Paul Davis
1ec966d964 launchpad pro: allow clear+cue buttons to ... clear a cue 2023-09-06 14:46:24 -06:00
Paul Davis
68678aa957 triggerbox: add API to clear a cue (row) 2023-09-06 14:46:24 -06:00
Ben Loftis
da4d2a645f remove tempo-mapping bar, tempo_meta group. this reverts 8fbf2c and related 2023-09-06 19:31:00 +02:00
Ben Loftis
784d2ecce4 Add the tool for Grid, and accompanying buttons and event-handling 2023-09-06 19:30:56 +02:00
Ben Loftis
268d1d33c7 Add invisible Rectangle to initiates Tempo(grid) drags 2023-09-06 19:14:14 +02:00
Robin Gareus
f339236c5b Add icon for the Grid tool 2023-09-06 19:13:59 +02:00
Robin Gareus
80a813ff1c Fix use-after-free when undoing marker creation
Create a marker by ctrl-click, hover over it and then ctrl+z
undo. This used to crash in Editor::get_preferred_edit_position()
gtk2_ardour/editor.cc:5179, checking for entered_marker->position()
2023-09-06 17:37:11 +02:00
Robin Gareus
c2ce0bcb4a Amend 101744b8, allow when and start to point to the same variable 2023-09-06 01:01:30 +02:00
Robin Gareus
3851a93e39 Update selection-markers on track and time selection 2023-09-06 00:02:36 +02:00
Robin Gareus
10ff5ad599 Use section delete for Editor::Delete operation 2023-09-06 00:02:31 +02:00
Ben Loftis
6e87a46ba4 convention for selection (as used on track headers) is red border, red tint 2023-09-05 23:08:30 +02:00
Robin Gareus
29430ac550 NO-OP: clang-format 2023-09-05 23:08:30 +02:00
Robin Gareus
68ccbc8ac3 Arrangement: locate on double-click 2023-09-05 23:08:30 +02:00
Ben Loftis
e5e40c751f if user moves selection markers, convert selection to a timeline section 2023-09-05 23:08:30 +02:00
Ben Loftis
4217a68852 Arranger: implement bi-directional selection 2023-09-05 23:08:30 +02:00
Ben Loftis
5ceb66c902 Arranger: allow renaming by context-menu 2023-09-05 23:08:29 +02:00
Ben Loftis
101744b812 Add method to find a section location by position 2023-09-05 23:08:29 +02:00
Robin Gareus
5c888f2b90 Fix deadlock when cut/pasting section to itself 2023-09-05 23:08:29 +02:00
Paul Davis
5223d05854 launchpad pro: various improvements and fixes 2023-09-04 19:41:25 -06:00
Paul Davis
269699c340 temporal: fix get_grid() to work in the presence of "weird" BBT markers 2023-09-04 19:41:25 -06:00
Paul Davis
13bdfda81a temporal: add Meter::round_up_to_beat_div()
reimplement round_up_to_beat() in terms of round_up_to_beat_div()
2023-09-04 19:41:25 -06:00
Paul Davis
f1f5df7c9a temporal: add BBT_Time::round_up_to_beat_div() 2023-09-04 19:41:25 -06:00
Paul Davis
7c5e7ddf59 temporal: improve operator<<() for MusicTimePoint (BBT markers) 2023-09-04 19:41:25 -06:00
Robin Gareus
cf9f9db48b Set length of new percussive hits to 1 tick
This prevents overlap of successive hits.

Ardour 7 added a new duration select drop-down menu,
which defaults to "Auto" (musical grid) and removed
the special case when drawing percussive notes.
It was possible to accidentally create overlapping notes,
without the user being aware of doing so.
2023-09-04 23:26:54 +02:00
Ben Loftis
7d95334c0d fix thinko in e53a7 which resulted in unmatched tempo-map UNDO transactions 2023-09-04 08:48:49 -05:00
Robin Gareus
774adfb33c Fix rounding of arrangement markers 2023-09-01 21:53:26 +02:00
Ben Loftis
a6844279ad arranger-treeview 'search' function was stealing keybd events 2023-09-01 07:18:22 -05:00
Paul Davis
0d89bc5789 fix height of tempo ruler curve elements
These were being drawn in a way that failed to really convey relative
tempos very well. This is now better, though perhaps there are other
improvements possible
2023-08-31 18:25:18 -06:00
Paul Davis
0266d98a3b temporal: add TempoMap::{max,min}_notes_per_minute() API 2023-08-31 18:23:40 -06:00
Paul Davis
cda0d6ce9f temporal: fix totally broken implementation of TempoMap::shift (timepos...) 2023-08-31 18:22:59 -06:00
Paul Davis
c778a6df67 ripple backwards when cutting a section 2023-08-31 18:22:25 -06:00
Paul Davis
69cfe9d3f9 add missing ripple during cut/copy/paste of sections 2023-08-31 18:21:56 -06:00
Paul Davis
da9140a390 polish the way we print tempo numerics in tempo ruler 2023-08-31 10:34:48 -06:00
Paul Davis
43d6d4187c display tempo with only 1 digit of decimals 2023-08-31 10:34:48 -06:00
Paul Davis
4969fb9e0b libpbd: tweak for printing pthread ID (windows is int/*nix is ptr) 2023-08-31 10:34:48 -06:00
Robin Gareus
b5b4be96e3 Use "Arrangement" in GUI instead of Section (amend 2f6a0abf) 2023-08-31 16:12:50 +02:00
Robin Gareus
1bc795509b Use "Arrangement" in GUI instead of Section (amend 2f6a0abf) 2023-08-31 05:29:29 +02:00
Robin Gareus
b162ffbca8 Clear Arrangement rects when closing a session 2023-08-31 00:58:51 +02:00
Paul Davis
c4cb8dbda9 arithmetic simplification 2023-08-30 16:07:48 -06:00
Paul Davis
864b660abe lppro: working send faders, some work on color & pulse for select buttons 2023-08-30 16:06:14 -06:00
Paul Davis
e664acc16e lppro: working pan fader controls 2023-08-30 16:06:14 -06:00
Paul Davis
75802cc47b lppro: momentary mode for all fader layouts 2023-08-30 16:06:14 -06:00