Commit Graph

13089 Commits

Author SHA1 Message Date
Paul Davis
9d60197ffb remove unnecessary code
If there's no GUI property for the MIDNAM model name, and the plugin has no MIDNAM, there's no reason to set the property to the default

It will pick up the default ("Generic") during update_patch_selector() calling into model_changed
2020-02-11 14:16:47 -07:00
Paul Davis
ca28404a2a NOOP: line unwrapping and vertical spacing 2020-02-11 13:59:05 -07:00
Paul Davis
de74cca6b8 further attempts to rationalize MIDNAM mess
Attempt to re-use GUI property for MIDNAM device mode, and if it doesn't exist, use the first from the model's device mode list.

Also require at least one device mode in the MIDNAM file (via assert) - consider anything else to be malformed
2020-02-11 13:41:44 -07:00
Damien Zammit
beaa6a7ae4 pt_import: Bump thread pool constant from 64 to 2048 to prevent import crash 2020-02-09 17:55:48 +11:00
Paul Davis
d5c1ad805d NOOP: add whitespace/blank line 2020-02-07 12:20:11 -07:00
Paul Davis
46277acb40 Fix incorrect assignment of MIDNAM device mode 2020-02-07 12:20:11 -07:00
Paul Davis
e93150cb3f NOOP: remove line wrapping 2020-02-07 12:20:11 -07:00
Paul Davis
8242478da5 try to fix awful confusion and misbehavior for plugin-provided MIDNAM situations
We do not store the MIDNAM model as a GUIObject property if the using the plugin-provided MIDNAM. Selecting a different MIDNAM for
the plugin should now result in that choice being saved/restored correctly.

This all feels crazily complicated, but I don't want to change more of the architecture at this time
2020-02-06 14:43:58 -07:00
Paul Davis
55d158816e NOOP: avoid unnecessary and distracting line wrapping 2020-02-06 14:43:58 -07:00
Paul Davis
39e0c0a084 add AxisView::remove_gui_property() 2020-02-06 14:43:58 -07:00
Paul Davis
c791d5970f add GUIObjectState::remove_property() 2020-02-06 14:43:58 -07:00
Nikolaus Gullotta
a13fabf344 Resize session dialog back to initial height and width on "back"
This fixes an issue where the size of the window stayed much larger
than its content if there are no sessions in the session search path
after attempting to make a new session and then pressing "back"
2020-02-06 14:45:09 -06:00
Paul Davis
ee43db8b54 revert/change part of a666429d12 so that user-selected non-plugin MIDNAM model names are still shown (they were already used) 2020-02-05 12:53:15 -07:00
Paul Davis
be45193f3f fix old bug from 2007 (bbf4175713) in which a return statement was accidentally (presumably) dropped 2020-02-05 12:53:15 -07:00
Robin Gareus
44e55c501e Add some const'ness 2020-01-30 23:35:37 +01:00
Robin Gareus
d72b44b5a4 Fix scripted/meta session templates 2020-01-30 18:09:01 +01:00
Andreas Müller
015d4d3642 Find fmt-binding in out-of-tree building
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
2020-01-29 19:41:12 +01:00
Robin Gareus
eb7297e2fc Remove duplicate separators from context menu 2020-01-28 23:38:02 +01:00
Robin Gareus
b21bab3a8c Don't allow to deactivate master 2020-01-28 23:37:10 +01:00
Robin Gareus
6dfee0b1d2 Amend 87af9fb (fix context menu, don't allow to remove master) 2020-01-28 23:17:21 +01:00
Robin Gareus
a430f65aa3 Initialize monitor-section output button
When loading a session the monitor-connection is made before
the GUI is initialized, the output button did not reflect
the actual connection.
2020-01-28 22:58:14 +01:00
Robin Gareus
87af9fb820 Consolidate Mixer-strip sensitivity
* Use a single method to set mixer-strip widget sensitivity
* Update context-menu to only allow show actions that can
  currently be performed, depending on active/inactive state.
* Mark all control elements of in-active strips as insenstive
  except those required to re-enable the route.
* Also update processor-box and solo-button when showing Aux

Special case Mixbus. Mixbus already shows a "Insensitive" label,
and Mixbus-channelstrip element sensitivity remains to be
implemented before using this mechanism.
2020-01-28 22:22:57 +01:00
Robin Gareus
b2051d98fd Clarify pending-state message
Previously this dialog was mainly used for crashes during
recording. Now it is also used for backup saves in general.
2020-01-28 17:29:36 +01:00
Paul Davis
e6ce5a611c shortest note length after a drag-trim is 1 tick, not 1/512 beats 2020-01-28 00:06:12 -07:00
Paul Davis
fd62b38f8d correct computation of new note length after a front-drag-trim 2020-01-28 00:05:44 -07:00
Paul Davis
10978a2f58 rearrange MIDI preferences "tab" to include ports and remove Buffering 2020-01-28 00:05:05 -07:00
Paul Davis
4148d2cee4 fix bad re-ordering in ARDOUR_UI::set_session() that changed when transport-related actions are set sensitive (compared to v5)
This specific change has broader scope than the bare minimum required - we could just move/replicate transport_ctrl.set_session()
after session_sensitive_actions have had their sensitivity set to true. But this "seems" like a more thorough solution,
in that it sets all relevant actions groups before doing anythng else.
2020-01-27 18:24:30 -07:00
Robin Gareus
7e899b4199 Restore engine state for auto-start 2020-01-27 22:27:29 +01:00
Robin Gareus
6aac8b2c8a Fix another clang-scan warning 2020-01-27 03:32:18 +01:00
Ben Loftis
cf4d7387d2 Use a sensible min length for default session-duration
If the user tries to set the Start or End marker on an empty session,
apply some sensible defaults for the resulting session range.
2020-01-26 19:36:23 +01:00
Paul Davis
cbfbe65128 disconnect from audio/MIDI setup dialog signal response when done with it 2020-01-25 10:27:46 -07:00
David Runge
2e9ac80e99 Towards waf python 2+3 support 2020-01-25 04:07:37 +01:00
Robin Gareus
dfe712c564 Consistent GTK Look/Feel
gtk/gtksettings.c uses different default themes for
Window and Linux/Mac which results in subtle layout differences,
In particular TreeView headers and Tabs.

"MS-Windows" style is hardcoded in gtk msw_rc_style.c
and ardour's clearlooks.rc starts with different defaults.

This forces the default style to a non-existent one.
(might also help with https://tracker.ardour.org/view.php?id=5605)
2020-01-25 03:56:10 +01:00
Robin Gareus
7c2ec72495 Revert "add styling specifics for TreeViews so that checkboxes are properly visible"
This reverts commit 82cf46d781.
2020-01-25 03:40:04 +01:00
Paul Davis
70588baeac handle engine failure between audio/MIDI setup and end of plugin scan 2020-01-24 15:56:37 -07:00
Paul Davis
13ecf633a3 after handling the first click on the audio/MIDI setup, mark it insensitive to prevent subsequent (dbl) clicks changing engine state 2020-01-24 15:56:37 -07:00
Paul Davis
a416829379 make audio/MIDI setup dialog use ArdourDialog::_sensitive 2020-01-24 15:56:37 -07:00
Paul Davis
f2ee30c0ec add ArdourDialog::set_ui_sensitive() to provide a way to mark an arbitrary ArdourDialog as "should not respond to user input" 2020-01-24 15:56:37 -07:00
Ben Loftis
9ee8b3f176 theme-ing: fix tooltip and knob surround colors on caineville,clear-gray themes 2020-01-24 15:56:55 -06:00
Ben Loftis
11d4d3455f theme-ing: replace missing feedback button color 2020-01-24 15:42:15 -06:00
Ben Loftis
639d9cc0bc theme-ing: fix generic-ui knob color, and remove knob surround gradients 2020-01-24 15:35:10 -06:00
Robin Gareus
cbbbf76934 Fix Eno discography 2020-01-24 21:15:57 +01:00
Robin Gareus
201d7cb2fd Backport Mixbus change (offer gap as preference)
Mixbus defaults this to on (4px), Ardour to off (0px)
2020-01-24 01:42:05 +01:00
Ben Loftis
6f4f28928d Export Dialog: catch major changes, and mark the session dirty. Otherwise changes can be silently lost. 2020-01-23 17:16:41 -06:00
Paul Davis
215d5d556f handle possible failure of a region rename 2020-01-23 14:25:38 -07:00
Paul Davis
24f8a90278 use a better "legalize for path" method when exporting
The goal is to be compatible with filesystems everywhere
2020-01-23 14:25:38 -07:00
Ben Loftis
c8faadee4b Fit Selection (Vertical): if we cant fit all selected tracks, report that to the user. But still fit what we can. 2020-01-23 14:11:18 -06:00
Ben Loftis
142ce953da Split Select-All-Tracks into 2 appropriately named actions
Existing function select-all-tracks is now renamed select-all-visible-lanes, to match its behavior.

New function select-all-tracks will select all Tracks, as the name implies.

To maintain consistency for those users who actively used select-all-tracks,
  the default shortcut ctrl+t  will continue calling select-all-visible-lanes.
2020-01-22 10:33:15 -06:00
Robin Gareus
81c3bf175a Keep track/bus number visible when disabling track 2020-01-22 01:45:18 +01:00
Robin Gareus
6914671736 Propagate ::route_active_changed() methods 2020-01-22 01:35:18 +01:00