Commit Graph

5945 Commits

Author SHA1 Message Date
Paul Davis
4dc63966f0 globally remove all trailing whitespace from ardour code base.
Paul Davis was responsible for introducing almost all of this.
2015-10-04 14:51:05 -04:00
Paul Davis
297e80e020 attempt to stop transport, finish butler work, and close all files as part of Session > Cleanup 2015-10-04 14:18:04 -04:00
Paul Davis
e63de172d5 NOOP: delete trailing whitespace 2015-10-04 14:18:04 -04:00
Robin Gareus
b3ace2e4c8 namespace fix. 2015-10-04 18:43:44 +02:00
Robin Gareus
2fbed9e41f replace std::ifstream with g_fopen for portability 2015-10-04 18:23:21 +02:00
Robin Gareus
ac814da4be correct error message 2015-10-04 17:53:02 +02:00
John Emmas
c68736bc02 Change a few instances of 'stat()' to use 'g_stat()' (for UTF8 compatibility on Windows) 2015-10-04 14:18:54 +01:00
Damien Zammit
7d2dd9db0c Click: Normalized then dropped by 6dB
Applied gain to both emph click and default click using sox.
This results in louder click sound by default and user is
able to boost click to 0dBFS using the fader on the pref pane.

Signed-off-by: Damien Zammit <damien@zamaudio.com>
2015-10-03 13:14:25 -04:00
Paul Davis
29c484cd95 NOOP: reformat indentation 2015-10-03 13:13:58 -04:00
Robin Gareus
6357770588 additional check for DSP falloff. 2015-10-03 17:46:55 +02:00
Robin Gareus
20038fedf4 less verbose unit-tests 2015-10-03 17:46:39 +02:00
Robin Gareus
01105dc971 DSP load fall-off from 100%.
get_dsp_load_unbound() will return large values >100% for testing, 
but actual fall-off is from 100%.
2015-10-03 17:46:19 +02:00
Robin Gareus
9fc3883cbb fix float calc:
divide large number. not multiply a small.
2015-10-03 17:44:56 +02:00
Paul Davis
3bc7f863ca explicitly drop control surface protocols before disconnecting from engine.
This is not bomb/thread proof yet, because it still requires at least one process callback to function
2015-10-02 22:08:14 -04:00
Paul Davis
136b659f1c remove debug output 2015-10-02 22:08:14 -04:00
Paul Davis
64b4877ef6 the return of the 1 second fade out at session close 2015-10-02 22:08:14 -04:00
Robin Gareus
a05e48dab0 fix unbound DSP calc. 2015-10-02 22:28:03 +02:00
Robin Gareus
798c235d4d define more backend error-messages. 2015-10-02 17:49:31 +02:00
Robin Gareus
4a31b03761 re-apply roll-delay after seek - fixes #5781 2015-10-01 23:17:01 +02:00
Tim Mayberry
d85ab8af89 Reinterpret the return value of AudioBackend::start as AudioBackend::ErrorCode
This will allow backends to return a more meaningful error message. Eventually
an error code could be returned by AudioEngine::start and the GUI can then use
AudioBackend::get_error_string to convert the error into a translated error
message directly, or it may be desirable to define its own error messages.

The reasons for not doing that right now is that this is a workable solution
with the least change required.
2015-10-01 09:10:19 +10:00
Tim Mayberry
9a7f96f15a Add a couple of error codes to AudioBackend::ErrorCode
Also use the error message from ARDOUR_UI::reconnect_to_engine as the default
error string
2015-10-01 09:10:19 +10:00
Paul Davis
71343e835a change the logic for a capture buffer flush to disk when a locate is occuring
We can't check for Session::actively_recording() because punch out may have disabled that. Rather
than add logic to check if a flush is needed (which is not much different than the code that runs
as part of the flush to disk), just do a flush anyway.
2015-09-30 13:02:58 -04:00
Paul Davis
7ff47ab80e tweak some debug output 2015-09-30 13:02:58 -04:00
Paul Davis
343bc5160b remove apparently bogus adjustment to capture_captured in AudioDiskstream::transport_looped 2015-09-30 13:02:58 -04:00
Paul Davis
2cf779fd0c split Butler::flush_tracks_to_disk() into two distinct versions with clear names and make one of them private 2015-09-30 13:02:58 -04:00
Len Ovens
239da0efb5 Fix Mackie control metering (fixes #6608). 2015-09-28 20:13:15 -07:00
Robin Gareus
b8ccf8accc BWF USID according to EBU-R99 2015-09-29 01:20:30 +02:00
Paul Davis
1536228d00 fix initialization of reserved I/O names vector 2015-09-28 17:52:27 -04:00
Paul Davis
34f088576c get loop recording working when using seam-ed looping 2015-09-28 17:42:11 -04:00
Paul Davis
0613ddd1f9 better more reliable checks on renamed, newly created and imported track/bus names 2015-09-28 17:42:11 -04:00
Paul Davis
9f8fe4b0bc change semantics of 4th argument to Session::locate to mean "this locate is connected with play-loop just being enabled" 2015-09-28 17:42:11 -04:00
Paul Davis
b9611a3168 a few new DEBUG_TRACE calls related to session transport state 2015-09-28 17:42:11 -04:00
Paul Davis
9202bc162a minor fix for possible off-by-one logic when at/near the end of the loop range 2015-09-28 17:42:11 -04:00
Paul Davis
f24fef669a fix a long-standing bug arising from a change to some logic which reversed an "is-rolling" test 2015-09-28 17:42:11 -04:00
Paul Davis
c9b991ba50 move code location where loop playback is cancelled when stopping 2015-09-28 17:42:11 -04:00
Paul Davis
f2aa681974 loop record is a feature whether or not loop-is-mode is true or not 2015-09-28 17:42:11 -04:00
Paul Davis
3e23b5903e Session::disable_record() should work whether we are in loop mode or not 2015-09-28 17:42:11 -04:00
Robin Gareus
dd89363292 remove cruft. 2015-09-28 00:36:44 +02:00
Robin Gareus
e65903a49a Sort ports in state-save.
This results in identical XML if the session did not change, allowing
to keep track of state-changes easily (e.g. session file in git).

Thanks to deva (again).
2015-09-27 16:10:10 +02:00
Robin Gareus
ed2ce36735 LV2 state cleanup, patch from deva. closes #6607
set _impl->state on session load in order to detect state changes
properly (no not save duplicate states).

+ some small mem-leaks (free state)
2015-09-27 14:07:57 +02:00
Robin Gareus
26fdf99a92 copy LV2 options to heap.
Stack pointer becomes invalid when the array goes out of scope.
Fixes rare crash in suil_wrapper_new() or GUIs iterating over options.
2015-09-25 19:44:30 +02:00
John Emmas
402c69c0fd Add some newly introduced sources to our MSVC project (libardour) 2015-09-24 09:05:38 +01:00
Robin Gareus
fedec84d3b fix iterator after map::erase().
The iterator referring to the removed element is invalidated.
Other iterators remain valid.
2015-09-23 22:26:44 +02:00
Robin Gareus
ccf558f482 standardize VST Callback debug message print 2015-09-22 21:02:27 +02:00
Robin Gareus
30713adb16 add debug flags for VST Callbacks 2015-09-22 20:37:35 +02:00
Robin Gareus
621e9992a7 amend 01403dc (VST Pin connected) 2015-09-21 23:01:59 +02:00
Todd Naugle
233c144c2c Update RouteGroup property defaults.
This is part of a larger fix for #6450. Previously new route groups were
created with different default properties depending on which code created
the new group. The group tab method had all properties set and that is now
going to be the default.
2015-09-21 14:49:31 -05:00
Robin Gareus
cba31db6fe processor-box: explicitly check for "Amp" (Fader) 2015-09-21 13:14:29 +02:00
Robin Gareus
77ee3d18a6 add includes for g_open() 2015-09-21 11:06:34 +02:00
Ben Loftis
df0544c4e6 fix vst plugin; not sure if this was the intention, but it builds now. 2015-09-21 10:10:07 +02:00