Commit Graph

17180 Commits

Author SHA1 Message Date
Paul Davis
53ddd200e7 fix crashes related to loop/punch ruler no longer existing 2024-05-25 06:07:57 -06:00
Paul Davis
13db3f64de minor cleanups to timecode metric generation code
Mostly this is to make sure that we never include marks earlier than @param lower.
The sample->timecode conversion common to all rule scales is now moved outside
of the switch block, and an unnecessary floor() call was removed.
2024-05-24 11:04:35 -06:00
Paul Davis
871bd5e55b force timecode mark module to 1, to avoid missing marks
The entire modulo concept for ruler marks has become mostly redundant now that
the rulers will only show text for a tick if there enough space
2024-05-24 11:04:23 -06:00
Robin Gareus
5f17d1b399 Shrink Engine Dialog when hiding the advanced section 2024-05-23 21:28:31 +02:00
Paul Davis
08eb25ef55 add a move threshold to track DnD 2024-05-21 11:05:37 -06:00
Robin Gareus
0929faf830 Use alphabet instead of numbers for new group names 2024-05-21 18:21:47 +02:00
Paul Davis
2d5884ccb1 refactor methods to add a location/section marker so that there is only one method for this 2024-05-21 08:21:02 -06:00
Ben Loftis
d3c2faa23b Tweak ruler vsibility menus so it is clearer that they are filters 2024-05-20 16:11:21 -05:00
Ben Loftis
78f81b2074 Reorganize Ruler Menu
* markers on top, rulers below
* cue markers in a submenu, and include the Stop marker
2024-05-20 15:59:34 -05:00
Ben Loftis
64c201791c Fix copy+paste error in marker args 2024-05-20 15:58:34 -05:00
Robin Gareus
5fdc7c4601 Redraw section markers when reloading session
This fixes a bug that when re-loading a session, section
marker rectangles (to next marker) were not drawn.
2024-05-20 21:55:54 +02:00
Robin Gareus
f693c0406a When drawing a note, only play it once
Previously two identical Note on events were sent:
 * Select newly created note -> note-on event
 * Play newly created note -> note-on event
2024-05-20 19:42:29 +02:00
Robin Gareus
9de2b3435d Only send a single note-off when drawing notes
Previously both the timer-based `off` as well as the d'tor
sent a note-off event.
2024-05-20 19:31:34 +02:00
Paul Davis
ac779b38b2 arrangement markers are named "section N" by default 2024-05-20 11:00:50 -06:00
Robin Gareus
66d36999b9 Remove empty checkboxes from Ruler dialog 2024-05-19 18:43:45 +02:00
Robin Gareus
897610a047 Fix macOS builds (after 93e1e1c1f2) 2024-05-19 01:04:42 +02:00
Paul Davis
f1e7ab08c7 no need to lookup smart mode action, it is cached 2024-05-18 12:24:23 -06:00
Paul Davis
6ed9835677 emove some sneakily hidden indirect references to no-longer existing rulers 2024-05-18 07:20:14 -06:00
Robin Gareus
6fbf2f37d9 Set meter-height depending on configured fader-length
Previously when len was zero, FastMeter enforced a length
of at least 250px.
2024-05-18 01:44:28 +02:00
Paul Davis
907cf66a63 restructure ruler context menu 2024-05-17 09:08:22 -06:00
Paul Davis
553e534455 remove a number of canvas items that no longer exist after ruler consolidation 2024-05-17 09:07:00 -06:00
Paul Davis
93e1e1c1f2 remove Cue, CD, Scene, Punch, Loop rulers, consolidate to just a pair (ranges, locations)
a menu allows choosing between all markers or 1 specific type, and all ranges or 1 specific type

more work required on menu structure and menu options/dialogs to specify the type of new location
and range marker creation
2024-05-16 22:58:55 -06:00
agfline
fc1377ae46 AAF: set session name from AAF filename instead of AAF composition name
https://github.com/agfline/LibAAF/issues/5#issuecomment-1952193515
2024-05-15 04:51:36 +02:00
Robin Gareus
7b75748299 Revert "As we've yet to implement user options, let's prefer AAF filenames rather than extracting an internal Comp name"
This reverts commit 2e55f4452f.
2024-05-15 04:49:43 +02:00
Robin Gareus
dad32d8b11 Clean up slider-controller includes 2024-05-14 23:41:51 +02:00
Robin Gareus
5b02561573 Fix MIDI Tracer (print polypress value) 2024-05-14 17:20:01 +02:00
Robin Gareus
caae3501ec TransportMasterWidget may not have a session
Other parts in this dialog already test for session == nullptr.
This can happen in the Preferences, when switching a timecode
master w/o a session (not possible in Ardour, but some derivative
project).
2024-05-13 23:11:43 +02:00
Paul Davis
c3eb30d96b action group names must not be translatable 2024-05-13 15:08:53 -06:00
Robin Gareus
6b8018d927 Indicate remaining record time for FLAC with >= 2024-05-13 21:54:18 +02:00
Paul Davis
b929e8a4e2 revert inadvertently committed change made for debugging. 2024-05-10 08:35:03 -06:00
Paul Davis
edc03002eb for DEBUG::Processors, use display_name() not name()
This allows us to differentiate between different instances of the same
type of processor (e.g. Trim vs Fader, which are both of type Amp)
2024-05-10 08:35:03 -06:00
John Emmas
2e55f4452f As we've yet to implement user options, let's prefer AAF filenames rather than extracting an internal Comp name
This helps to avoid situations where 2 x unrelated AAF imports use the same name internally - and/or they give us meaningless session names like "Untitled.ardour"
2024-05-10 15:07:44 +01:00
Robin Gareus
c62fbc5c5b Fix boundary condition first/last marker label length 2024-05-08 19:16:07 +02:00
Robin Gareus
a0dc432e7a Fix Marker label ellipsis for concurrent markers
* Sort markers: range-end before range-start
* When two marker have the same position, use distance
  to next marker not on the same position
2024-05-08 19:07:09 +02:00
Robin Gareus
e542a8e0a0 Add action to reset all peak-hold (incl input meters) 2024-05-08 17:09:13 +02:00
Robin Gareus
3bab92f9a7 Add action to reset all meter peak hold 2024-05-08 15:11:36 +02:00
Paul Davis
94e0f2d3cd make dbl-click on mixer strip name button start a rename 2024-05-07 16:58:26 -06:00
Paul Davis
7d04a8bdd4 remove redundant button number check 2024-05-07 16:58:26 -06:00
Paul Davis
90d21161e7 more correct implementation for RouteProcessorSelection::set (AxisView*)
Suspending changes while clearing core selection stripables doesn't work
correctly, because we are not notified of the change before attempting
to add the argument.
2024-05-07 16:58:26 -06:00
Paul Davis
fd1f68c34a allow mixer strip button events to fall through to parent, part 2 2024-05-07 16:58:26 -06:00
Paul Davis
29aeb88ce1 allow mixer strip button events to fall through to parent 2024-05-07 16:58:26 -06:00
Robin Gareus
5d175786e8 Remove debug messages, cleanup output (1/2) 2024-05-08 00:56:43 +02:00
John Emmas
dc74533fab Remove a declaration that won't be needed now 2024-05-07 16:06:47 +01:00
John Emmas
a345d05f0f When importing AAF's move some code so that it only gets executed once per Source, rather than once for every Region
Fixes a problem where the Editor's 'Sources' pane was showing too many entries if there were more Regions than Sources.
2024-05-07 10:32:25 +01:00
Robin Gareus
4f59b1ddf5 show/hide group-tab spacer above VCA pane 2024-05-06 23:47:10 +02:00
Paul Davis
576403c4cb no track movement up/down when a selected track is already at the relevant edge 2024-05-06 10:11:09 -06:00
Paul Davis
f92d821a72 working track drag-n-drop, re-picked from a 2nd implementation on a branch 2024-05-05 15:09:34 -06:00
Paul Davis
51d2b3329c more work catching button release after track drag 2024-05-05 15:03:12 -06:00
Paul Davis
c3fb69c385 catch button release after track drag 2024-05-05 15:02:59 -06:00
Paul Davis
b515174e6a initialize track_drag member of Editor 2024-05-05 15:02:41 -06:00