genconfig: Convert OVPN_ROUTES to array

* Convert to an array to simplify the code.
* This breaks running `ovpn_genconfig` multiple times with the same
  route argument as the array will just grow.  This needs to be fixed in
  the future.
* Recommended way to work around this is to remove ovpn_env.sh.

bin/ovpn_genconfig

@@ -48,23 +48,17 @@ set -ex
 OVPN_ENV=$OPENVPN/ovpn_env.sh
 OVPN_SERVER=192.168.255.0/24
 OVPN_DEFROUTE=1
+OVPN_ROUTES=()
 OVPN_PUSH=()
 
 # Import defaults if present
 [ -r "$OVPN_ENV" ] && source "$OVPN_ENV"
 
-ORIG_OVPN_ROUTES=$OVPN_ROUTES
-OVPN_ROUTES=""
-
 # Parse arguments
 while getopts ":r:s:du:cp:" opt; do
     case $opt in
         r)
-            if [ -n "$OVPN_ROUTES" ]; then
+            OVPN_ROUTES+=("$OPTARG")
-                OVPN_ROUTES+=" $OPTARG"
-            else
-                OVPN_ROUTES+="$OPTARG"
-            fi
             ;;
         s)
             OVPN_SERVER=$OPTARG
@@ -112,14 +106,7 @@ fi
 # Apply defaults
 [ -z "$OVPN_PROTO" ] && OVPN_PROTO=udp
 [ -z "$OVPN_PORT" ] && OVPN_PORT=1194
-
+[ ${#OVPN_ROUTES[@]} -eq 0 ] && OVPN_ROUTES=("192.168.254.0/24")
-if [ -z "$OVPN_ROUTES" ]; then
-    if [ -n "$ORIG_OVPN_ROUTES" ]; then
-        OVPN_ROUTES=$ORIG_OVPN_ROUTES
-    else
-        OVPN_ROUTES=192.168.254.0/24
-    fi
-fi
 
 export OVPN_SERVER OVPN_ROUTES OVPN_DEFROUTE
 export OVPN_SERVER_URL OVPN_ENV OVPN_PROTO OVPN_CN OVPN_PORT
@@ -168,10 +155,10 @@ EOF
 [ -n "$OVPN_CLIENT_TO_CLIENT" ] && echo "client-to-client" >> "$conf"
 
 # Append Routes
-for i in ${OVPN_ROUTES[@]}; do
+for i in "${OVPN_ROUTES[@]}"; do
     # If user passed "0" skip this, assume no extra routes
     [ "$i" = "0" ] && break;
-    echo route $(getroute $i) >> "$conf"
+    echo route $(getroute "$i") >> "$conf"
 done
 
 # Append push commands

bin/ovpn_run

@@ -21,8 +21,8 @@ fi
 if [ "$OVPN_DEFROUTE" != "0" ];then
     iptables -t nat -A POSTROUTING -s $OVPN_SERVER -o eth0 -j MASQUERADE
 
-    for i in ${OVPN_ROUTES[@]}; do
+    for i in "${OVPN_ROUTES[@]}"; do
-        iptables -t nat -A POSTROUTING -s $i -o eth0 -j MASQUERADE
+        iptables -t nat -A POSTROUTING -s "$i" -o eth0 -j MASQUERADE
     done
 fi