allanger/paulxstretch
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 2 Activity

fixed buffer overflow issue with large channel counts, found from au validation fail

Browse Source
This commit is contained in:
essej
2022-04-25 19:34:30 -04:00
parent 9d3d40bde7
commit feec263875
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Source/PS_Source/StretchSource.cpp
View File

@@ -313,10 +313,10 @@ void StretchAudioSource::getNextAudioBlock(const AudioSourceChannelInfo & buffer
if (m_vol_smoother.getTargetValue() != maingain) if (m_vol_smoother.getTargetValue() != maingain)
m_vol_smoother.setValue(maingain); m_vol_smoother.setTargetValue(maingain);
FloatVectorOperations::disableDenormalisedNumberSupport(); FloatVectorOperations::disableDenormalisedNumberSupport();
float** outarrays = bufferToFill.buffer->getArrayOfWritePointers(); float** outarrays = bufferToFill.buffer->getArrayOfWritePointers();
int outbufchans = m_num_outchans; // bufferToFill.buffer->getNumChannels(); int outbufchans = jmin(m_num_outchans, bufferToFill.buffer->getNumChannels());
int offset = bufferToFill.startSample; int offset = bufferToFill.startSample;
if (m_stretchers.size() == 0) if (m_stretchers.size() == 0)
return; return;
@@ -547,6 +547,10 @@ void StretchAudioSource::initObjects()
//Logger::writeToLog("Resizing circular buffer to " + String(newsize)); //Logger::writeToLog("Resizing circular buffer to " + String(newsize));
m_stretchoutringbuf.resize(newsize); m_stretchoutringbuf.resize(newsize);
} }
if (m_xfadetask.buffer.getNumChannels() < m_num_outchans)
{
m_xfadetask.buffer.setSize(m_num_outchans, m_xfadetask.buffer.getNumSamples());
}
m_stretchoutringbuf.clear(); m_stretchoutringbuf.clear();
m_resampler->Reset(); m_resampler->Reset();
m_resampler->SetRates(m_inputfile->info.samplerate, m_outsr); m_resampler->SetRates(m_inputfile->info.samplerate, m_outsr);