allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

Synchronize preset changes of plugin-instances

Browse Source 
When adding or removing a plugin preset, all instances
of the same plugin need to be notified to update their
preset list.
This commit is contained in:
Robin Gareus
2020-06-11 19:42:37 +02:00
parent 1c24e9abef
commit 0e37759495
2 changed files with 27 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
libs/ardour/ardour/plugin.h
View File

@@ -270,7 +270,7 @@ public:
PBD::Signal0<void> PresetRemoved;
/** Emitted when any preset has been changed */
static PBD::Signal2<void, std::string, Plugin*> PresetsChanged;
static PBD::Signal3<void, std::string, Plugin*, bool> PresetsChanged;
/** Emitted when a preset has been loaded */
PBD::Signal0<void> PresetLoaded;
@@ -405,6 +405,7 @@ private:
MidiRingBuffer<samplepos_t> _immediate_events;
void invalidate_preset_cache (std::string const&, Plugin*, bool);
void resolve_midi ();
};

28
libs/ardour/plugin.cc
View File

@@ -80,7 +80,7 @@ using namespace PBD;
namespace ARDOUR { class AudioEngine; }
PBD::Signal2<void, std::string, Plugin*> Plugin::PresetsChanged;
PBD::Signal3<void, std::string, Plugin*, bool> Plugin::PresetsChanged;
bool
PluginInfo::needs_midi_input () const
@@ -100,6 +100,7 @@ Plugin::Plugin (AudioEngine& e, Session& s)
, _immediate_events(6096) // FIXME: size?
{
_pending_stop_events.ensure_buffers (DataType::MIDI, 1, 4096);
PresetsChanged.connect_same_thread(_preset_connection, boost::bind (&Plugin::invalidate_preset_cache, this, _1, _2, _3));
}
Plugin::Plugin (const Plugin& other)
@@ -118,6 +119,8 @@ Plugin::Plugin (const Plugin& other)
, _immediate_events(6096) // FIXME: size?
{
_pending_stop_events.ensure_buffers (DataType::MIDI, 1, 4096);
PresetsChanged.connect_same_thread(_preset_connection, boost::bind (&Plugin::invalidate_preset_cache, this, _1, _2, _3));
}
Plugin::~Plugin ()
@@ -143,7 +146,7 @@ Plugin::remove_preset (string name)
_last_preset.uri = "";
_parameter_changed_since_last_preset = false;
_have_presets = false;
PresetsChanged (unique_id(), this); /* EMIT SIGNAL */
PresetsChanged (unique_id(), this, false); /* EMIT SIGNAL */
PresetRemoved (); /* EMIT SIGNAL */
}
@@ -160,13 +163,32 @@ Plugin::save_preset (string name)
if (!uri.empty()) {
_presets.insert (make_pair (uri, PresetRecord (uri, name)));
_have_presets = false;
PresetsChanged (unique_id(), this); /* EMIT SIGNAL */
PresetsChanged (unique_id(), this, true); /* EMIT SIGNAL */
PresetAdded (); /* EMIT SIGNAL */
}
return PresetRecord (uri, name);
}
void
Plugin::invalidate_preset_cache (std::string const& id, Plugin* plugin, bool added)
{
if (this == plugin || id != unique_id ()) {
return;
}
// TODO: use a shared cache in _info (via PluginInfo::get_presets)
_presets.clear ();
_have_presets = false;
if (added) {
PresetAdded (); /* EMIT SIGNAL */
} else {
PresetRemoved (); /* EMIT SIGNAL */
}
}
PluginPtr
ARDOUR::find_plugin(Session& session, string identifier, PluginType type)
{