allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

Fix region-editor (double) packing

Browse Source 
* show _region_line dropdown and label (previously ArdourHSpacer
  was packed in their place)
* add spacer at the bottom of the window to not prevent
  spreading out of clocks or other elements.
This commit is contained in:
Robin Gareus
2025-09-28 01:35:04 +02:00
parent bc3120dfe6
commit 14e8b66b61
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gtk2_ardour/audio_region_editor.cc
View File

@@ -119,6 +119,8 @@ AudioRegionEditor::AudioRegionEditor (Session* s, AudioRegionView* arv)
_table_main.attach (_region_line_label, 0, 1, row, row+1, Gtk::FILL, Gtk::SHRINK);
_table_main.attach (_region_line, 1, 3, row, row+1, Gtk::EXPAND | Gtk::FILL, Gtk::SHRINK);
_table_main.attach (_show_on_touch, 3, 4, row, row+1, Gtk::FILL, Gtk::SHRINK);
row++;
_table_main.attach (*manage (new ArdourWidgets::ArdourHSpacer (0)), 0, 3, row, row + 1, Gtk::FILL, Gtk::FILL | Gtk::EXPAND);
UI::instance()->set_tip (_polarity_toggle, _("Invert the signal polarity (180deg phase shift)"));
UI::instance()->set_tip (_fade_before_fx_toggle, _("Apply region effects after the region fade.\nThis is useful if the effect(s) have tail, which would otherwise be faded out by the region fade (e.g. reverb, delay)"));
@@ -127,6 +129,7 @@ AudioRegionEditor::AudioRegionEditor (Session* s, AudioRegionView* arv)
gain_changed ();
fade_before_fx_changed ();
refill_region_line ();
_table_main.show_all ();
_gain_adjustment.signal_value_changed ().connect (sigc::mem_fun (*this, &AudioRegionEditor::gain_adjustment_changed));
_polarity_toggle.signal_toggled ().connect (sigc::mem_fun (*this, &AudioRegionEditor::gain_adjustment_changed));

5
gtk2_ardour/region_editor.cc
View File

@@ -225,13 +225,12 @@ RegionEditor::RegionEditor (Session* s, std::shared_ptr<Region> r)
_table_main.attach (_table_clocks, 1, 2, 2, 3, Gtk::FILL, Gtk::SHRINK);
_table_main.attach (_table_tempo, 1, 2, 3, 4, Gtk::FILL, Gtk::SHRINK);
/* AudioRegionEditor inserts stuff into _table_main here */
/* AudioRegionEditor inserts stuff into _table_main here, row 4 .. 6 */
_table_main.attach (*manage (new ArdourWidgets::ArdourVSpacer (0)), 2, 3, 2, 4, Gtk::FILL | Gtk::EXPAND, Gtk::FILL);
_table_main.attach (*manage (new ArdourWidgets::ArdourHSpacer (0)), 0, 3, 5, 6, Gtk::FILL, Gtk::FILL | Gtk::EXPAND);
_table_main.attach (_region_fx_label, 3, 4, 0, 1, Gtk::SHRINK, Gtk::SHRINK);
_table_main.attach (_region_fx_box, 3, 4, 1, 5, Gtk::FILL, Gtk::EXPAND | Gtk::FILL);
_table_main.attach (_region_fx_box, 3, 4, 1, 5, Gtk::FILL, Gtk::FILL);
add (_table_main);