allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

Make the trim knob on busses show only if there is audio

Browse Source 
The trim knob has been designed to operate only on audio channels. If
the bus has none, hide the knob that would otherwise have no effect at
all.

Factor the trim control show/hide code out of MixerStrip::set_route(),
and also call that code in response to I/O changes in the route.
This commit is contained in:
Julien "_FrnchFrgg_" RIVAUD
2016-07-22 00:44:22 +02:00
parent ba815a903b
commit 4093cf6b90
2 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
gtk2_ardour/mixer_strip.cc
View File

@@ -457,6 +457,20 @@ MixerStrip::name() const
return string();
}
void
MixerStrip::update_trim_control ()
{
if (route()->trim() && route()->trim()->active() &&
route()->n_inputs().n_audio() > 0) {
trim_control.show ();
trim_control.set_controllable (route()->trim()->gain_control());
} else {
trim_control.hide ();
boost::shared_ptr<Controllable> none;
trim_control.set_controllable (none);
}
}
void
MixerStrip::set_route (boost::shared_ptr<Route> rt)
{
@@ -563,14 +577,7 @@ MixerStrip::set_route (boost::shared_ptr<Route> rt)
monitor_disk_button->hide ();
}
if (route()->trim() && route()->trim()->active()) {
trim_control.show ();
trim_control.set_controllable (route()->trim()->gain_control());
} else {
trim_control.hide ();
boost::shared_ptr<Controllable> none;
trim_control.set_controllable (none);
}
update_trim_control();
if (is_midi_track()) {
if (midi_input_enable_button == 0) {
@@ -1509,6 +1516,7 @@ void
MixerStrip::io_changed_proxy ()
{
Glib::signal_idle().connect_once (sigc::mem_fun (*this, &MixerStrip::update_panner_choices));
Glib::signal_idle().connect_once (sigc::mem_fun (*this, &MixerStrip::update_trim_control));
}
void

1
gtk2_ardour/mixer_strip.h
View File

@@ -253,6 +253,7 @@ class MixerStrip : public AxisView, public RouteUI, public Gtk::EventBox
PBD::ScopedConnection panstyle_connection;
void connect_to_pan ();
void update_panner_choices ();
void update_trim_control ();
void update_diskstream_display ();
void update_input_display ();