allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

Sort VST factory presets

Browse Source 
This is more of a workaround than a fix. Simply by forcing the
URI to be sortable (VST-user presets are sorted at the end).


This eventually needs a deeper cleanup and API consolidation

PluginInfo::get_presets(bool) returns an ordered std::vector.
However this API is only used in a few cases where the plugin is
not instantiated. PluginInfo::get_presets(bool).

The problem is Plugin::get_presets(). The method returns
information that was previously cached by Plugin::find_presets() in
std::map<URI, ...>
This commit is contained in:
Robin Gareus
2018-10-22 15:43:46 +02:00
parent 947f6c78b2
commit 4e1464e70f
3 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libs/ardour/lxvst_plugin.cc
View File

@@ -125,11 +125,11 @@ LXVSTPluginInfo::get_presets (bool user_only) const
int const vst_version = plugin->dispatcher (plugin, effGetVstVersion, 0, 0, NULL, 0);
for (int i = 0; i < plugin->numPrograms; ++i) {
Plugin::PresetRecord r (string_compose (X_("VST:%1:%2"), unique_id, i), "", false);
Plugin::PresetRecord r (string_compose (X_("VST:%1:%2"), unique_id, std::setw(4), std::setfill('0'), i), "", false);
if (vst_version >= 2) {
char buf[256];
if (plugin->dispatcher (plugin, 29, i, 0, buf, 0) == 1) {
r.label = buf;
r.label = string_compose (_("%1 - %2"), i, buf);
} else {
r.label = string_compose (_("Preset %1"), i);
}

2
libs/ardour/mac_vst_plugin.cc
View File

@@ -132,7 +132,7 @@ MacVSTPluginInfo::get_presets (bool user_only) const
int const vst_version = plugin->dispatcher (plugin, effGetVstVersion, 0, 0, NULL, 0);
for (int i = 0; i < plugin->numPrograms; ++i) {
Plugin::PresetRecord r (string_compose (X_("VST:%1:%2"), unique_id, i), "", false);
Plugin::PresetRecord r (string_compose (X_("VST:%1:%2"), unique_id, std::setw(4), std::setfill('0'), i), "", false);
if (vst_version >= 2) {
char buf[256];
if (plugin->dispatcher (plugin, 29, i, 0, buf, 0) == 1) {

3
libs/ardour/vst_plugin.cc
View File

@@ -840,7 +840,8 @@ VSTPlugin::find_presets ()
int const vst_version = _plugin->dispatcher (_plugin, effGetVstVersion, 0, 0, NULL, 0);
for (int i = 0; i < _plugin->numPrograms; ++i) {
PresetRecord r (string_compose (X_("VST:%1:%2"), unique_id (), i), "", false);
PresetRecord r (string_compose (X_("VST:%1:%2"), unique_id (), std::setw(4), std::setfill('0'), i), "", false);
if (vst_version >= 2) {
char buf[256];