allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

macOS: catch spurious full redraw calls to NSView:drawRect and act appropriately

Browse Source
This commit is contained in:
Paul Davis
2024-11-21 14:07:20 -07:00
parent 04fe2b5aa8
commit 4fbdf0d680
1 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
libs/tk/ydk/quartz/GdkQuartzView.c
View File

@@ -696,6 +696,7 @@
NSInteger count;
int i;
GdkRegion *region;
gboolean full_draw;
if (GDK_WINDOW_DESTROYED (gdk_window))
return;
@@ -706,6 +707,22 @@
if (NSEqualRects (rect, NSZeroRect))
return;
/* Quartz/CoreGraphics/something on macOS causes occasional/periodic drawRect
* calls with a "dirty" rect that covers the entire NSView. As of 11/2024,
* this seems to be caused by how much of the NSView is redrawn in a given
* interval. The lower layers really do invalidate the contents of any
* backing store, so if we do not obey the drawRect call, portions of the
* window will remain undrawn.
*/
if (NSContainsRect (rect, [self bounds])) {
full_draw = TRUE;
printf ("full draw seen!\n");
} else {
full_draw = FALSE;
}
if (!GDK_WINDOW_IS_MAPPED (gdk_window) && ((gdk_quartz_osx_version() >= GDK_OSX_LEOPARD) && [self wantsLayer]))
{
/* If the window is not yet mapped, clip_region_with_children
@@ -732,7 +749,7 @@
return;
}
if (!impl->needs_display_region || gdk_quartz_get_use_cocoa_invalidation()) {
if (!impl->needs_display_region || gdk_quartz_get_use_cocoa_invalidation() || full_draw) {
[self getRectsBeingDrawn: &drawn_rects count: &count];
region = gdk_region_new ();