allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

Prepare support for read-only plugin properties

Browse Source
This commit is contained in:
Robin Gareus
2025-10-02 04:55:34 +02:00
parent c529260137
commit 5d59454f6a
3 changed files with 24 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
libs/ardour/ardour/lv2_plugin.h
View File

@@ -178,7 +178,9 @@ class LIBARDOUR_API LV2Plugin : public ARDOUR::Plugin, public ARDOUR::Workee
int work_response(uint32_t size, const void* data);
void set_property(uint32_t key, const Variant& value);
const PropertyDescriptors& get_supported_properties() const { return _property_descriptors; }
const PropertyDescriptors& get_supported_properties (bool readonly) const {
return readonly ? _ro_property_descriptors : _property_descriptors;
}
const ParameterDescriptor& get_property_descriptor(uint32_t id) const;
Variant get_property_value (uint32_t) const;
void announce_property_values();
@@ -268,6 +270,7 @@ class LIBARDOUR_API LV2Plugin : public ARDOUR::Plugin, public ARDOUR::Workee
std::map<uint32_t, Variant> _property_values;
PropertyDescriptors _property_descriptors;
PropertyDescriptors _ro_property_descriptors;
struct AutomationCtrl {
AutomationCtrl (const AutomationCtrl &other)
@@ -380,7 +383,7 @@ class LIBARDOUR_API LV2Plugin : public ARDOUR::Plugin, public ARDOUR::Workee
void allocate_atom_event_buffers ();
void run (pframes_t nsamples, bool sync_work = false);
void load_supported_properties(PropertyDescriptors& descs);
void load_supported_properties(PropertyDescriptors& descs, bool writable);
#ifdef LV2_EXTENDED
bool has_inline_display ();

2
libs/ardour/ardour/plugin.h
View File

@@ -347,7 +347,7 @@ public:
* For LV2 plugins, properties are implemented by sending/receiving set/get
* messages to/from the plugin via event ports.
*/
virtual const PropertyDescriptors& get_supported_properties () const
virtual const PropertyDescriptors& get_supported_properties (bool readonly = false) const
{
static const PropertyDescriptors nothing;
return nothing;

24
libs/ardour/lv2_plugin.cc
View File

@@ -223,6 +223,7 @@ public:
LilvNode* units_unit;
LilvNode* units_render;
LilvNode* units_midiNote;
LilvNode* patch_readable;
LilvNode* patch_writable;
LilvNode* patch_Message;
LilvNode* opts_requiredOptions;
@@ -1015,7 +1016,8 @@ LV2Plugin::init(const void* c_plugin, samplecnt_t rate)
}
}
load_supported_properties(_property_descriptors);
load_supported_properties(_property_descriptors, true);
load_supported_properties(_ro_property_descriptors, false);
allocate_atom_event_buffers();
/* Load default state */
@@ -2075,6 +2077,10 @@ LV2Plugin::get_property_descriptor(uint32_t id) const
if (p != _property_descriptors.end()) {
return p->second;
}
p = _ro_property_descriptors.find(id);
if (p != _ro_property_descriptors.end()) {
return p->second;
}
return Plugin::get_property_descriptor(id);
}
@@ -2158,16 +2164,20 @@ load_parameter_descriptor(LV2World& world,
}
void
LV2Plugin::load_supported_properties(PropertyDescriptors& descs)
LV2Plugin::load_supported_properties(PropertyDescriptors& descs, bool writable)
{
LilvWorld* lworld = _world.world;
const LilvNode* subject = lilv_plugin_get_uri(_impl->plugin);
LilvNodes* properties = lilv_world_find_nodes(
lworld, subject, _world.patch_writable, NULL);
LilvNodes* properties = lilv_world_find_nodes(lworld, subject, writable ? _world.patch_writable : _world.patch_readable, NULL);
LILV_FOREACH(nodes, p, properties) {
// Get label and range
const LilvNode* prop = lilv_nodes_get(properties, p);
LilvNode* range = get_value(lworld, prop, _world.rdfs_range);
/* check if contrl is r/w */
if (!writable && lilv_world_ask(lworld, subject,_world.patch_writable, prop)) {
continue;
}
// Get label and range
LilvNode* range = get_value(lworld, prop, _world.rdfs_range);
if (!range) {
warning << string_compose(_("LV2<%1>: property <%2> has no range datatype, ignoring"),
name(), lilv_node_as_uri(prop)) << endmsg;
@@ -3609,6 +3619,7 @@ LV2World::LV2World()
units_hz = lilv_new_uri(world, LV2_UNITS__hz);
units_midiNote = lilv_new_uri(world, LV2_UNITS__midiNote);
units_db = lilv_new_uri(world, LV2_UNITS__db);
patch_readable = lilv_new_uri(world, LV2_PATCH__readable);
patch_writable = lilv_new_uri(world, LV2_PATCH__writable);
patch_Message = lilv_new_uri(world, LV2_PATCH__Message);
opts_requiredOptions = lilv_new_uri(world, LV2_OPTIONS__requiredOption);
@@ -3656,6 +3667,7 @@ LV2World::~LV2World()
lilv_node_free(patch_Message);
lilv_node_free(opts_requiredOptions);
lilv_node_free(patch_writable);
lilv_node_free(patch_readable);
lilv_node_free(units_hz);
lilv_node_free(units_midiNote);
lilv_node_free(units_db);