allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

Fix gain inc/dec with multiple-selection spanning groups

Browse Source 
When tracks in a gain-sharing group are selected, stepping gain
up/down affected the tracks N times:
   for-each selected track inc/dec gain w/grouping.

When a mix of grouped and un-grouped tracks is selected, this lead to
inconsistent gain changes.

The new approach expands the groups first. Ignoring groups is not correct
either for single selection.
This commit is contained in:
Robin Gareus
2017-07-08 15:43:32 +02:00
parent 82278af424
commit 5fc037cbe9
2 changed files with 27 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
gtk2_ardour/mixer_ui.cc
View File

@@ -2983,29 +2983,44 @@ Mixer_UI::rec_enable_action ()
control_action (&Stripable::rec_enable_control);
}
void
Mixer_UI::step_gain_up_action ()
AutomationControlSet
Mixer_UI::selected_gaincontrols ()
{
set_axis_targets_for_operation ();
AutomationControlSet rv;
BOOST_FOREACH(AxisView* r, _axis_targets) {
MixerStrip* ms = dynamic_cast<MixerStrip*> (r);
if (ms) {
ms->step_gain_up ();
boost::shared_ptr<GainControl> ac (ms->route()->gain_control());
ControlList cl (ac->grouped_controls());
for (ControlList::const_iterator c = cl.begin(); c != cl.end (); ++c) {
rv.insert (*c);
}
rv.insert (ac);
}
}
return rv;
}
void
Mixer_UI::step_gain_up_action ()
{
AutomationControlSet acs = selected_gaincontrols ();
for (AutomationControlSet::const_iterator i = acs.begin(); i != acs.end (); ++i) {
boost::shared_ptr<GainControl> ac = boost::dynamic_pointer_cast<GainControl> (*i);
assert (ac);
ac->set_value (dB_to_coefficient (accurate_coefficient_to_dB (ac->get_value()) + 0.1), Controllable::NoGroup);
}
}
void
Mixer_UI::step_gain_down_action ()
{
set_axis_targets_for_operation ();
BOOST_FOREACH(AxisView* r, _axis_targets) {
MixerStrip* ms = dynamic_cast<MixerStrip*> (r);
if (ms) {
ms->step_gain_down ();
}
AutomationControlSet acs = selected_gaincontrols ();
for (AutomationControlSet::const_iterator i = acs.begin(); i != acs.end (); ++i) {
boost::shared_ptr<GainControl> ac = boost::dynamic_pointer_cast<GainControl> (*i);
assert (ac);
ac->set_value (dB_to_coefficient (accurate_coefficient_to_dB (ac->get_value()) - 0.1), Controllable::NoGroup);
}
}

1
gtk2_ardour/mixer_ui.h
View File

@@ -129,6 +129,7 @@ public:
protected:
void set_axis_targets_for_operation ();
ARDOUR::AutomationControlSet selected_gaincontrols ();
private:
Mixer_UI ();