allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

pianoroll: follow code guidelines via early exits for null view

Browse Source
This commit is contained in:
Paul Davis
2026-01-12 14:28:56 -07:00
parent 1f96930a44
commit 6359b6c5b0
1 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
gtk2_ardour/pianoroll.cc
View File

@@ -1564,37 +1564,41 @@ Pianoroll::user_automation_show_button_click (GdkEventButton* ev, MetaButton* me
void
Pianoroll::automation_active_button_click (Evoral::ParameterType type, int id)
{
if (!view) {
return;
}
EC_LOCAL_TEMPO_SCOPE;
if (view) {
Evoral::Parameter p (type, _visible_channel, id);
Evoral::Parameter p (type, _visible_channel, id);
if (view->is_active_automation (p)) {
view->unset_active_automation ();
return;
}
if (!layered_automation && !view->is_visible_automation (p)) {
view->hide_all_automation ();
}
view->set_active_automation (p);
if (view->is_active_automation (p)) {
view->unset_active_automation ();
return;
}
if (!layered_automation && !view->is_visible_automation (p)) {
view->hide_all_automation ();
}
view->set_active_automation (p);
}
void
Pianoroll::automation_show_button_click (Evoral::ParameterType type, int id)
{
if (!view) {
return;
}
EC_LOCAL_TEMPO_SCOPE;
if (view) {
Evoral::Parameter param (type, _visible_channel, id);
if (!layered_automation && !view->is_visible_automation (param)) {
/* Param is about to become visible, hide everything else */
view->hide_all_automation ();
}
view->toggle_visibility (param);
Evoral::Parameter param (type, _visible_channel, id);
if (!layered_automation && !view->is_visible_automation (param)) {
/* Param is about to become visible, hide everything else */
view->hide_all_automation ();
}
view->toggle_visibility (param);
}
void
@@ -1604,7 +1608,6 @@ Pianoroll::automation_state_changed ()
assert (view);
for (ParameterButtonMap::iterator i = parameter_button_map.begin(); i != parameter_button_map.end(); ++i) {
std::string str (ARDOUR::EventTypeMap::instance().to_symbol (i->second));