Some more assert() debugging

libs/ardour/audio_port.cc

@@ -77,6 +77,7 @@ AudioBuffer&
 AudioPort::get_audio_buffer (pframes_t nframes)
 {
 	/* caller must hold process lock */
+	assert (_port_handle);
 	_buffer->set_data ((Sample *) port_engine.get_buffer (_port_handle, _cycle_nframes) +
 			   _global_port_buffer_offset + _port_buffer_offset, nframes);
 	return *_buffer;
@@ -86,6 +87,7 @@ Sample*
 AudioPort::engine_get_whole_audio_buffer ()
 {
 	/* caller must hold process lock */
+	assert (_port_handle);
 	return (Sample *) port_engine.get_buffer (_port_handle, _cycle_nframes);
 }
 

libs/ardour/session_ltc.cc

@@ -64,6 +64,7 @@ using namespace Timecode;
 void
 Session::ltc_tx_initialize()
 {
+	assert (!ltc_encoder && !ltc_enc_buf);
 	ltc_enc_tcformat = config.get_timecode_format();
 
 	ltc_tx_parse_offset();
@@ -93,11 +94,11 @@ void
 Session::ltc_tx_cleanup()
 {
 	DEBUG_TRACE (DEBUG::LTC, "LTC TX cleanup\n");
+	ltc_tx_connections.drop_connections ();
 	free(ltc_enc_buf);
 	ltc_enc_buf = NULL;
 	ltc_encoder_free(ltc_encoder);
 	ltc_encoder = NULL;
-	ltc_tx_connections.drop_connections ();
 }
 
 void

libs/backends/coreaudio/coreaudio_backend.cc

@@ -1569,7 +1569,9 @@ CoreAudioBackend::n_physical_inputs () const
 void*
 CoreAudioBackend::get_buffer (PortEngine::PortHandle port, pframes_t nframes)
 {
-	if (!port || !valid_port (port)) return NULL;
+	assert (port);
+	assert (valid_port (port));
+	if (!port || !valid_port (port)) return NULL; // XXX remove me
 	return static_cast<CoreBackendPort*>(port)->get_buffer (nframes);
 }
 

libs/backends/portaudio/portaudio_backend.cc

@@ -1816,7 +1816,9 @@ PortAudioBackend::n_physical_inputs () const
 void*
 PortAudioBackend::get_buffer (PortEngine::PortHandle port, pframes_t nframes)
 {
-	if (!port || !valid_port (port)) return NULL;
+	assert (port);
+	assert (valid_port (port));
+	if (!port || !valid_port (port)) return NULL; // XXX remove me
 	return static_cast<PamPort*>(port)->get_buffer (nframes);
 }