allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

fix handling of MIDI controller MSB & LSB values

Browse Source 
The MIDI specification makes it quite clear that when a receiver
receives the MSB of a 14 bit controller value, it should consider
the LSB reset to zero. This has been an error in Ardour for many,
many years, though likely of little consequence
This commit is contained in:
Paul Davis
2024-06-27 16:41:53 -06:00
parent da520cecf3
commit 8efab1c796
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/midi++2/channel.cc
View File

@@ -272,8 +272,8 @@ Channel::process_controller (Parser & parser, EventTwoBytes *tb)
if (tb->controller_number < 32) { /* unsigned: no test for >= 0 */
/* if this controller is already known to use 14 bits,
then treat this value as the MSB, and combine it
with the existing LSB.
then treat this value as the MSB, and as per MIDI spec, set
LSB to zero.
otherwise, just treat it as a 7 bit value, and set
it directly.
@@ -282,7 +282,7 @@ Channel::process_controller (Parser & parser, EventTwoBytes *tb)
cv = (unsigned short) _controller_val[tb->controller_number];
if (_controller_14bit[tb->controller_number]) {
cv = ((tb->value & 0x7f) << 7) | (cv & 0x7f);
cv = (tb->value & 0x7f) << 7);
} else {
cv = tb->value;
}