allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

Prevent issues when changing processors while recording #10017

Browse Source 
Processor changes trigger configure_io() which resulted in a
call to reset_write_sources(), which is a disaster while recording.

This allows adding plugins while recording, and prevents adding
any plugins before the disk-writer that change the channel-count
while recording, or changing strict-i/o to the same effect.
This commit is contained in:
Robin Gareus
2025-09-28 23:52:36 +02:00
parent d3d31378db
commit a0cd43132b
2 changed files with 31 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
libs/ardour/ardour/disk_writer.h
View File

@@ -82,6 +82,7 @@ public:
PBD::Signal<void()> AlignmentStyleChanged;
bool configure_io (ChanCount in, ChanCount out);
bool can_support_io_configuration (const ChanCount& in, ChanCount& out);
std::list<std::shared_ptr<Source>>& last_capture_sources ();
void reset_last_capture_sources ();

30
libs/ardour/disk_writer.cc
View File

@@ -1461,6 +1461,28 @@ DiskWriter::steal_write_source_name ()
return std::string();
}
bool
DiskWriter::can_support_io_configuration (const ChanCount& in, ChanCount& out)
{
if (record_enabled() && _session.actively_recording()) {
bool changed = false;
std::shared_ptr<ChannelList const> c = channels.reader();
if (in.n_audio() != c->size()) {
changed = true;
}
if ((0 == in.n_midi ()) != (0 == _midi_buf)) {
changed = true;
}
if (changed) {
out.set (DataType::AUDIO, c->size());
out.set (DataType::MIDI, (0 == _midi_buf) ? 0 : 1);
return false;
}
}
return DiskIOProcessor::can_support_io_configuration (in, out);
}
bool
DiskWriter::configure_io (ChanCount in, ChanCount out)
{
@@ -1481,6 +1503,14 @@ DiskWriter::configure_io (ChanCount in, ChanCount out)
return false;
}
if (record_enabled() && _session.actively_recording()) {
/* Cannot reset write source, while recording.
* see also ::can_support_io_configuration() above.
*/
assert (0);
return !changed;
}
if (record_enabled() || changed) {
reset_write_sources (false);
}