allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

use default window position everywhere we can and should in gtk2_ardour

Browse Source 
This is still a no-op, because the default value is WIN_POS_MOUSE
and it is not exposed on the UI at this point.
This commit is contained in:
Paul Davis
2025-11-18 11:30:36 -07:00
parent f70b59f349
commit e0d25220a6
16 changed files with 30 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gtk2_ardour/add_route_dialog.cc
View File

@@ -89,7 +89,7 @@ AddRouteDialog::AddRouteDialog ()
set_name ("AddRouteDialog");
set_skip_taskbar_hint (true);
set_resizable (false);
set_position (WIN_POS_MOUSE);
set_position (UIConfiguration::instance().get_default_window_position());
name_template_entry.set_name (X_("AddRouteDialogNameTemplateEntry"));
// routes_spinner.set_name (X_("AddRouteDialogSpinner"));

2
gtk2_ardour/ardour_dialog.cc
View File

@@ -45,7 +45,7 @@ ArdourDialog::ArdourDialog (const string& title, bool modal, bool use_seperator)
, allow_idle (true)
{
init ();
set_position (Gtk::WIN_POS_MOUSE);
set_position (UIConfiguration::instance().get_default_window_position());
}
ArdourDialog::ArdourDialog (Gtk::Window& parent, const string& title, bool modal, bool use_seperator)

7
gtk2_ardour/ardour_message.cc
View File

@@ -18,6 +18,7 @@
#include "ardour_message.h"
#include "splash.h"
#include "ui_config.h"
using namespace Gtk;
@@ -29,7 +30,7 @@ ArdourMessageDialog::ArdourMessageDialog (const Glib::ustring& message,
: Gtk::MessageDialog (message, use_markup, type, buttons, modal)
, _splash_pushed (false)
{
set_position (WIN_POS_MOUSE);
set_position (UIConfiguration::instance().get_default_window_position());
}
ArdourMessageDialog::ArdourMessageDialog (Gtk::Window& parent,
@@ -42,7 +43,7 @@ ArdourMessageDialog::ArdourMessageDialog (Gtk::Window& parent,
, _splash_pushed (false)
{
set_transient_for (parent);
set_position (WIN_POS_MOUSE);
set_position (UIConfiguration::instance().get_default_window_position());
}
ArdourMessageDialog::ArdourMessageDialog (Gtk::Window* parent,
@@ -57,7 +58,7 @@ ArdourMessageDialog::ArdourMessageDialog (Gtk::Window* parent,
if (parent) {
set_transient_for (*parent);
}
set_position (WIN_POS_MOUSE);
set_position (UIConfiguration::instance().get_default_window_position());
}
ArdourMessageDialog::~ArdourMessageDialog ()

10
gtk2_ardour/ardour_ui.cc
View File

@@ -1124,7 +1124,7 @@ ARDOUR_UI::ask_about_scratch_deletion ()
msg.add_button (_("Delete this session (IRREVERSIBLE!)"), RESPONSE_OK);
msg.add_button (_("Do not delete"), RESPONSE_CANCEL);
msg.set_default_response (RESPONSE_CANCEL);
msg.set_position (Gtk::WIN_POS_MOUSE);
msg.set_position (UIConfiguration::instance().get_default_window_position());
int r = msg.run ();
@@ -2595,7 +2595,7 @@ will release an additional %3 %4bytes of disk space.\n", removed),
results.get_vbox()->pack_start (ddhbox, true, false, 5);
results.add_button (Stock::CLOSE, RESPONSE_CLOSE);
results.set_default_response (RESPONSE_CLOSE);
results.set_position (Gtk::WIN_POS_MOUSE);
results.set_position (UIConfiguration::instance().get_default_window_position());
results_display.show();
list_scroller.show();
@@ -2638,7 +2638,7 @@ Clean-up will move all unused files to a \"dead\" location."));
checker.set_name (_("CleanupDialog"));
checker.set_wmclass (X_("ardour_cleanup"), PROGRAM_NAME);
checker.set_position (Gtk::WIN_POS_MOUSE);
checker.set_position (UIConfiguration::instance().get_default_window_position());
switch (checker.run()) {
case RESPONSE_ACCEPT:
@@ -2789,7 +2789,7 @@ ARDOUR_UI::add_route ()
return;
}
add_route_dialog->set_position (WIN_POS_MOUSE);
add_route_dialog->set_position (UIConfiguration::instance().get_default_window_position());
add_route_dialog->present();
}
@@ -2879,7 +2879,7 @@ ARDOUR_UI::add_route_dialog_response (int r)
d.add_button(Stock::CANCEL, RESPONSE_CANCEL);
d.add_button(Stock::OK, RESPONSE_OK);
d.set_default_response (RESPONSE_OK);
d.set_position (WIN_POS_MOUSE);
d.set_position (UIConfiguration::instance().get_default_window_position());
d.show_all ();
if (d.run () == RESPONSE_OK) {

2
gtk2_ardour/ardour_ui_dependents.cc
View File

@@ -214,7 +214,7 @@ ARDOUR_UI::idle_ask_about_quit ()
Gtk::BUTTONS_YES_NO,
true); /* modal */
msg.set_default_response (Gtk::RESPONSE_YES);
msg.set_position (WIN_POS_MOUSE);
msg.set_position (UIConfiguration::instance().get_default_window_position());
if (msg.run () == Gtk::RESPONSE_YES) {
finish ();

2
gtk2_ardour/ardour_window.cc
View File

@@ -40,7 +40,7 @@ ArdourWindow::ArdourWindow (string title)
{
set_title (title);
init ();
set_position (Gtk::WIN_POS_MOUSE);
set_position (UIConfiguration::instance().get_default_window_position());
}
ArdourWindow::ArdourWindow (Gtk::Window& parent, string title)

2
gtk2_ardour/color_theme_manager.cc
View File

@@ -486,7 +486,7 @@ ColorThemeManager::choose_color_from_palette (string const & name)
palette_response_connection = palette_window->signal_response().connect (sigc::bind (sigc::mem_fun (*this, &ColorThemeManager::alias_palette_response), name, i->second));
palette_window->set_position (WIN_POS_MOUSE);
palette_window->set_position (UIConfiguration::instance().get_default_window_position());
palette_window->present ();
}

3
gtk2_ardour/duplicate_routes_dialog.cc
View File

@@ -25,6 +25,7 @@
#include "editor.h"
#include "duplicate_routes_dialog.h"
#include "selection.h"
#include "ui_config.h"
#include "pbd/i18n.h"
@@ -207,7 +208,7 @@ DuplicateRouteDialog::on_response (int response)
if (err) {
MessageDialog msg (_("1 or more tracks/busses could not be duplicated"),
true, MESSAGE_ERROR, BUTTONS_OK, true);
msg.set_position (WIN_POS_MOUSE);
msg.set_position (UIConfiguration::instance().get_default_window_position());
msg.run ();
}
}

2
gtk2_ardour/editor_drag.cc
View File

@@ -7284,7 +7284,7 @@ RegionMarkerDrag::finished (GdkEvent*, bool did_move)
d.add_button (Stock::CANCEL, RESPONSE_CANCEL);
d.add_button (Stock::OK, RESPONSE_OK);
d.set_default_response (RESPONSE_OK);
d.set_position (WIN_POS_MOUSE);
d.set_position (UIConfiguration::instance().get_default_window_position());
int result = d.run ();
string str = e.get_text ();

3
gtk2_ardour/editor_export_audio.cc
View File

@@ -64,6 +64,7 @@
#include "selection.h"
#include "simple_export_dialog.h"
#include "time_axis_view.h"
#include "ui_config.h"
#include "utils.h"
#include "pbd/i18n.h"
@@ -344,7 +345,7 @@ Editor::bounce_region_selection (bool with_processing)
dialog.set_name ("BounceNameWindow");
dialog.set_size_request (400, -1);
dialog.set_position (Gtk::WIN_POS_MOUSE);
dialog.set_position (UIConfiguration::instance().get_default_window_position());
dialog.add_button (_("Bounce"), RESPONSE_ACCEPT);

2
gtk2_ardour/editor_markers.cc
View File

@@ -1877,7 +1877,7 @@ Editor::edit_location (Location& loc, bool with_scene, bool with_command)
dialog.set_name ("MarkRenameWindow");
dialog.set_size_request (250, -1);
dialog.set_position (Gtk::WIN_POS_MOUSE);
dialog.set_position (UIConfiguration::instance().get_default_window_position());
dialog.add_button (verb, RESPONSE_ACCEPT);
dialog.set_response_sensitive (Gtk::RESPONSE_ACCEPT, false);

6
gtk2_ardour/editor_ops.cc
View File

@@ -1925,7 +1925,7 @@ Editor::choose_new_marker_name(string &name, bool is_range) {
dialog.set_name ("MarkNameWindow");
dialog.set_size_request (250, -1);
dialog.set_position (Gtk::WIN_POS_MOUSE);
dialog.set_position (UIConfiguration::instance().get_default_window_position());
dialog.add_button (Stock::OK, RESPONSE_ACCEPT);
dialog.set_initial_text (name);
@@ -4119,7 +4119,7 @@ Editor::bounce_range_selection (BounceTarget target, bool with_processing)
dialog.set_name ("BounceNameWindow");
dialog.set_size_request (400, -1);
dialog.set_position (Gtk::WIN_POS_MOUSE);
dialog.set_position (UIConfiguration::instance().get_default_window_position());
dialog.add_button (_("Bounce"), RESPONSE_ACCEPT);
dialog.set_initial_text (bounce_name);
@@ -8594,7 +8594,7 @@ Editor::start_visual_state_op (uint32_t n)
{
save_visual_state (n);
PopUp* pup = new PopUp (WIN_POS_MOUSE, 1000, true);
PopUp* pup = new PopUp (UIConfiguration::instance().get_default_window_position(), 1000, true);
char buf[32];
snprintf (buf, sizeof (buf), _("Saved view %u"), n+1);
pup->set_text (buf);

2
gtk2_ardour/recorder_ui.cc
View File

@@ -1282,7 +1282,7 @@ RecorderUI::new_track_for_port (DataType dt, string const& port_name)
d.add_button(Stock::CANCEL, RESPONSE_CANCEL);
d.add_button(Stock::OK, RESPONSE_OK);
d.set_default_response (RESPONSE_OK);
d.set_position (WIN_POS_MOUSE);
d.set_position (UIConfiguration::instance().get_default_window_position());
d.show_all ();
track_name_entry.signal_activate().connect (sigc::bind (sigc::mem_fun (d, &Dialog::response), RESPONSE_OK));

3
gtk2_ardour/route_group_dialog.cc
View File

@@ -33,6 +33,7 @@
#include "gui_thread.h"
#include "route_group_dialog.h"
#include "group_tabs.h"
#include "ui_config.h"
#include "pbd/i18n.h"
@@ -205,7 +206,7 @@ RouteGroupDialog::name_check () const
true
);
msg.set_position (WIN_POS_MOUSE);
msg.set_position (UIConfiguration::instance().get_default_window_position());
msg.run ();
return false;

6
gtk2_ardour/stripable_colorpicker.cc
View File

@@ -98,7 +98,7 @@ StripableColorDialog::popup (const std::string& name, uint32_t color, Gtk::Windo
if (parent) {
set_transient_for (*parent);
}
set_position (Gtk::WIN_POS_MOUSE);
set_position (UIConfiguration::instance().get_default_window_position());
present ();
}
@@ -110,7 +110,7 @@ StripableColorDialog::popup (std::shared_ptr<ARDOUR::Stripable> s, Gtk::Window*
s->active_color_picker()->set_transient_for (*parent);
}
s->active_color_picker()->set_position (Gtk::WIN_POS_CENTER_ALWAYS); // force update
s->active_color_picker()->set_position (Gtk::WIN_POS_MOUSE);
s->active_color_picker()->set_position (UIConfiguration::instance().get_default_window_position());
s->active_color_picker()->present ();
return;
}
@@ -120,7 +120,7 @@ StripableColorDialog::popup (std::shared_ptr<ARDOUR::Stripable> s, Gtk::Window*
set_transient_for (*parent);
}
set_position (Gtk::WIN_POS_CENTER_ALWAYS); // force update
set_position (Gtk::WIN_POS_MOUSE);
set_position (UIConfiguration::instance().get_default_window_position());
present ();
return;
}

2
gtk2_ardour/vca_master_strip.cc
View File

@@ -543,7 +543,7 @@ VCAMasterStrip::remove ()
checker.set_name (X_("RemoveVcaDialog"));
checker.set_wmclass (X_("ardour_vca_remove"), PROGRAM_NAME);
checker.set_position (Gtk::WIN_POS_MOUSE);
checker.set_position (UIConfiguration::instance().get_default_window_position());
switch (checker.run()) {
case RESPONSE_ACCEPT: