allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

use MidiModel::ContentsChanged to drive MIDI cue edit swaps (GUI version)

Browse Source 
No need for a special method called post-edit
This commit is contained in:
Paul Davis
2024-06-27 16:22:27 -06:00
parent fd6afb30e6
commit f80395fc2f
4 changed files with 0 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gtk2_ardour/midi_cue_view.cc
View File

@@ -125,11 +125,3 @@ MidiCueView::set_samples_per_pixel (double spp)
reset_width_dependent_items (_editing_context.duration_to_pixels (duration));
}
void
MidiCueView::post_edit ()
{
std::cerr << "Post-edit\n";
std::shared_ptr<ARDOUR::TriggerBox> tb = _midi_track->triggerbox ();
assert (tb);
std::dynamic_pointer_cast<ARDOUR::MIDITrigger>(tb->trigger (_slot_index))->edited ();
}

2
gtk2_ardour/midi_cue_view.h
View File

@@ -55,8 +55,6 @@ class MidiCueView : public MidiView
std::shared_ptr<Temporal::TempoMap const> tempo_map;
ArdourCanvas::Rectangle* event_rect;
uint32_t _slot_index;
void post_edit ();
};

7
gtk2_ardour/midi_view.cc
View File

@@ -917,7 +917,6 @@ MidiView::apply_note_diff (bool as_subcommand, bool was_copy)
if (!as_subcommand) {
_editing_context.commit_reversible_command (); /*instead, we can explicitly commit the command in progress */
post_edit ();
}
_note_diff_command = nullptr;
@@ -2748,7 +2747,6 @@ MidiView::note_dropped (NoteBase *, timecnt_t const & d_qn, int8_t dnote, bool c
apply_note_diff (true /*subcommand, we don't want this to start a new commit*/, copy);
_editing_context.commit_reversible_command ();
post_edit ();
// care about notes being moved beyond the upper/lower bounds on the canvas
if (lowest_note_in_selection < _midi_context.lowest_note() ||
@@ -3246,7 +3244,6 @@ MidiView::set_velocities_for_notes (std::vector<NoteBase*>& notes, std::vector<i
apply_note_diff (true /*subcommand, we don't want this to start a new commit*/, false);
_editing_context.commit_reversible_command ();
post_edit ();
delete _note_diff_command;
_note_diff_command = nullptr;
@@ -3749,7 +3746,6 @@ MidiView::duplicate_selection ()
bool commit = paste (dup_pos, local_selection, ctxt);
if (commit) {
_editing_context.commit_reversible_command ();
post_edit ();
} else {
_editing_context.abort_reversible_command ();
}
@@ -3909,7 +3905,6 @@ MidiView::goto_next_note (bool add_to_selection)
_editing_context.commit_reversible_selection_op();
post_edit ();
}
void
@@ -3962,7 +3957,6 @@ MidiView::goto_previous_note (bool add_to_selection)
}
_editing_context.commit_reversible_selection_op();
post_edit ();
}
void
@@ -4493,7 +4487,6 @@ MidiView::quantize_selected_notes ()
(*cmd)();
_editing_context.session()->add_command (cmd);
_editing_context.commit_reversible_command ();
post_edit ();
_editing_context.session()->set_dirty ();
}

2
gtk2_ardour/midi_view.h
View File

@@ -640,8 +640,6 @@ class MidiView : public virtual sigc::trackable
void join_notes_on_channel (int channel);
void add_split_notes ();
virtual void post_edit () {}
};