allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

Fix end vs. length bug when creating regions - #7978

Browse Source 
set_length() includes the end.
A Region starting at 0 and ending at 0, has a length of 1
(think counting fence-posts, or video-frames).
This commit is contained in:
Robin Gareus
2020-04-05 20:19:26 +02:00
parent 14a2a50e93
commit fbc48bdf34
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gtk2_ardour/editor_drag.cc
View File

@@ -2484,15 +2484,9 @@ RegionCreateDrag::motion (GdkEvent* event, bool first_move)
_region->set_initial_position (f);
}
/* Don't use a zero-length region, and subtract 1 sample from the snapped length
so that if this region is duplicated, its duplicate starts on
a snap point rather than 1 sample after a snap point. Otherwise things get
a bit confusing as if a region starts 1 sample after a snap point, one cannot
place snapped notes at the start of the region.
*/
if (f != grab_sample()) {
samplecnt_t const len = (samplecnt_t) fabs ((double)(f - grab_sample () - 1));
_region->set_length (len < 1 ? 1 : len, _editor->get_grid_music_divisions (event->button.state));
samplecnt_t const len = ::llabs (f - grab_sample ());
_region->set_length (len, _editor->get_grid_music_divisions (event->button.state));
}
}
}