allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity

fix inappropriate signal emission patterns in Triggerbox/Trigger

Browse Source
This commit is contained in:
Paul Davis
2025-04-14 10:09:17 -06:00
parent 623df55653
commit fc31513bbe
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
libs/ardour/triggerbox.cc
View File

@@ -320,17 +320,22 @@ Trigger::_arm (Temporal::BBT_Offset const & duration)
}
_box.arm_from_another_thread (*this, _box.session().transport_sample(), chns, duration);
_armed = true;
ArmChanged(); /* EMIT SIGNAL */
TriggerArmChanged (this); /* EMIT SIGNAL */
if (!_armed) {
_armed = true;
ArmChanged(); /* EMIT SIGNAL */
TriggerArmChanged (this); /* EMIT SIGNAL */
}
}
void
Trigger::disarm ()
{
_armed = false;
ArmChanged(); /* EMIT SIGNAL */
TriggerArmChanged (this);
if (_armed) {
_armed = false;
ArmChanged(); /* EMIT SIGNAL */
TriggerArmChanged (this);
}
}
void
@@ -2531,8 +2536,10 @@ void
MIDITrigger::captured (SlotArmInfo& ai, BufferSet& bufs)
{
if (ai.midi_buf->size() == 0) {
_armed = false;
ArmChanged(); /* EMIT SIGNAL */
if (_armed) {
_armed = false;
ArmChanged(); /* EMIT SIGNAL */
}
return;
}
@@ -3816,6 +3823,7 @@ TriggerBox::maybe_capture (BufferSet& bufs, samplepos_t start_sample, samplepos_
offset = ai->start_samples - start_sample;
nframes -= offset;
_record_state = Recording;
RecEnableChanged(); /* EMIT SIGNAL */
// std::cerr << "Hit start @ " << ai->start_samples << " within " << start_sample << " ... " << end_sample << " offset will be " << offset << " nf " << nframes << std::endl;
}