Commit Graph

23893 Commits

Author SHA1 Message Date
Colin Fletcher
0d21c15375 Make 'Insert time' dialogue do for 'Cut time' too
Add a bool cut parameter to InsertTimeDialog's constructor, so it can
do double duty as 'Cut time'. The class probably ought to be renamed too.
2015-06-17 17:15:21 +01:00
Colin Fletcher
292f704b30 Insert time: don't unlock markers we're not going to move anyway
Move checking for locked markers in Editor::insert_time() so it doesn't
happen if we're going to skip the marker because it's glued to musical
time.
2015-06-17 17:15:21 +01:00
Colin Fletcher
34e1e00f8b Insert time: fix moving of range markers
When inserting time and moving a range marker, move its end first, before
moving its start, so that if the time being inserted is greater than the
length of the range, we don't try to set its start to after its end.
2015-06-17 17:15:21 +01:00
nick_m
80090f0f71 Fix thinko in automation write undo.
- also allow saved automation list state to be touch or off if
	  actually in write mode.
2015-06-17 22:19:21 +10:00
Robin Gareus
d059bdb40c fix 1024px width layout (remove nudge clock special case)
Due to some change somewhere along the road the nudge clock does
no longer fit in the transport-bar on 1024px screen with 100% font-scale,
even if the 2nd clock is hidden.

However, these days it does fit nicely on its default position even
with wide-editor-mixer on a 1024px screen.
2015-06-17 02:20:02 +02:00
nick_m
44790ebff0 More _reversible_command() auditing in the gui.
- try to keep begin/commit pairs in the same file where possible.
2015-06-17 09:54:23 +10:00
nick_m
d019ee836c Use a better pattern to avoid abort_reversible_command().
- also, duplicated regoins are now selected and some end-of sesion
	  bugs fixed there.
	- should fix lack of tempomap undo in Editor::insert_time ()
2015-06-17 09:54:23 +10:00
nick_m
4c1d79af4a Unbreak region brush drag wrt undo, avoid some dangling commands in the gui
- also allow moving of automation lines in internal mouse mode.
	- this is also a first pass at ensuring that if an operation does
	  nothing, avoid an undo entry.
2015-06-17 09:54:22 +10:00
nick_m
15336d06e4 Add undo for automation write. 2015-06-17 09:54:22 +10:00
nick_m
15819f0896 Automation -use editor_add in gui, record straight lines with fewer points.
- don't keep setting/unsetting write pass when transport frame
	  remains the same (think larger jack buffer sizes)
	- insert guards are now 64 frames after when.
	- refactor previous approach.
2015-06-17 09:54:22 +10:00
nick_m
7cb9dbb8af Rudimentary automation touch undo/redo. 2015-06-17 09:54:22 +10:00
nick_m
57ce447fd1 Fix some workflow problems wrt automation.
- clearing automation points sets control to "off" rather than touch.
	- multiple touches on the same pass acts consistently (no more
	  fader jumps on mouse button press
	- use actual value for initial point rather than some arbitrary
	  default. clarify new semantics of add () (with_default->with_initial).
	- clean some whitespace
	- add guard points as needed in stop.
	- catch grab broken signal (i can't trigger it, but the docs seem
	  to think it is essential).
2015-06-17 09:54:22 +10:00
Robin Gareus
9d4c93aca7 -Wsign-compare 2015-06-16 19:27:22 +02:00
Paul Davis
90220998af add Record-Safe feature to libardour (from Nikolay Polyanovskii) 2015-06-16 08:44:03 -04:00
Paul Davis
d65f03d074 fixes for canvas text display on Retina (from Valeriy) 2015-06-16 07:52:00 -04:00
Robin Gareus
3f157f961a use mpeg4 for internal video format (not mjpeg)
reduces file size.
xjadeo > 0.8 and harvid >= 0.8 handle this fine.
2015-06-16 00:47:53 +02:00
Robin Gareus
dc2030cfd7 ALSA backend: add support for half-duplex devices 2015-06-14 22:26:06 +02:00
Robin Gareus
acd95215a4 allow to scan for half-duplex ALSA devices 2015-06-14 22:26:06 +02:00
Robin Gareus
94c146c780 prepare ALSA backend for half-duplex 2015-06-14 22:26:06 +02:00
Robin Gareus
573ec69a9a probe buffersize if jackd is already running. 2015-06-14 18:10:31 +02:00
Robin Gareus
b86a8edcff NOOP, reindent code. 2015-06-13 22:05:29 +02:00
Robin Gareus
c8e16998bf fix crash on OSX displaying MIDI sysex, or similar text. 2015-06-13 22:04:31 +02:00
Paul Davis
cc543280d9 We were 2 more debug "bits" away from overflow, so recast PBD::DEBUG mechanism away from a 64bit integer and toward std::bitset.
Clean up a few minor related PBD::DEBUG issues along the way
2015-06-12 18:14:09 -04:00
Paul Davis
10643779b6 more refactoring of WaveView threaded code to try to get to heart of crash bug 2015-06-11 17:04:08 -04:00
Paul Davis
077e625734 don't queue a callback with the idle event for waveview image generation if one is already queued.
Also, hold relevant lock when waking image rendering thread.
2015-06-11 13:35:01 -04:00
Paul Davis
ceb3c38090 comment tweak 2015-06-11 13:35:01 -04:00
Robin Gareus
97de6efe5d fix transport loop sub-state events
Loading a session with a loop-range, or setting
a loop-range adds LoopDeclick events.
Normal play back (no loop) never processes/clears the events.
Ardour was constantly doing split cycles for nothing.

This lead to stuck midi-notes: Split cycle calls
increment_global_port_buffer_offset() but the midi_diskstream
itself was not aware of any loop positions or offsets.

Entering loop playback adds those events explicitly
in Session::set_play_loop(). auto_loop_changed() only
needs to add/replace session-events when actively looping.
2015-06-11 15:08:22 +02:00
Paul Davis
753d1ac392 possible fix for crashes related to vanishing waveviews (and if it doesn't fix anything, it is still more correct than it was) 2015-06-10 22:26:58 -04:00
Paul Davis
59dc0881fb remove left-over debugging code 2015-06-10 22:04:20 -04:00
Paul Davis
ac2b0a327c fix basic error with computation of partial image width; add use of DEBUG_TRACE (DEBUG::WaveView,...) 2015-06-10 18:48:12 -04:00
Paul Davis
1c6c9e95ba add PBD::DEBUG::WaveView 2015-06-10 18:48:12 -04:00
Paul Davis
9edd8d4b3b no Save-As progress dialog if we're not copying media 2015-06-10 18:48:12 -04:00
nick_m
392f48709c Magnetic snap now works on note moves / resizes. 2015-06-11 02:20:37 +10:00
nick_m
b3a4c88e0e Make absolute snap the default snap.
- also fixes a couple of absolute snap bugs wrt midi notes.
2015-06-11 01:36:34 +10:00
Robin Gareus
9563e75cca hide the aggregate device, again
further amends to 17453ec debugging.
2015-06-10 03:00:00 +02:00
Robin Gareus
df840cec13 undo debug (17453ec) info.
The problem was: OSX i386 builds used --dist-target=leopard
which forced the deprecated 10.5 CoreAudio API.
(build-host config has been changed now).

There is currently insufficient support in ardour’s
CoreAudioPCM::create_aggregate_device() for the old API,
COREAUDIO_108 needs to be defined or aggregate devices stop
working on OSX 10.8 or later.
2015-06-10 02:46:10 +02:00
Robin Gareus
aad43bce4a fix video-image request, zoom before video start. 2015-06-09 23:26:43 +02:00
Robin Gareus
9a8d5583f4 fix OSX optimized builds (NDEBUG) 2015-06-09 22:24:46 +02:00
Robin Gareus
17453ec855 debug aggregate device issue - i386/10.8 only 2015-06-09 21:34:16 +02:00
Robin Gareus
70a0ee504c coreaudio: initialize [output] variable.
possible fix for 32bit/10.8,
AudioObjectGetPropertyDataSize error
2015-06-09 19:18:59 +02:00
John Emmas
7a966c81bd Don't close OSC server sockets explicitly (the subsequent call to 'lo_server_free()' will close the socket anyway) 2015-06-09 16:25:20 +01:00
John Emmas
801af5df9e Add the new (UINTSDEFINED) preprocessor directive to all out MSVC projects (just to be on the safe side) 2015-06-09 13:18:42 +01:00
John Emmas
f33c8aeb33 Add a new preprocessor directive (UINTSDEFINED) which is rather annoyingly needed if liblo gets built with MSVC 2015-06-09 12:09:21 +01:00
John Emmas
b79c5d4f1b Add a new link library that's needed when building against the newer version of liblo (0.28)
(probably only needed when building with MSVC)
2015-06-09 12:06:49 +01:00
Paul Davis
963b56b1c6 Merge branch 'ovenwerks-master' 2015-06-08 17:22:48 -04:00
Len Ovens
72416e9432 Don't allow user to change function of modifier buttons. 2015-06-08 17:22:34 -04:00
Colin Fletcher
88b0e0cd0b Update export config on stem export select tracks/busses/none
Call update_config() after selecting/deselecting all tracks/busses so that
the warning about 'No channels have been selected' is shown/hidden
appropriately.
2015-06-08 20:07:52 +01:00
Colin Fletcher
ca9c7b169d Enclose bar code number in ""s in TOC & CUE export
cdrdao seems to want the CATALOG field to be enclosed in double-quotes.
2015-06-08 14:42:24 +01:00
Colin Fletcher
429355b0b3 Remove doubled quotes in TOC export PERFORMER field
toc_escape_text() already encloses its result in ""s, and if album_artist
is empty, the resulting PERFORMER """" line makes cdrdao upset. Just remove
the extra quotes.
2015-06-08 14:42:24 +01:00
Colin Fletcher
ecd37a5c2f Fix tiny typo in PortExportChannelSelector error text 2015-06-08 14:42:24 +01:00