Robin Gareus
9d063943bb
Fix deadlock when changing tempo
...
since dcc0f1cb17 Playlist::freeze takes a RegionWriteLock,
so freeze() must not be called with a Lock already held.
2021-05-17 21:15:58 +02:00
Robin Gareus
98721b1267
Don't count jack[2] xruns during freewheel export for now
...
Pending further investigation after the 6.7 release.
2021-05-17 04:44:53 +02:00
ElizabethHarmon
0e0327b1cd
Update export_format_dialog.cc
2021-05-16 01:04:09 +02:00
Robin Gareus
14961e6bc7
ALSA backend: code cleanup and scoping and indent
...
This is combination of clang-format and manual edits.
The latter mainly to add braces and reduce scope of variables.
2021-05-16 00:49:06 +02:00
Robin Gareus
6801c2cac2
ALSA: add option to prefer interleaved access
2021-05-15 23:10:14 +02:00
Robin Gareus
e2bac27885
Remove unused API
2021-05-15 23:09:21 +02:00
Robin Gareus
6346b54c13
Tweak Lua API, avoid translated sting as return value
2021-05-15 03:53:40 +02:00
Paul Davis
ac87409122
#ifdef code dependent on libsndfile 1.0.28
2021-05-14 19:03:52 -06:00
Paul Davis
689d33ddd5
get line for region markers functioning and visible
2021-05-14 18:37:50 -06:00
Paul Davis
4151c22802
explicit color for region marks, and default to fully opaque
2021-05-14 18:37:50 -06:00
Paul Davis
b4d7944750
place the line associated with markers in the cursor scroll group, so that it above everything else
2021-05-14 18:37:50 -06:00
Paul Davis
3c1ffd1743
add line height API to Marker
...
This will allow region markers, which do not span the whole canvas height, to have a line
2021-05-14 18:37:50 -06:00
Paul Davis
1685843082
global marker objects do not need a canvas height, so remove member and API to manage it
...
They extend (down) from an origin to COORD_MAX. The height is irrelevant
2021-05-14 18:37:50 -06:00
Paul Davis
8859f76f48
new structure/design for managing visible cue markers
2021-05-14 18:37:50 -06:00
Paul Davis
272b4f5cdc
redraw region markers after a region color change
2021-05-14 18:37:50 -06:00
Paul Davis
681b60463b
fix color and position of region markers
2021-05-14 18:37:50 -06:00
Paul Davis
822864e301
remove debug output
2021-05-14 18:37:50 -06:00
Paul Davis
ea94a045ae
update region markers after a regions bounds change (they may have moved)
2021-05-14 18:37:50 -06:00
Paul Davis
f1390ca7f7
add (theoretical) undo-ability for region markers and use source API instead of region
2021-05-14 18:37:50 -06:00
Paul Davis
82d502f67a
avoid crash in RegionView constructors, caused by accessing _region too early
2021-05-14 18:37:50 -06:00
Paul Davis
5c9626648c
extra alpha modifier for use with region markers
2021-05-14 18:37:50 -06:00
Paul Davis
738cdcc55c
tweaks to ArdourMarker to enable it to be used for RegionCue markers
2021-05-14 18:37:50 -06:00
Paul Davis
d1ee033dd2
change XML node names for cue markers to be capitalized
2021-05-14 18:37:50 -06:00
Paul Davis
7cf9e3d89d
remove Region::add_cue_marker() (force use of Source API instead)
2021-05-14 18:37:50 -06:00
Paul Davis
6dd516bc45
add non-const SourceList accessor to Region
2021-05-14 18:37:50 -06:00
Paul Davis
e3b1566534
add serialization for source cue markers
2021-05-14 18:37:50 -06:00
Paul Davis
5ab6807710
NOOP: whitespace adjustment
2021-05-14 18:37:50 -06:00
Paul Davis
a1c68460be
add basic/initial code for action to add a region marker
2021-05-14 18:37:50 -06:00
Paul Davis
2791be7f2a
add Region::add_cue_marker()
2021-05-14 18:37:50 -06:00
Paul Davis
0f406f40f7
region markers: change container type that holds Source::_cue_markers from vector to set, to avoid duplicates
2021-05-14 18:37:50 -06:00
Paul Davis
bfd00f7a52
add Source::clear_cue_markers()
2021-05-14 18:37:50 -06:00
Paul Davis
689306e2bf
add Source::CueMarkersChanged signal, and ::remove_cue_marker()
2021-05-14 18:37:50 -06:00
Paul Davis
7c9f8fcbf2
remove unused Source::SourcePropertyChanged signal
2021-05-14 18:37:50 -06:00
Paul Davis
8fc8cbf4af
tentative code to check that we can read cue markers vis libsndfile
2021-05-14 18:37:50 -06:00
Paul Davis
297760885c
add UI option to control region cue mark visibility
2021-05-14 18:37:50 -06:00
Paul Davis
56857302f4
add cue markers to RegionViews
2021-05-14 18:37:50 -06:00
Paul Davis
7e7fbf6073
give Regions an access method for Cue Markers
2021-05-14 18:37:50 -06:00
Paul Davis
39b020a3f4
expand CueMarker object to allow sorting etc.
2021-05-14 18:37:50 -06:00
Paul Davis
b3d9c9d655
give Sources a container of CueMarkers (empty by default)
2021-05-14 18:37:50 -06:00
Paul Davis
6f91e1e641
add CueMarker type
...
Might split this into a separate header if things become more complex than currently imagined
2021-05-14 18:37:50 -06:00
Ben Loftis
13c819e02b
Plugin Tags: Add a Lua-accessible function to write untagged plugins to a file so we can bulk-tag them.
...
print(ARDOUR.LuaAPI.dump_untagged_plugins())
...will write untagged plugins to a file, and report the resulting file path to the user
2021-05-14 15:08:44 -05:00
Ben Loftis
0fe68cabca
Plugin Tags: start collection of VST3 tags with Harrison AVA plugins.
2021-05-14 15:08:16 -05:00
Robin Gareus
2b7ae1a79f
Use sub-menus for > 32 processor automation parameters
2021-05-14 16:47:46 +02:00
Robin Gareus
28619fe71b
Fix window process thread priorities
...
While POSIX defines a single contiguous range of numbers that
determine a thread's priority. Win32 defines priority classes
and priority levels relative to these classes.
pthread maps those to -15 .. +15 with the top six ones
corresponding to REALTIME_PRIORITY_CLASS and max being
THREAD_PRIORITY_TIME_CRITICAL
Note that the PA backend can USE_MMCSS_THREAD_PRIORITIES
and PBD::MMCSS::set_thread_characteristics() directly for
the I/O threads.
2021-05-14 01:59:20 +02:00
Robin Gareus
4d269729b1
Fix missing entries in region-list #8701
...
RegionFactory::CheckNewRegion signal is emitted directly
after region-creation from RegionFactory::create().
At this point in time the region is not on any playlist.
This if fine for EditorSources, but the new RegionList design
only shows regions that are on the timeline.
CheckNewRegion() -> EditorRegions::add_region()
-> EditorRegions::regions_changed() ignores regions w/o playlist.
Later Playlist::add_region_internal() sets the playlist but
calls Region::clear_changes() to not send all individual changes.
So Region::RegionsPropertyChanged is not emitted either.
We need to notify the EditorRegions *after* setting the playlist.
The downside of this is that more signals than necessary are
emitted.
2021-05-14 00:27:13 +02:00
Robin Gareus
f11fadcc94
NO-OP: fix some comments that used <tab>
...
See also 19a2d384fc ASCII art must not mix tab and space.
2021-05-13 23:33:30 +02:00
Robin Gareus
b745483e1b
Fix double region freeze, stuck changes #8701
...
Thawlist::add() calls suspend_property_changes () already.
This has lead to the region remaining on frozen state.
2021-05-13 23:23:47 +02:00
Robin Gareus
6f87168492
Fix windows packaging of ardour<V>-lua.exe, unhardcode major version
2021-05-13 21:33:17 +02:00
Todd Naugle
3a3fcd0d2d
Don't crash if master fader is not avaliable.
...
If the wrong device profile is selected (ex Xtouch One) but another device
is connected (Xtouch), it is possible to have a master fader on the
device, but not in the code. This would then cause a crash when the
master fader was touched.
This just protects from a wrong configuration.
2021-05-13 12:08:09 -05:00
Edgar Aichinger
ffcf90eacb
update german translation
2021-05-13 11:02:23 -06:00