allanger/ardour
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Activity
24,348 Commits 2 Branches 0 Tags
c149d7d64c19f223565c9c0e941ff15a4ff030e7
Commit Graph

11425 Commits

Author SHA1 Message Date
Tim Mayberry
c149d7d64c Use PBD::to_string() from pbd/string_convert.h in ControlSlaveUI 
The numeric formatting is equivalent.
 2017-04-19 09:37:01 +10:00
Tim Mayberry
e15524cc64 Use PBD::to_string instead of std::ostream when setting up video server url 
To avoid issues with locales that use grouping/thousands separators.
 2017-04-19 09:36:59 +10:00
Tim Mayberry
ab30f45bba Use PBD::to_string to convert period count in EngineControl class 
The functionality is the same so might as well use it.
 2017-04-19 09:36:59 +10:00
Tim Mayberry
0739bada9e Use PBD::to_string to convert bufsize to string in EngineControl class 
string_compose uses std::ostream/stringstream which will insert thousands
separators in some locales. This was not a problem when LocaleGuard set the
global C++ locale to "C"
 2017-04-19 09:36:59 +10:00
Tim Mayberry
df2b0e33b9 Use PBD::string_to functions in VideoUtils::video_query_info 
LocaleGuard is in use so float <=> string conversions must be expected in C
locale format
 2017-04-19 09:36:59 +10:00
Tim Mayberry
e7a23eaaa8 Use snprintf instead of std::stringstream when converting color values to strings 
std::ostream/stringstream will use the current locale to determine the numeric
formatting. If the locale uses grouping then thousands separators will be
inserted in the output which produces an invalid color string in
UIConfiguration::reset_gtk_theme() and when converting colors to strings in
UIConfiguration::store_color_theme()

This has not been a problem so far because it appears that LocaleGuard does not
reset the LC_NUMERIC value for the global C++ locale. So if a LocaleGuard is
created at any time before these functions are called(even if it goes out of
scope) the numeric formatting used by std::streams will use the "C" locale
formatting facets.
 2017-04-19 09:36:59 +10:00
Tim Mayberry
71fc5b9e8b Use PBD::string_to<bool> in MidiTimeAxisView class 
As the conversion was performed with PBD::to_string
 2017-04-19 09:36:59 +10:00
Tim Mayberry
b540817b5b Use PBD::string_to<bool> in RouteTimeAxisView class 
As they were converted from bool to string using PBD::to_string
 2017-04-19 09:36:59 +10:00
Tim Mayberry
edb9868e76 Remove conditional checks that are always true in RouteTimeAxisView class 2017-04-19 09:36:59 +10:00
Tim Mayberry
8e07e4bd68 Use AxisView::get/set_gui_property API in RouteTimeAxisView class 2017-04-19 09:36:58 +10:00
Tim Mayberry
634207dd6a Use AxisView::get/set_gui_property API in MixerStrip class 2017-04-19 09:36:58 +10:00
Tim Mayberry
13d2670e96 Use AxisView::get_gui_property API in AutomationTimeAxis class 2017-04-19 09:36:58 +10:00
Tim Mayberry
de80767c8c Use AxisView::get_gui_property in AudioRegionView class 2017-04-19 09:36:58 +10:00
Tim Mayberry
2c4e801183 Use AxisView::get_gui_property API in TimeAxisView class 2017-04-19 09:36:58 +10:00
Tim Mayberry
be59503364 Use AxisView::get_gui_property API in AxisView class 2017-04-19 09:36:58 +10:00
Tim Mayberry
9d2d0ddf00 Add AxisView::get_gui_property method, use PBD::string_to<T> for string conversion 2017-04-19 09:36:58 +10:00
Tim Mayberry
66004a5036 Use PBD::to_string to convert non-string types in AxisView::set_gui_property 2017-04-19 09:36:58 +10:00
Tim Mayberry
7fdbabcd79 Let AxisView::set_gui_property perform type conversion in TimeAxisView::set_height 2017-04-19 09:36:57 +10:00
Tim Mayberry
a6d71df0d0 Use XMLNode::get_property in AudioClock class 2017-04-19 09:36:57 +10:00
Tim Mayberry
1534a2a4d1 Use XMLNode::get/set_property API in VideoTimeLine class 2017-04-19 09:36:57 +10:00
Tim Mayberry
47f1183a15 Use XMLNode::set_property API in VideoMonitor class 2017-04-19 09:36:57 +10:00
Tim Mayberry
b00b83f95a Use XMLNode::set_property API in UIConfiguration class 2017-04-19 09:36:57 +10:00
Tim Mayberry
3ba34e13b1 Use XMLNode::get/set_property API in SelectionMemento class 2017-04-19 09:36:57 +10:00
Tim Mayberry
8219e3c6ee Use XMLNode::get/set_property API in Selection class 
There were many possible value truncations occuring and some precision loss
with the double conversions.
 2017-04-19 09:36:57 +10:00
Tim Mayberry
5b97b1a191 Use XMLNode::get/set_property API in ProcessorBox and ProcessorWindowProxy classes 2017-04-19 09:36:56 +10:00
Tim Mayberry
657e32290e Use XMLNode::get/set_property API in ProcessorBox class 2017-04-19 09:36:56 +10:00
Tim Mayberry
5cd88fa050 Use XMLNode::get/set_property API in MeterBridge class 2017-04-19 09:36:56 +10:00
Tim Mayberry
4bf8f9f1a8 Use XMLNode::set_property API in LuaInstance class 
Didn't seem worth converting from XMLNode::property API to
XMLNode::get_property and there may be some ordering issues.
 2017-04-19 09:36:56 +10:00
Tim Mayberry
a2c1e79660 Use XMLNode::get/set_property API in LocationUI class 2017-04-19 09:36:56 +10:00
Tim Mayberry
7cb78301eb Use XMLNode::get/set_property API in Keyboard class 2017-04-19 09:36:56 +10:00
Tim Mayberry
5b71470449 Use XMLNode::get_property API in AutomationTimeAxis class 2017-04-19 09:36:56 +10:00
Tim Mayberry
8d90723e8c Use XMLNode::set_property API in GUIObject class 2017-04-19 09:36:56 +10:00
Tim Mayberry
0bfdab738b Use XMLNode::get/set_property in ExportVideoDialog class 2017-04-19 09:36:56 +10:00
Tim Mayberry
a8420d4b6b Use XMLNode::get/set_property API in EditorRulers class 2017-04-19 09:36:56 +10:00
Tim Mayberry
df33a6e53a Use XMLNode::get/set_property API in EditorRegions class 2017-04-19 09:36:56 +10:00
Tim Mayberry
346123e619 Use XMLNode::set_property API in ARDOUR_UI class 2017-04-19 09:36:55 +10:00
Tim Mayberry
41493d556a Use XMLNode::get/set_property API in ARDOUR_UI class 2017-04-19 09:36:55 +10:00
Tim Mayberry
dcc21b19a9 Add AudioClock::on() method as convenience method for serialization 2017-04-19 09:36:55 +10:00
Tim Mayberry
d41d612276 Use XMLNode::get/set_property API in Mixer_UI class 2017-04-19 09:36:55 +10:00
Tim Mayberry
8d6df23ebc Remove unused header include in video_timeline.cc 2017-04-19 09:36:55 +10:00
Tim Mayberry
a4b9014932 Use XMLNode::get/set_property API in Editor class 2017-04-19 09:36:55 +10:00
Tim Mayberry
800112c3b7 Use XMLNode::get/set_property API in EngineDialog class 
Fixes many of the type conversions but I doubt any would have been an issue.

LocaleGuard is no longer necessary
 2017-04-19 09:36:55 +10:00
Tim Mayberry
697f0ce5e1 Add PBD::to_string/string_to template specialisations for types in editing.h 2017-04-19 09:36:55 +10:00
Tim Mayberry
6ee1e4d6dd Add PBD::to_string/string_to template specialisations for types in enums.h 2017-04-19 09:36:55 +10:00
Tim Mayberry
2b58bbd50a Use PBD string conversion functions in PBD::ConfigurationVariable 
No longer need a specialization for bool as PBD::to_string/string_to already
has specializations for bool

Remove template specialization for float as string_to/to_string handles string
representations of infinity
 2017-04-19 09:36:47 +10:00
Tim Mayberry
cb3c564822 Use int32_t type instead of long for font-scale UI configuration variable 
long type can not be used with PBD::to_string/string_to
 2017-04-19 09:36:47 +10:00
Tim Mayberry
3edb6b2e1f Use PBD string conversion functions in PBD::Property class 2017-04-19 09:36:47 +10:00
Tim Mayberry
fda05ac64b Use ID::to_s() in gtk2_ardour instead of ID::print() 2017-04-19 07:49:58 +10:00
Robin Gareus
18dcd4d7ff FP8: Configuration UI layout & design (add image, separators) 2017-04-15 15:19:58 +02:00
cooltehno
57dfc0ffb1 Update blueberry_milk-ardour.colors 2017-04-14 13:22:18 -07:00