Commit Graph

18398 Commits

Author SHA1 Message Date
Robin Gareus
4e78f25149 Don't update bottom attachment when it's not visible 2025-08-24 15:09:08 +02:00
Robin Gareus
32325e84d7 Allow clearing RoutePropertiesBox 2025-08-24 15:09:08 +02:00
Robin Gareus
cca8de9d6c Make keyboard shortcuts work in RTA Window 2025-08-24 15:09:08 +02:00
Paul Davis
e684fb4eaf use Session::request_locate() fully, to avoid 2nd session transport request 2025-08-23 22:35:16 -06:00
Paul Davis
12aeeade3c make pianoroll update happen on same timer as main editor playhead 2025-08-23 22:35:16 -06:00
Paul Davis
d20987aba4 get playhead on timeline and in pianorolls to be in sync
We have to convert from audible sample to beats using the global tempo map, then
back to samples using the local tempo map
2025-08-23 22:35:16 -06:00
Daniel Appelt
7fa17f50da Add support to set color transparency from Lua 2025-08-24 00:58:20 +02:00
Daniel Appelt
26c9621aca Add support to create midi regions from Lua 2025-08-23 21:49:48 +02:00
Robin Gareus
45724aec9d Expose preference to disable implicit grouping 2025-08-23 10:07:05 +02:00
Robin Gareus
a6b07256aa Fix expanding application bar
`on_parent_changed()` which does the layout is
called before ui_actions_ready(). This caused to Lua buttons
to briefly be displayed.
2025-08-22 15:47:52 +02:00
Paul Davis
07b20aa60a kbd automation: no popup immediately after add, 2nd Return/Enter for that
Also, two different bindings for adding a point with and without guard points.
2025-08-21 18:56:00 -06:00
Robin Gareus
fe731cb9ab Add shortcut for spectrum analyzer window 2025-08-22 00:19:12 +02:00
Robin Gareus
b933e7f1b4 Fix previous commit 2025-08-21 22:36:37 +02:00
Robin Gareus
4926f673bd Fix crash when setting up toolbar without session (sync button) 2025-08-21 22:32:24 +02:00
Paul Davis
25cc456c73 tweaks to the presentation of drag sensitivity in preferences 2025-08-21 07:40:56 -06:00
Paul Davis
56d36d3a41 fix initialization order warning for RegionUISettings 2025-08-20 17:43:56 -06:00
Paul Davis
c0fa42a203 EditingContext: don't call drop_action_group() if an action group was not created
Example would be an audio clip editor that does not define MIDI actions
2025-08-20 14:53:49 -06:00
Robin Gareus
d8c10a96bd Amend c6a49fdd50 drop automation actions
This fixes a crash when showing the same Pianoroll again,
since actions a already present, a NULL reference was pushed
to session_sensitive_actions. Closing a session then crashed
accessing a NULL Action.
2025-08-20 22:25:58 +02:00
Robin Gareus
293100850b Remove another debug message 2025-08-20 22:09:45 +02:00
Robin Gareus
aba8595342 Don't re-create MIDI Region Editor when it already exists 2025-08-20 22:01:03 +02:00
Robin Gareus
4b88330c9c Use main editor for loop-range undo/redo - fix crash
While CueEditor is-a HistoryOwner, session specific
changes such as Location don't belong in EditingContext.

This fixes a heap-use-after-free crash since MementoCommand
was free()ed twice. Once via ARDOUR::Location::~Location
and earlier due to direct Destructible::drop_references
from the History.

This partially reverts 04a8fb1eb6
2025-08-20 21:32:22 +02:00
Robin Gareus
4cd241fab7 Towards clean exit 2025-08-20 16:19:25 +02:00
Paul Davis
2563eb2e1d remove some debug output 2025-08-20 07:04:54 -06:00
Robin Gareus
6589fdf9e8 Always clean up after ourselves.. 2025-08-20 13:28:08 +02:00
Robin Gareus
82dc2a9e54 Add "note" to short grid labels
see also d2512c814a
2025-08-20 13:05:22 +02:00
Robin Gareus
b0af872de2 Add "clear" button to RTA Window 2025-08-20 13:05:21 +02:00
Robin Gareus
ac9ffefb94 Add RTA clear feature 2025-08-20 13:05:18 +02:00
Paul Davis
20ebcc408d fix type from b489d466cf that resensitized the ghost note, causing crashes
Oddly, much, much easier to make happen on macOS and/or mixbus
2025-08-19 23:29:58 -06:00
Paul Davis
1e2a2d5506 remove infinitely recursive, never-called method from MidiView 2025-08-19 23:29:58 -06:00
Paul Davis
b0eafc7a7c update preferences metadata (source text and C++ code) 2025-08-19 13:40:13 -06:00
Paul Davis
20701362c3 also scale drag move threshold by UI scale
If UI scale is > 1, pixels are likely small, so it seems appropriate to scale
2025-08-19 12:09:12 -06:00
Paul Davis
86da6740cb expose drag sensitivity in preferences 2025-08-19 12:09:12 -06:00
Paul Davis
d316a4b1c3 scale move threshold by UIConfiguration parameter 2025-08-19 12:09:12 -06:00
Paul Davis
99585debbe change use of MoveThreshold.first to reflect pixel units 2025-08-19 12:09:12 -06:00
Paul Davis
fc08397ad8 use both relevant UIConfiguration parameters in ::move_threshold() 2025-08-19 12:09:12 -06:00
Paul Davis
059497ea3d add move threshold sensitivity parameter for UI 2025-08-19 12:09:12 -06:00
Paul Davis
1efd0c06bd move threshold for drags goes back to pair<int,int>
And for now, there's only a single implementation, though other types of
drags could implement it if needed. There really seems to be no need.

Note that the x-axis threshold is 3x in the case of a copy-drag.
2025-08-19 12:09:12 -06:00
Paul Davis
f34e314d93 move _copy member of some types of drags into Drag base class
this allows us to use it when computing move thresholds
2025-08-19 12:09:12 -06:00
Paul Davis
ee6356d9df remove crashing assert() when rendering scroomer
Too hard to get a floating point assert correct, but I think this is still a little
incorrect because we do not scale the kbd size when rendering it.
2025-08-19 10:53:06 -06:00
Paul Davis
66dde32a1b no more BBT_Time round/round_up methods (GUI edition) 2025-08-19 10:53:06 -06:00
Robin Gareus
d2512c814a Use short labels for grid and beat-div dropdown 2025-08-19 18:24:22 +02:00
Robin Gareus
e74dbf6ef7 Pianoroll: the return of the draw box (amend 8ffd45c3c) 2025-08-19 15:36:44 +02:00
Robin Gareus
8ffd45c3c0 Don't expand GUI as much on first load
The editor-toolbar still needs a major cleanup, it's
very busy
2025-08-19 15:25:24 +02:00
Robin Gareus
44ceb91e52 Use new YTKMM API instead of ytk+ 2025-08-19 14:40:49 +02:00
Robin Gareus
07dc5c0fc0 Remove cruft 2025-08-19 14:04:13 +02:00
Robin Gareus
936f8734b4 Tweak editor bottom pane packing, never unpack the property box 2025-08-19 14:03:19 +02:00
Robin Gareus
f9cdaf698c Never unpack the selection-property-box
This is used to for all selection: route, plugins,
time and region and slot selection.

Only re-pack it with different expand option when
the pianoroll is also visible
2025-08-19 13:28:51 +02:00
Robin Gareus
014d231d13 Fix preference enum - see 4826a90796 2025-08-19 04:48:45 +02:00
Robin Gareus
32f162ec9a Fix invalid markup (scene name) 2025-08-19 03:24:20 +02:00
Paul Davis
4826a90796 prefs editing widgets for region-edit-disposition 2025-08-18 19:04:05 -06:00