Commit Graph

33959 Commits

Author SHA1 Message Date
Ben Loftis
f9192decbf triggerbox: workaround for CheckMenuItems that fire the action when we set the display state 2021-12-17 13:09:49 -06:00
Ben Loftis
243ddae928 triggerbox: implement trigger gain as a save-able property (libardour) 2021-12-17 13:09:49 -06:00
Ben Loftis
dd7f474125 triggerbox: scene-isolate property for triggers (libardour part) 2021-12-17 13:09:49 -06:00
Ben Loftis
9aa6e4c89e triggerbox: highlight stop-button (empty triggers) on entry 2021-12-17 13:09:49 -06:00
Ben Loftis
c734957aaa triggerbox: loop count should be 1-based 2021-12-17 13:00:17 -06:00
Paul Davis
d5e13f093f triggerboxui: explicitly disconnect from update/selection signals
sigc::connection is not scoped, so disconnection is not automation
2021-12-17 09:54:43 -07:00
Paul Davis
c58a2a5749 video monitor: no need to test sigc::connection for connected() before disconnecting 2021-12-17 09:54:10 -07:00
Robin Gareus
ec04ab3865 Fix Triggerbox mono to stereo playback 2021-12-17 17:50:50 +01:00
Robin Gareus
0dad657c89 Amend previous commit 2021-12-17 17:48:27 +01:00
Robin Gareus
0e930ae5f4 Re-add another explicit sigc::disconnect
Apparently signals are not disconnected when the connection
is destroyed.
2021-12-17 17:28:32 +01:00
Robin Gareus
8b5711238e Mysterious fix crash on selection
This was removed in 422ad6656d since disconnecting
sigc::connection in the d'tor is not supposed to be a no-op.
2021-12-17 17:11:48 +01:00
Robin Gareus
422ad6656d Re-do source-code cleanup and formatting
Some of this was lost in 26df9ccdf8
This also removes some excess code
2021-12-17 16:53:16 +01:00
Robin Gareus
49b1eb401d Yet more code cleaning and formatting 2021-12-17 16:21:33 +01:00
Ben Loftis
26df9ccdf8 pixel pushing: return of drop-shadows (maybe) 2021-12-17 08:55:30 -06:00
Robin Gareus
27ba2c7ea6 Cleanup and clang-format source 2021-12-17 15:30:14 +01:00
Robin Gareus
6e3ed7f822 Clean up trigger-page layout
* move strip name-button to the top
* only manage() Gtk Widgets, not Canvas Items
* use identical layout for Cue and Strip
2021-12-17 14:51:19 +01:00
Robin Gareus
cf41055f7c Disambiguate another Rect (fixes macOS builds)
/usr/include/MacTypes.h:550:41: note: candidate found by name lookup is 'Rect'
libs/canvas/canvas/canvas.h:57:8: note: candidate found by name lookup is 'ArdourCanvas::Rect'
2021-12-17 12:07:45 +01:00
Paul Davis
b4c98f10e8 tweak towards getting handling of trigger_display in MixerStrip correct 2021-12-16 22:52:56 -07:00
Robin Gareus
d59a1944fe Tweak trigger/clip media browser layout 2021-12-17 03:57:17 +01:00
Paul Davis
50b5ba51bf Revert "fix initial (and only) ::show() calls for triggerbox and trigger master widgets"
This was wrong. Busses do not have triggerboxen (at this time).

This reverts commit 8ebf91ae14.
2021-12-16 18:59:48 -07:00
Paul Davis
8ebf91ae14 fix initial (and only) ::show() calls for triggerbox and trigger master widgets 2021-12-16 18:55:40 -07:00
Paul Davis
4c8559ecdf fix redisplay/reset of triggerbox ui as part of set_route() 2021-12-16 18:55:05 -07:00
Paul Davis
de6178093e allow FittedCanvasWidget to have it's root first child replaced 2021-12-16 18:54:32 -07:00
Robin Gareus
5ad5603f1e Unset CueMaster session-handle on session close 2021-12-17 00:42:07 +01:00
Robin Gareus
e3be6836ca Trigger-clip-picker audition 2021-12-17 00:42:06 +01:00
Robin Gareus
95aad0dc15 Disambiguate Rect(angle) -- fixes Windows and macOS builds 2021-12-17 00:42:06 +01:00
Paul Davis
8193d579de trigger master widget visibility now also visibility group controlled 2021-12-16 15:53:49 -07:00
Paul Davis
81ebe47fdd triggerbox: some initial fixups for always-there trigger display 2021-12-16 15:45:46 -07:00
Paul Davis
6a0b720d8f convert trigger display into a permanent, VisibilityGroup-controlled element of MixerStrip
Likely to be soem SNAFUs to find
2021-12-16 15:30:25 -07:00
Paul Davis
d933af6c81 attach triggerbox to triggerbox widget after construction 2021-12-16 15:15:14 -07:00
Paul Davis
1e09a12642 remove TriggerBoxWindow API (not used) 2021-12-16 15:09:20 -07:00
Robin Gareus
9fd0b20b2a Towards a proper media/clip-browser 2021-12-16 19:08:04 +01:00
Robin Gareus
6b6ae5dedb Fix file-extension check
If the extension is not found, string::rfind() returns -1,
That can still match unrelated file if the file-name is one
char longer than an arbitrary extension.

eg. "foo" matched ".aiff" because
-1 = strlen("foo") - strlen(".aiff")

Also due to a missing comma ".VOC.vwe" matched any file shorter
than 7 chars in length.
2021-12-16 19:08:03 +01:00
Robin Gareus
9f7114f761 Add dir names for media-folder 2021-12-16 19:08:03 +01:00
Robin Gareus
ddc03bbc5e Bundle some media-files 2021-12-16 19:08:03 +01:00
Paul Davis
21ed6a2626 add Config variable for trigger enable 2021-12-16 10:39:43 -07:00
Paul Davis
f7792cb425 triggerbox: fix typo that caused crash when handling unstretched audio 2021-12-16 10:39:43 -07:00
Paul Davis
39d9c39452 remove redundant double-add of "solo-selection" to session-sensitive-actions 2021-12-16 10:39:43 -07:00
Ben Loftis
f4009e0e09 triggerbox: display pass_thru state and allow control via context menu 2021-12-16 10:53:30 -06:00
Ben Loftis
ce40f82cc4 triggerbox: add TriggerMaster widget to mixer strip 2021-12-16 10:40:16 -06:00
Paul Davis
899c217511 triggerbox: fix passthru handling and default to off 2021-12-16 09:31:12 -07:00
Ben Loftis
9593cb97d1 triggerbox gui: replace stop-button with Loopster progress-indicator 2021-12-16 08:15:29 -06:00
Ben Loftis
f8432d0647 Triggerbox: these properties will not be stored in Region (reverts 3918ee) 2021-12-16 08:15:29 -06:00
Robin Gareus
fc0dfd5d38 Wreturn-type, fixes unconfigured processors 2021-12-16 14:47:10 +01:00
Robin Gareus
1bf8f9bd0e Remove 'l', 'i', 'b', 'p', 't', 'f', 'o', 'r', 'm', 'a', 't'
This fixes obj.use += 'libptformat' vs. obj.use += [ 'libptformat' ]
however the latter is already added unconditionally.
2021-12-16 04:09:25 +01:00
Ben Loftis
07d5b16e6f more missing files 2021-12-15 20:48:10 -06:00
Ben Loftis
1812769f84 add missing files 2021-12-15 19:27:43 -06:00
Paul Davis
8a58155dcf triggerbox: use Session::import_files() to load from file
This uses the SRC infrastructure set up for normal imports, which
is desirable.
2021-12-15 18:19:20 -07:00
Paul Davis
02eb39325f triggerbox: fix channel handling for audio
We do not modify the audio I/O of the parent route, and process
at most std::min (route_inputs,region_channels).
2021-12-15 18:19:20 -07:00
Ben Loftis
a15397f746 triggerbox: new trigger_property widgets, because trigger data != a region 2021-12-15 18:08:22 -06:00