Commit Graph

13304 Commits

Author SHA1 Message Date
Edgar Aichinger
eb5a41e3a3 Fix typos in the GUI in preparation for translations 2020-04-13 16:10:07 +02:00
Len Ovens
3a39254338 Changing Foldback bus with show sends enabled broken
leaves mixer in fanout to old bus
	turn show sends off
	change bus
	turn show sends on for user expected result
2020-04-12 18:41:06 -07:00
Johannes Mueller
0f806d1322 Same as 97e07f4, only for MidiStreamview, duh 2020-04-13 02:28:35 +02:00
Johannes Mueller
97e07f4f4c Fix for #8005: Remove rec_box also when transport stopping.
Under some circumstances the transport FSM is still in stopping state when
::non_realtime_stop() already emits TransportStatechange. In that case the rec
boxes are not removed if we consider transport stopping == rolling.
2020-04-13 02:05:36 +02:00
Robin Gareus
6df03b2f1f Reset track header meters - e1a9034a0e #7465 2020-04-12 21:01:01 +02:00
Paul Davis
5a0e0a41e2 update all *.po files 2020-04-12 09:00:32 -06:00
Paul Davis
08d7a8ac3a when binding a key, if it is already bound, offer to replace the existing binding
Telling the user to that first was a bit ... silly.
2020-04-12 08:57:59 -06:00
Robin Gareus
134b2162ba Fix waveform update when channel-count changes
7434478a35 introduced a race, IOchange triggers updating the
GUI and re-configuring processors. The latter needs to complete
first, otherwise Track::n_channels() returns the previous
channel count.
2020-04-12 13:45:45 +02:00
Robin Gareus
e1a9034a0e Synchronize meter-reset #7465
Queue reset to be handled when the meter is updated.
Also only call set_name(), set_active_state() when the
state changes.
2020-04-10 23:50:10 +02:00
Robin Gareus
a2f7abc70b Continue to load session after MIDI latency calibration
This amends e6febe040a
2020-04-10 01:43:11 +02:00
Robin Gareus
e6febe040a Continue to load session after latency calibration #7998 2020-04-09 23:31:45 +02:00
Paul Davis
ca022f6bb7 show transport master ports in their own "Sync" bundle in the global port matrices 2020-04-09 14:01:47 -06:00
Paul Davis
980a38a988 still show port names in bundles with only a single port a given type
The bundle name is typically insufficient to identify the port
2020-04-09 14:01:47 -06:00
Robin Gareus
7434478a35 Update Waveform display when channel-count changes 2020-04-08 17:40:32 +02:00
Robin Gareus
f7abab11a3 Add preference to reset x-run counter on rec-start #6706 2020-04-07 23:52:16 +02:00
Robin Gareus
1eb98316a3 Rename KeyboardLayout to PianoKeyBindings
This is to prevent polluting the global namespace with a
symbol name that is likely to cause conflicts.
2020-04-07 18:40:04 +02:00
Robin Gareus
d4d57c844f Styleguide #12 avoid get_ for accessors 2020-04-07 18:30:34 +02:00
Nil Geisweiller
7ffaae77a7 Rename KeyboardLayout::set_keyboard_layout to set_layout
Since the class indicates that it is a keyboard layout, no need to over
load the name with it.
2020-04-07 18:26:45 +02:00
Nil Geisweiller
104d37e5a2 Move keyboard layout in its own class 2020-04-07 18:26:45 +02:00
Robin Gareus
3cd2ad85af Fix restoring custom MIDNAM #7984 2020-04-07 14:16:53 +02:00
Robin Gareus
eeb62c99fb Fix typo in API name (2/2) 2020-04-07 04:07:34 +02:00
Robin Gareus
2991d74da5 GUI: follow LatencyUpdated signal handler, prevent duplicate updates 2020-04-07 00:14:09 +02:00
Robin Gareus
21b2ffbae6 Indicate ambiguous latency in the GUI 2020-04-07 00:09:38 +02:00
Robin Gareus
fbc48bdf34 Fix end vs. length bug when creating regions - #7978
set_length() includes the end.
A Region starting at 0 and ending at 0, has a length of 1
(think counting fence-posts, or video-frames).
2020-04-05 20:24:11 +02:00
Robin Gareus
14a2a50e93 Simplify snap-to magnetic distance calc 2020-04-05 20:24:11 +02:00
Robin Gareus
6b9bdbf0ff NO-OP: cleanup snap-to code, mostly whitespace 2020-04-05 20:24:11 +02:00
Johannes Mueller
605b3d83a8 Fix #7971: Adjust paths of template archive entries exported on MacOS
... on Ardour5.

On MacOS g_dir_make_tmp() does not return the canonical path. Thus, exported
template archives end up with wrong entry paths. This has been fixed by
e52bdc55ad for exporting templates. However, template archives that have been
exported on Ardour5 are not affected by the fix. Therefor we need a workaround
for the case we are importing legacy template archives from Ardour5.
2020-04-05 16:34:48 +02:00
Robin Gareus
419af82645 Revert "replace use of gdk_pixmap_unref() with g_object_unref"
This reverts commit fdf0db02a0.

Even though `gdk_pixmap_unref` is deprecated, it is the correct way
to free `gdk_pixmap_new` objects.
This fixes a memory leak and glib warning:
GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

PS. Eventually this pixmap should be replaced by a cairo surface.
2020-04-05 00:59:54 +02:00
Robin Gareus
e52bdc55ad Fix template export on MacOS
By default Apple uses a private TMP folder.

g_dir_make_tmp() returns `/var/folders/...` while the real
absolute path is `/private/var/folders/...`.
This caused a problem when the tmp-prefix is chopped off when building
the archive.
2020-04-05 00:10:41 +02:00
Ben Loftis
bb925ea151 Editor-mixer-strip: fix intermittent crash if we try to set up gui before set_route() is called (amends d2032d) 2020-04-04 12:03:45 -05:00
Ben Loftis
d2032df2e5 Fix for Editor-mixer-strip: polarity buttons were not updating with route selection changes. 2020-04-04 10:54:33 -05:00
Paul Davis
0ecf1e40ea add Editor-level action to toggle track layer display 2020-04-03 18:54:51 -06:00
Paul Davis
c2b026831c yes, RouteTimeAxisView::set_layer_display() really never applies to the selection 2020-04-03 18:54:51 -06:00
Paul Davis
743fbaf7bf change implementation of layer display menu items and handlers
The menu items no longer ever apply to the selection, because there will be an Editor-level
action to change things "globally"
2020-04-03 18:54:51 -06:00
Paul Davis
d1e55ff5b7 add RouteTimeAxis::toggle_layer_display() 2020-04-03 18:54:51 -06:00
Paul Davis
1c53e73599 add two new ptr-to-menu-item, and remove an unused one, for RouteTimeAxis 2020-04-03 18:54:51 -06:00
Paul Davis
ac6bd95e3a move automation menu to under View in main menu 2020-04-03 18:54:51 -06:00
Robin Gareus
a6d1890168 NO-OP: whitespace 2020-04-04 01:48:31 +02:00
Robin Gareus
4e005540c6 Update PatchChange when instrument/midnam changes 2020-04-04 01:48:30 +02:00
Paul Davis
096d23fcc2 change text describing relayout after UI scaling change 2020-04-03 14:31:51 -06:00
Paul Davis
8a1f1a3005 remove border around ATAV controls table (looks better with new theme) 2020-04-03 14:25:32 -06:00
Paul Davis
626d97b13a a better solution for automation axis name labels 2020-04-03 14:25:13 -06:00
Paul Davis
be2322ef2b set size request for automation lane name label, to prevent it from changing tracker header width 2020-04-03 14:11:14 -06:00
Paul Davis
f26dd1f13d add automation item to top level edit menu 2020-04-03 13:28:58 -06:00
Paul Davis
9ca9aa8ae1 add new Editor method to toggle all existing automation
Applies to selected tracks if non-empty; all tracks otherwise
2020-04-03 13:28:58 -06:00
Paul Davis
97d1ee9822 move templated foreach methods from TrackSelection into parent (TrackViewList)
This allows the same methods to be used on e.g. Editor::track_views
2020-04-03 13:28:58 -06:00
Paul Davis
e954303fec move automation show/hide methods into public access
Note that they are still intended to be called via a specific mechanism from Editor, not
directly.

Also remove unnecessary duplicate virtual decls
2020-04-03 13:28:58 -06:00
Robin Gareus
71ab4614f8 Fix fan-out port connection race-condition
This directly creates tracks without auto-connect.
2020-04-03 15:37:49 +02:00
Robin Gareus
11f28a4b1d NO-OP: cleanup and remove debug messages 2020-04-03 14:49:03 +02:00
Robin Gareus
714e2f1736 Optimize MTAV creation, speed up new MIDI track
This removes various duplicate code-paths leading to midi-model
updates, and expensive context-menu rebuilds. This significantly
speeds up MIDI track creation.
2020-04-03 03:42:56 +02:00