652a2aa3ac
The libsndfile format was masked with 0xf instead of the usual SF_FORMAT_SUBMASK. It seems like the end result generally was correct anyway, since no supported format used subtypes that used the low bits for anything else. Most formats use SF_FORMAT_PCM subtypes. (Only Ogg Vorbis uses a subtype, but that happens to have 0 in the low bits and ended up in the "this will never happen branch" ... which happened to work too.) This could however be a real problem when SF_FORMAT_MPEG_LAYER_III with value 0x82 is supported ... unless worked around in some way. I don't see anything anywhere that could stuff anything in the high bits of the subtype, so this trivially fixed by using SF_FORMAT_SUBMASK correctly.
Please see the Ardour web site at https://ardour.org/ for all documentation..
For information on building ardour:
https://ardour.org/development.html