Commit Graph

40032 Commits

Author SHA1 Message Date
Robin Gareus
9f6d3baa93 Use key bindings for region property (Fx) box
This is required to allow to delete RegionFX plugins
when the region-editor is shown in the main window, rather
than its own window.

Otherwise the Editor would handle delete/backspace and
instead remove the region.
2024-11-23 16:35:10 +01:00
Ben Loftis
23ba0f8338 fix for 'green' canvas redraws: cairo expects x,y,w,h not x,y,x+,y+ 2024-11-23 08:43:44 -06:00
Robin Gareus
e701bee270 Fix small typo in build script 2024-11-23 10:56:16 +01:00
Robin Gareus
d28a13c9cc Make route selections idempotent 2024-11-23 10:56:16 +01:00
Robin Gareus
98d8455098 Fix crash when selecting VCA 2024-11-23 10:56:16 +01:00
Paul Davis
9ab42f8d14 fix error in hastily introduced DEBUG_TRACE statement 2024-11-22 09:34:45 -07:00
Paul Davis
d5cc1b5efc initial steps to trigger start/end point display and editing 2024-11-22 09:33:38 -07:00
Paul Davis
a162250682 fix MIDI triggers where region start/end are not the source start/end 2024-11-22 09:33:38 -07:00
Robin Gareus
4e55570934 mac: mitigate "device busy" chances when ejecting DMG 2024-11-22 16:23:03 +01:00
Paul Davis
4fbdf0d680 macOS: catch spurious full redraw calls to NSView:drawRect and act appropriately 2024-11-21 14:07:31 -07:00
Robin Gareus
04fe2b5aa8 Push default cursor at the top of the stack
see also f598f4e4e0
2024-11-20 19:01:22 +01:00
Robin Gareus
940e1bc2df NO-OP: rename layout widgets for clarity 2024-11-20 18:56:20 +01:00
Robin Gareus
218b264c60 Use evenbox as parent for main window content
This fixes an issue with mouse-cursor contexts.
Eventbox is backed by a [gdk] window, each of which
has their own Gdk::Window::set_cursor.
2024-11-20 18:42:38 +01:00
Paul Davis
fc91c7b92d prevent canvas piano roll header scroomer drag pushing the same cursor over and over 2024-11-19 16:31:55 -07:00
Paul Davis
28e638deac undo a change the broke cursor management
push push pop pop must always work, even if the two pushes are for the same cursor
2024-11-19 16:31:36 -07:00
Paul Davis
f598f4e4e0 potential fixes for SNAFU with cursors 2024-11-19 16:04:41 -07:00
Robin Gareus
4a99026cc9 Revert "Replace boost::aligned_storage with alignas std::array"
This reverts commit 32ff87f7f6.

This causes issues on macOS/clang
```
../libs/pbd/pbd/stack_allocator.h:152:53: note: destructor of 'StackAllocator<std::__tree_node<std::__value_type<ARDOUR::DataType, std::map<unsigned int, unsigned int, std::less<unsigned int>, PBD::StackAllocator<std::pair<const unsigned int, unsigned int>, 16>>>, void *>, 2>' is implicitly deleted because field '_buf' has a deleted destructor
  152 |         alignas(16) std::array<value_type, stack_capacity> _buf;
```
2024-11-19 18:03:23 +01:00
Robin Gareus
2a620c64e9 Show plugin UIs in Route Property Box 2024-11-19 17:45:29 +01:00
Robin Gareus
49c7464b9c Allow to move (cut/paste DnD) region FX
This also prevents copying effects to another RegionFX
Box of the same region (e.g. when using Region Property
Bottom Pane)
2024-11-19 17:45:26 +01:00
Robin Gareus
d8a197a63f Implement Editor Region Properties 2024-11-19 17:45:21 +01:00
Robin Gareus
00f3ce2e76 Remove unused property boxes, prepare for Region Editor
Using that old template code would introduce significant
tech-dept.

This also properly initializes the selection property box
and handles edge cases during session setup and deletion.
2024-11-19 17:41:55 +01:00
Robin Gareus
c35fa54b3f Refactor RegionEditor to be a Widget 2024-11-19 17:37:12 +01:00
Robin Gareus
3c5681b2c9 Add option to only show controls in generic plugin UI
The intention here is to show a minimal UI in the
Route Property Box
2024-11-19 17:37:06 +01:00
Robin Gareus
4a966d5015 DndVBox: implement drag-refuse and drag move action 2024-11-19 17:36:53 +01:00
Alejandro Domínguez
4687a5a886 Use std::placeholders by default 2024-11-18 19:05:14 +01:00
Alejandro Domínguez
fa57d5ed86 Disambiguate std and boost placeholder 2024-11-17 20:20:23 +01:00
Alejandro Domínguez
27c6276ff8 Replace boost::bind with std::bind 2024-11-17 20:19:43 +01:00
Robin Gareus
09eeca09a9 Remove unused includes 2024-11-17 20:08:14 +01:00
Alejandro Domínguez
32ff87f7f6 Replace boost::aligned_storage with alignas std::array 2024-11-17 18:43:08 +01:00
Robin Gareus
5aaec05429 Add Latch Automation for MCP
see https://discourse.ardour.org/t/cannot-activate-latch-automation-state-via-x-touch-in-mackie-mode/110969
2024-11-16 22:17:29 +01:00
Robin Gareus
3625c28d54 Remove ambiguous enum bit combinations 2024-11-16 19:39:20 +01:00
Robin Gareus
27ccb1c9d3 Be explicit about resizable Pane vs fixed size Attachment 2024-11-16 19:38:59 +01:00
Robin Gareus
1c5117444f Replace custom TriggerUI pane with Tabbable pane 2024-11-16 19:31:28 +01:00
Robin Gareus
983466fc38 Flexible Layout, resizable bottom pane. 2024-11-16 19:30:04 +01:00
Robin Gareus
438a514c2b NO-OP: clarify Tabbable layout and attachment enum 2024-11-15 14:10:56 +01:00
Robin Gareus
0b933127e9 Use new Tabbable API 2024-11-15 04:40:39 +01:00
Robin Gareus
5c8bd6e977 Tweak Tabbable Layout
* allow for left side resizable pane
* automatically set attachment button sensitivity
* remove right-side pane box when unused
2024-11-15 04:38:43 +01:00
Robin Gareus
6f331be7ca Remove deprecated 32C define 2024-11-15 03:54:17 +01:00
Robin Gareus
c6044f226c Remove unused function 2024-11-14 07:06:05 +01:00
Robin Gareus
da0f1728ed Fix External Sync Toggle Button 2024-11-14 07:05:58 +01:00
Robin Gareus
a53b99b307 Introduction of route property boxen and editor properties pane 2024-11-13 04:27:41 +01:00
Ben Loftis
9b64f64546 store and recall the Editor visibility for the bottom panel 2024-11-13 04:19:47 +01:00
Paul Davis
48ed5be776 skeleton for clip start/end editing 2024-11-12 18:54:41 -07:00
Paul Davis
e7b10fc37d virtualize editing connections to parameter changes 2024-11-12 10:47:08 -07:00
Paul Davis
677a6764ac add new buttons to EditingContext; use them in MidiCueEditor 2024-11-12 09:49:59 -07:00
Paul Davis
d3272a6400 midi cue editor: don't allocate space for automation till asked to do so 2024-11-12 08:51:29 -07:00
Paul Davis
0622f26b2a redesign cue editor layout to use ArdourButton and GtkBoxen 2024-11-12 08:12:16 -07:00
Paul Davis
a1dd7ae4c3 remove unused member variable
this was a solution to a problem eventually solved a different way
2024-11-11 22:06:05 -07:00
Paul Davis
5dd65171c1 remove unused variable decl 2024-11-11 22:01:32 -07:00
Paul Davis
47db75b0d6 cleanup some aspects of midicue editor playhead behavior 2024-11-11 21:49:55 -07:00