Better bullet traces and raycast for hitscan

scenes/weapon/bullet.gd

@@ -2,8 +2,9 @@ extends Node3D
 
 const SPEED = 715
 
-@onready var mesh = $MeshInstance3D
-@onready var ray = $RayCast3D
+@onready var mesh = $RigidBody3D/MeshInstance3D
+@onready var rigid_body_3d: RigidBody3D = $RigidBody3D
+@onready var ray = $RigidBody3D/RayCast3D
 @onready var particles = $GPUParticles3D
 
 # Called when the node enters the scene tree for the first time.
@@ -14,11 +15,15 @@ func _ready() -> void:
 # Called every frame. 'delta' is the elapsed time since the previous frame.
 func _process(delta):
 	position += transform.basis * Vector3(0, 0, SPEED) * delta
-	ray.collision_mask = 1
-	ray.enabled = 1
+	rigid_body_3d.set_use_continuous_collision_detection(true)
+	#ray.collision_mask = 1
+	#ray.enabled = 1
+	ray.target_position.z = SPEED / Engine.get_frames_per_second()    
 	if ray.is_colliding():
-		mesh.visible = false
+		rigid_body_3d.visible = false
 		particles.emitting = true
+		#if ray.get_collider().is_in_group("body"):
+			#print("head")
 		await get_tree().create_timer(1.0).timeout
 		queue_free()
 

scenes/weapon/bullet.tscn

@@ -1,4 +1,4 @@
-[gd_scene load_steps=7 format=3 uid="uid://b0agqeg53tey5"]
+[gd_scene load_steps=8 format=3 uid="uid://b0agqeg53tey5"]
 
 [ext_resource type="Script" path="res://scenes/weapon/bullet.gd" id="1_th28m"]
 
@@ -8,6 +8,10 @@ size = Vector3(0.2, 0.2, 0.5)
 [sub_resource type="StandardMaterial3D" id="StandardMaterial3D_p8o05"]
 albedo_color = Color(0.894987, 0.000702324, 0.905119, 1)
 
+[sub_resource type="CylinderShape3D" id="CylinderShape3D_l3sdq"]
+height = 0.3
+radius = 0.08
+
 [sub_resource type="StandardMaterial3D" id="StandardMaterial3D_ynv38"]
 albedo_color = Color(0.929412, 0, 0, 1)
 emission_enabled = true
@@ -27,33 +31,42 @@ linear_accel_max = 6.67
 size = Vector3(0.05, 0.05, 0.05)
 
 [node name="Bullet" type="Node3D"]
-visible = false
 script = ExtResource("1_th28m")
 
-[node name="MeshInstance3D" type="MeshInstance3D" parent="."]
+[node name="RigidBody3D" type="RigidBody3D" parent="."]
+mass = 0.01
+continuous_cd = true
+
+[node name="MeshInstance3D" type="MeshInstance3D" parent="RigidBody3D"]
 transform = Transform3D(0.663102, 0, 0, 0, 0.601826, 0, 0, 0, 0.58984, 0, 0, 0)
 mesh = SubResource("BoxMesh_vxst2")
+skeleton = NodePath("../..")
 surface_material_override/0 = SubResource("StandardMaterial3D_p8o05")
 
-[node name="RayCast3D" type="RayCast3D" parent="."]
-transform = Transform3D(1, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, -0.100459)
-target_position = Vector3(0, 0, -0.5)
+[node name="RayCast3D" type="RayCast3D" parent="RigidBody3D" groups=["body"]]
+exclude_parent = false
+target_position = Vector3(0, 0, 2)
 hit_back_faces = false
 collide_with_areas = true
 
+[node name="Timer" type="Timer" parent="RigidBody3D"]
+wait_time = 10.0
+one_shot = true
+autostart = true
+
+[node name="CollisionShape3D" type="CollisionShape3D" parent="RigidBody3D"]
+transform = Transform3D(1, 0, 0, 0, -4.37114e-08, -1, 0, 1, -4.37114e-08, 0, 0, 0)
+shape = SubResource("CylinderShape3D_l3sdq")
+
 [node name="GPUParticles3D" type="GPUParticles3D" parent="."]
 transform = Transform3D(1, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0.18476)
 material_override = SubResource("StandardMaterial3D_ynv38")
 emitting = false
 amount = 10
+lifetime = 6.29
 one_shot = true
 explosiveness = 1.0
 process_material = SubResource("ParticleProcessMaterial_58cgi")
 draw_pass_1 = SubResource("BoxMesh_mfkmi")
 
-[node name="Timer" type="Timer" parent="."]
-wait_time = 10.0
-one_shot = true
-autostart = true
-
-[connection signal="timeout" from="Timer" to="." method="_on_timer_timeout"]
+[connection signal="timeout" from="RigidBody3D/Timer" to="." method="_on_timer_timeout"]

scenes/weapon/guns/ak/bullet.gd

@@ -3,7 +3,6 @@ extends Node3D
 const SPEED = 715
 
 @onready var mesh = $Object_10
-@onready var trace = $Trace
 
 # Called when the node enters the scene tree for the first time.
 func _ready() -> void:
@@ -13,12 +12,6 @@ func _ready() -> void:
 # Called every frame. 'delta' is the elapsed time since the previous frame.
 func _process(delta):
 	position += transform.basis * Vector3(0, 0, SPEED) * delta
-	trace.collision_mask = 1
-	trace.enabled = 1
-	if trace.is_colliding():
-		mesh.visible = false
-		await get_tree().create_timer(1.0).timeout
-		queue_free()
 
 
 func _on_timer_timeout():

scenes/weapon/guns/ak/bullet.tscn

@@ -52,9 +52,5 @@ transform = Transform3D(1, 0, 0, 0, -4.37114e-08, -1, 0, 1, -4.37114e-08, 0, 0,
 mesh = SubResource("ArrayMesh_uqgp1")
 skeleton = NodePath("")
 
-[node name="Trace" type="RayCast3D" parent="."]
-target_position = Vector3(0, 0, 1)
-hit_back_faces = false
-collide_with_areas = true
-
 [node name="Timer" type="Timer" parent="."]
+wait_time = 0.2

scenes/weapon/guns/ak/with_hands.gd

@@ -4,23 +4,30 @@ extends Node3D
 # Called when the node enters the scene tree for the first time.
 func _ready() -> void:
 	pass # Replace with function body.
-@onready var barrel: Node3D = $Barrel
+@onready var bullet_trace_distance: Node3D = $BulletTraceDistance
+@onready var bullet_trail_end: Node3D = $BulletTrailEnd
 
 func shoot() -> Error:
+	var bullet_start_node: Node3D = bullet_trace_distance.find_child("Start")
+	var bullet_end_node: Node3D = bullet_trace_distance.find_child("End")
+	if bullet_start_node and bullet_end_node:
+		var path := "res://scenes/weapon/misc/bullet_trail_generic.tscn"
+		if not ResourceLoader.exists(path):
+			return ERR_DOES_NOT_EXIST
+		var scene: PackedScene = ResourceLoader.load(path)
+		if not scene.can_instantiate():
+			return ERR_CANT_OPEN
+		
+		var node: MeshInstance3D = scene.instantiate()
+		node.init(bullet_start_node.global_position, bullet_end_node.global_position)
+		var root := get_tree().get_root()
+		root.add_child(node)
+		return OK
+	else:
+		push_warning("Couldn't generate a bullet trace, no distance node found")
+		return ERR_BUG
 	# -- TODO: It should not be hardcoded
-	var path := "res://scenes/weapon/guns/ak/bullet.tscn"
-	if not ResourceLoader.exists(path):
-		return ERR_DOES_NOT_EXIST
-	var scene: PackedScene = ResourceLoader.load(path)
-	if not scene.can_instantiate():
-		return ERR_CANT_OPEN
-	var node: Node3D = scene.instantiate()
-	var root := get_tree().get_root()
-	node.position = barrel.global_position
-	node.transform.basis = barrel.global_transform.basis
-	root.add_child(node)
-	return OK
-
+	
 # Called every frame. 'delta' is the elapsed time since the previous frame.
 func _process(delta: float) -> void:
 	pass

scenes/weapon/guns/ak/with_hands.tscn

@@ -1,7 +1,8 @@
-[gd_scene load_steps=54 format=4 uid="uid://dtvo21mk1webd"]
+[gd_scene load_steps=55 format=4 uid="uid://dtvo21mk1webd"]
 
 [ext_resource type="Script" path="res://scenes/weapon/guns/ak/with_hands.gd" id="1_2iqts"]
 [ext_resource type="PackedScene" uid="uid://dab7jttp7ywfh" path="res://scenes/weapon/guns/ak/gun.tscn" id="1_aaafm"]
+[ext_resource type="PackedScene" uid="uid://bjyltbtx45cqs" path="res://scenes/weapon/misc/bullet_trace_distance.tscn" id="3_5ff4y"]
 
 [sub_resource type="StandardMaterial3D" id="StandardMaterial3D_tg27p"]
 
@@ -734,5 +735,5 @@ transform = Transform3D(1, 0, 0, 0, 1, 0, 0, 0, 1, 0.286444, 0, -0.397435)
 mesh = SubResource("ArrayMesh_kj4i3")
 skeleton = NodePath("")
 
-[node name="Barrel" type="Node3D" parent="."]
-transform = Transform3D(-1, 0, 8.74228e-08, 0, 1, 0, -8.74228e-08, 0, -1, 0, 0.161938, -4.38604)
+[node name="BulletTraceDistance" parent="." instance=ExtResource("3_5ff4y")]
+transform = Transform3D(-1, 0, -8.74228e-08, 0, 1, 0, 8.74228e-08, 0, -1, -3.86167e-07, 0.200684, -4.41724)

scenes/weapon/misc/bullet_trace_distance.tscn

@@ -0,0 +1,8 @@
+[gd_scene format=3 uid="uid://bjyltbtx45cqs"]
+
+[node name="BulletTraceDistance" type="Node3D"]
+
+[node name="Start" type="Node3D" parent="."]
+
+[node name="End" type="Node3D" parent="."]
+transform = Transform3D(1, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 300)

scenes/weapon/misc/bullet_trail_generic.gd

@@ -0,0 +1,22 @@
+extends MeshInstance3D
+
+func init(pos1, pos2):
+	var draw_mesh := ImmediateMesh.new()
+	mesh = draw_mesh
+	draw_mesh.surface_begin(Mesh.PRIMITIVE_LINES, material_override)
+	draw_mesh.surface_add_vertex(pos1)
+	draw_mesh.surface_add_vertex(pos2)
+	draw_mesh.surface_end()
+
+# Called when the node enters the scene tree for the first time.
+func _ready() -> void:
+	pass # Replace with function body.
+
+
+# Called every frame. 'delta' is the elapsed time since the previous frame.
+func _process(delta: float) -> void:
+	pass
+
+
+func _on_timer_timeout() -> void:
+	queue_free()

scenes/weapon/misc/bullet_trail_generic.tscn

@@ -0,0 +1,20 @@
+[gd_scene load_steps=3 format=3 uid="uid://balgqtw1ijpw3"]
+
+[ext_resource type="Script" path="res://scenes/weapon/misc/bullet_trail_generic.gd" id="1_k8eg1"]
+
+[sub_resource type="StandardMaterial3D" id="StandardMaterial3D_ybqvs"]
+albedo_color = Color(0.934388, 0.967243, 0.955863, 1)
+emission = Color(1, 1, 1, 1)
+emission_energy_multiplier = 2.7
+
+[node name="BulletTrailGeneric" type="MeshInstance3D"]
+material_override = SubResource("StandardMaterial3D_ybqvs")
+visibility_range_end = 1891.27
+script = ExtResource("1_k8eg1")
+
+[node name="Timer" type="Timer" parent="."]
+wait_time = 0.05
+one_shot = true
+autostart = true
+
+[connection signal="timeout" from="Timer" to="." method="_on_timer_timeout"]

scenes/weapon/misc/muzzle_flash.tscn

@@ -0,0 +1,3 @@
+[gd_scene format=3 uid="uid://bfelcp5dmag5r"]
+
+[node name="MuzzleFlash" type="MeshInstance3D"]